-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LHN debugging to Debug Mode #48442
Merged
neil-marcellini
merged 27 commits into
Expensify:main
from
callstack-internal:pac-guerreiro/feature/46992-add-lhn-debugging-to-debug-mode
Oct 7, 2024
Merged
Changes from 25 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
852e9dc
feat: add reasons for showing reports in LHN
pac-guerreiro b2fcff1
refactor(debug): apply chirag suggestions
pac-guerreiro eb30a1a
refactor(debug): reduce type cast usage
pac-guerreiro 62f9775
fix(debug): missing spanish translations for empty field sections
pac-guerreiro 2336e43
fix(debug): merge conflicts
pac-guerreiro 31a8c94
fix(debug): styles
pac-guerreiro efd60b6
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro 4e0da01
chore(debug): fix linter issues
pac-guerreiro 772c0d1
chore(debug): fix unit tests
pac-guerreiro 3a36d86
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro a90b8c2
fix(debug): missing report action for invoices missing a bank account
pac-guerreiro 76ef287
refactor(debug): apply suggestions
pac-guerreiro b509c00
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro 9d5fbca
refactor(debug): apply linter
pac-guerreiro 0b4d1f0
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro c9ad33e
fix(debug): missing view button for GBR triggered by pending task
pac-guerreiro e3ed10f
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro 85db7dd
refactor(debug): eliminate flakiness from debug mode
pac-guerreiro d5f274d
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro 35004c7
fix(debug): GBR can be true when RBR is true in report debug page
pac-guerreiro 9bc09dc
refactor: apply suggestions
pac-guerreiro 0123142
chore(debug): apply suggestions and fix RBR debugging edge cases
pac-guerreiro 320b72f
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro 30b0308
refactor(debug): apply suggestions
pac-guerreiro 8260bb1
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro 1fff689
refactor: apply suggestions
pac-guerreiro 8c48c05
Merge branch 'main' into pac-guerreiro/feature/46992-add-lhn-debuggin…
pac-guerreiro File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action
is more inclusive thantask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but isWaitingForAssigneeToCompleteAction only be used in case the user needs to complete the task.
Anyways, It still is fine if we keep 'action'.