Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change address state to use value instead of default value #48435

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Change address state to use value instead of default value #48435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6891bd
Change address state to use value instead of default value
abzokhattab Sep 2, 2024
8fe414c
Minor edit
abzokhattab Sep 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/components/AddressForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import useLocalize from '@hooks/useLocalize';
import useThemeStyles from '@hooks/useThemeStyles';
import * as ErrorUtils from '@libs/ErrorUtils';
import * as ValidationUtils from '@libs/ValidationUtils';
import CONST from '@src/CONST';
import type {Country} from '@src/CONST';
import CONST from '@src/CONST';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's this change for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing has changed; this is just a rearrangement that occurred when the new import was introduced and the file was saved (auto-format)

import type ONYXKEYS from '@src/ONYXKEYS';
import INPUT_IDS from '@src/types/form/HomeAddressForm';
import type {Errors} from '@src/types/onyx/OnyxCommon';
Expand All @@ -14,6 +14,7 @@ import CountrySelector from './CountrySelector';
import FormProvider from './Form/FormProvider';
import InputWrapper from './Form/InputWrapper';
import type {FormOnyxValues} from './Form/types';
import type {State} from './StateSelector';
import StateSelector from './StateSelector';
import TextInput from './TextInput';

Expand Down Expand Up @@ -192,7 +193,7 @@ function AddressForm({
<InputWrapper
InputComponent={StateSelector}
inputID={INPUT_IDS.STATE}
defaultValue={state}
value={state as State}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid typecast but I see it's already existing pattern:

App/src/pages/ReimbursementAccount/AddressFormFields.tsx

Line 80 in ec8a5d9

value={values?.state as State}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree its used in another file that's why i followed the same pattern

onValueChange={onAddressChanged}
shouldSaveDraft={shouldSaveDraft}
/>
Expand Down
Loading