Fix/47308 workspace feed cleanup #48408

koko57 · 2024-09-02T14:03:22Z

Details

Fixed Issues

$ #47308
$ #48376
PROPOSAL:

Tests

PREREQUISITES: workspace feed / all betas enabled, Expensify Card enabled, accounting enabled

Reconciliation Account

Go to Workspaces -> Accounting -> Card Reconciliation -> Reconciliation account
Change account
Verify that the UpdateExpensifyCardSettlementAccount request is sent

Card Name

Go to Issue New Card flow
Go through the flow, do not change the default card name (should be "[userName]'s Card")
Go to Confirmation, then select Cardholder to change the assignee
Change the assignee
After going back to confirmation the name should be "[userName]'s Card" where userName will change to the name of the newly selected user
(You can do it in the same flow before you issue the card or in a new flow) Go to the card name step, change it for a custom name.
Repeat steps 3-4.
Verify that after changing the assignee the custom name is not changed.

Verify that no errors appear in the JS console

Offline tests

QA Steps

same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-09-02.at.16.45.30.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-02.at.16.37.33.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-02.at.16.40.07.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-09-02.at.15.21.46.mp4

MacOS: Desktop

Screen.Recording.2024-09-02.at.16.26.12.mp4

… account

koko57 · 2024-09-02T14:35:32Z

@mountiny I'm getting code 666 for the response, but it's probably because I don't have accounting connection set up and I just did a workaround to test it.

I also included the testing steps for system DMs, but I can remove it if the BE is not ready

melvin-bot · 2024-09-02T14:47:18Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-09-02T16:42:43Z

The react compiler action is not happy.

You can create a free trial qbo account to connect to qbo and test that i think. @allgandalf or @DylanDylann could try that

koko57 · 2024-09-02T16:59:47Z

Strange, it failed to compile a lot components that I haven't even touched

mountiny · 2024-09-02T17:27:31Z

I think the action takes a diff of files it can compile on main an on thi branch and if there is a single file that is newly un-compilable it would fail. So its ok it is listing files we did not touch but there will be probably one that this PR made unable to compile. I will rerun this action just in case

mountiny · 2024-09-02T17:29:00Z

src/pages/workspace/expensifyCard/WorkspaceCardsListLabel.tsx

-    // TODO: instead of the first bankAccount on the list get settlementBankAccountID from the private_expensifyCardSettings NVP and check if that is connected via Plaid.
-    const isConnectedWithPlaid = useMemo(() => !!Object.values(bankAccountList ?? {})[0]?.accountData?.additionalData?.plaidAccountID, [bankAccountList]);
+    const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.PRIVATE_EXPENSIFY_CARD_SETTINGS}${workspaceAccountID}`);
+    const isConnectedWithPlaid = useMemo(


I believe its complaining about this file

koko57 · 2024-09-02T19:17:44Z

@mountiny now it succeed

allgandalf · 2024-09-02T19:19:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-09-03.at.12.56.03.AM.mov

MacOS: Desktop

Screen.Recording.2024-09-03.at.12.58.30.AM.mov

Android: Native

Screen.Recording.2024-09-03.at.1.08.21.AM.mov

Android: mWeb Chrome

Screen.Recording.2024-09-03.at.1.09.44.AM.mov

iOS: Native

Screen.Recording.2024-09-03.at.1.01.28.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-09-03.at.1.02.46.AM.mov

src/libs/API/parameters/RequestExpensifyCardLimitIncreaseParams.ts

allgandalf

LGTM, lets ship it 🚀

mountiny

Thanks, looks good to me, I will remove the report action test steps from the QA as it cannot be QAed yet

OSBotify · 2024-09-02T20:28:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-02T23:46:14Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.28-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mvtglobally · 2024-09-03T15:38:09Z

@mountiny we're not able to change the reconciliation account yet, so will not be able to test that part. Any chance you can QA this PR internally to ensure full coverage?

roryabraham · 2024-09-03T23:00:39Z

@mountiny I'm checking this off as the last PR on the checklist despite the fact that Applause hasn't been able to fully verify it. Please perform internal QA on this to make sure it worked as expected. Thanks!

OSBotify · 2024-09-03T23:26:50Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.28-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

koko57 added 6 commits August 30, 2024 14:59

fix: uncomment requestExpensifyCardLimitIncrease

e5840df

fix: trigger UpdateCardSettlementAccount when changing reconciliation…

595cf0f

… account

Merge branch 'main' into fix/47308-workspace-feed-cleanup

a0ab045

fix: change default name when assignee is changed

9c2b304

feat: change mocked value for originalMessage.assigneeAccountID

73dfad4

fix: lint

1553143

koko57 marked this pull request as ready for review September 2, 2024 14:47

koko57 requested a review from a team as a code owner September 2, 2024 14:47

melvin-bot bot requested review from allgandalf and removed request for a team September 2, 2024 14:47

This was referenced Sep 2, 2024

[Workspace Feeds] Clean up tasks for workspace feeds #47308

Closed

[Workspace Feeds] Expensify Card - Card name does not change each time a different member is selected #48376

Closed

mountiny reviewed Sep 2, 2024

View reviewed changes

mountiny assigned koko57 Sep 2, 2024

fix: minor fix

f4b8e0d

allgandalf reviewed Sep 2, 2024

View reviewed changes

src/libs/API/parameters/RequestExpensifyCardLimitIncreaseParams.ts Show resolved Hide resolved

allgandalf approved these changes Sep 2, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny September 2, 2024 19:41

mountiny approved these changes Sep 2, 2024

View reviewed changes

mountiny merged commit 1dbb2af into Expensify:main Sep 2, 2024
18 of 20 checks passed

github-actions bot mentioned this pull request Sep 2, 2024

Deploy Checklist: New Expensify 2024-09-02 #48438

Closed

46 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/47308 workspace feed cleanup #48408

Fix/47308 workspace feed cleanup #48408

koko57 commented Sep 2, 2024 •

edited by mountiny

Loading

koko57 commented Sep 2, 2024 •

edited

Loading

melvin-bot bot commented Sep 2, 2024

mountiny commented Sep 2, 2024

koko57 commented Sep 2, 2024

mountiny commented Sep 2, 2024

mountiny Sep 2, 2024

koko57 commented Sep 2, 2024

allgandalf commented Sep 2, 2024 •

edited

Loading

allgandalf left a comment

mountiny left a comment

OSBotify commented Sep 2, 2024

OSBotify commented Sep 2, 2024

mvtglobally commented Sep 3, 2024

roryabraham commented Sep 3, 2024

OSBotify commented Sep 3, 2024

Fix/47308 workspace feed cleanup #48408

Fix/47308 workspace feed cleanup #48408

Conversation

koko57 commented Sep 2, 2024 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

koko57 commented Sep 2, 2024 • edited Loading

melvin-bot bot commented Sep 2, 2024

mountiny commented Sep 2, 2024

koko57 commented Sep 2, 2024

mountiny commented Sep 2, 2024

mountiny Sep 2, 2024

Choose a reason for hiding this comment

koko57 commented Sep 2, 2024

allgandalf commented Sep 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 2, 2024

OSBotify commented Sep 2, 2024

mvtglobally commented Sep 3, 2024

roryabraham commented Sep 3, 2024

OSBotify commented Sep 3, 2024

koko57 commented Sep 2, 2024 •

edited by mountiny

Loading

koko57 commented Sep 2, 2024 •

edited

Loading

allgandalf commented Sep 2, 2024 •

edited

Loading