-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OldDot Rules Migration] Tag rules #48325
Merged
marcaaron
merged 36 commits into
Expensify:main
from
software-mansion-labs:brtqkr/47016-tag-rules
Sep 19, 2024
Merged
Changes from 32 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
53828c7
Add WorkspaceMembersSelectionList
WojtekBoman 374f298
add interface for tag edit
BrtqKr 299856e
wire up the tags
BrtqKr 4a3bfcc
wire up action
BrtqKr d64e7b6
Merge remote-tracking branch 'origin/main' into brtqkr/47016-tag-rules
BrtqKr 10dbc8e
cleanup, modify action
BrtqKr e9dbc5c
change translations
BrtqKr 99d973f
Merge remote-tracking branch 'origin/main' into brtqkr/47016-tag-rules
BrtqKr 78df971
add remove approver option
BrtqKr 7f792c8
disable when workflows are disabled
BrtqKr 6163fe5
add approver conditon
BrtqKr bd3fdba
add approver conditon to category settings
BrtqKr 21d8f3d
replace values with const
BrtqKr d7cb964
change conditon for find category approver
BrtqKr 5c0b778
ts fix
BrtqKr 804c601
use getCategoryApproverRule in the actions
BrtqKr c43913b
change offline pattern for tags
BrtqKr 4770792
ts fix
BrtqKr e0e1d5b
make pending keys unique
BrtqKr 57a13f2
review fixes
BrtqKr 9fe0ff3
Merge remote-tracking branch 'origin/main' into brtqkr/47016-tag-rules
BrtqKr d7e902a
Merge remote-tracking branch 'origin/main' into brtqkr/47016-tag-rules
BrtqKr fe5f31c
update category rule when renaming category
BrtqKr bc4eed8
update tag rule when renaming tag
BrtqKr 6fc0879
remove pending action pattern for rules
BrtqKr 69d919a
Merge remote-tracking branch 'origin/main' into brtqkr/47016-tag-rules
BrtqKr 08cf2a2
fix onyx check
BrtqKr b32ed64
remove pending pattern from type
BrtqKr 71c8ef8
run prettier
BrtqKr 669e692
cleanup
BrtqKr 4fccbb1
cleanup
BrtqKr 2fdea82
remove withOnyx
BrtqKr d91e3f3
Merge remote-tracking branch 'origin/main' into brtqkr/47016-tag-rules
BrtqKr 4810e33
run prettier
BrtqKr 2ba3191
cleanup
BrtqKr e06551c
rename connection
BrtqKr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
type SetPolicyTagApproverParams = { | ||
policyID: string; | ||
tagName: string; | ||
approver: string | null; | ||
}; | ||
|
||
export default SetPolicyTagApproverParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
import type {OnyxCollection} from 'react-native-onyx'; | ||
import Onyx from 'react-native-onyx'; | ||
import ONYXKEYS from '@src/ONYXKEYS'; | ||
import type {ReportActions} from '@src/types/onyx/ReportAction'; | ||
|
||
let allReportActions: OnyxCollection<ReportActions>; | ||
Onyx.connect({ | ||
key: ONYXKEYS.COLLECTION.REPORT_ACTIONS, | ||
waitForCollectionCallback: true, | ||
callback: (actions) => { | ||
if (!actions) { | ||
return; | ||
} | ||
|
||
allReportActions = actions; | ||
}, | ||
}); | ||
|
||
// This function is used to get all reports | ||
function getAllReportActions() { | ||
return allReportActions; | ||
} | ||
|
||
// eslint-disable-next-line import/prefer-default-export | ||
export {getAllReportActions}; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB we could probably move this to the
general
since it is used twice.