Hide add to group button for notification and chronos account #47770

bernhardoj · 2024-08-21T06:38:23Z

Details

We don't want user to be able to add notifications and chronos account to a group.

Fixed Issues

$ #43841
PROPOSAL: #43841 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Press FAB > Start Chat
Search for [email protected]
Verify there is no "Add to group" button for the account

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

anroid.mweb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-08-21T06:38:28Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-08-21T06:40:59Z

src/CONST.ts

+    // Account IDs that can't be added as a group member
+    get NON_ADDABLE_ACCOUNT_IDS() {
+        return [this.ACCOUNT_ID.NOTIFICATIONS, this.ACCOUNT_ID.CHRONOS];
+    },


Based on this comment, we don't want the add to group button to show for Chronos too, so I created a new list here.

But, I see that on the group invite list page, we exclude all expensify accounts, including Concierge, so searching for those accounts won't show up in the invitation search list.

App/src/pages/InviteReportParticipantsPage.tsx

Lines 52 to 53 in 685bb4c

const excludedUsers = useMemo(

() => [...PersonalDetailsUtils.getLoginsByAccountIDs(ReportUtils.getParticipantsAccountIDsForDisplay(report, false, true)), ...CONST.EXPENSIFY_EMAILS],

Should we hide the add to group button for all expensify accounts?

@iwiznia @trjExpensify @abdulrahuman5196

Historically, people have been able to have a groupDM with Concierge for support. It's the same as emailing [email protected] with additional email addresses. That said, now we have transitioned to "Groups" where membership isn't fixed on creation (meaning, everyone else in the group can leave freely), does that cause problems and someone can end up with two Concierge DMs if that happens? 🤔 CC: @marcaaron @JmillsExpensify

We ended up covering this case in the Group Chats design doc. The intended design spec should work like this.

A goal of this doc is to completely deprecate Group DMs in favor of Group Chats. In doing that, the behavior of chatting with Concierge via email will change a bit. When a user emails Concierge and CC’s another user we will create a new Group Chat instead of trying to locate an existing chat between the participants. The consequence is that some historical chat messages between these participants can exist across several different reports vs. just one. This is a case we can potentially optimize for in the future, but decided to completely deprecate the Group DM pattern for now.

Got it, so in product you should be able to Add to group Concierge still? If everyone else is removed/leaves, it'll still be a "Group" technically and not be confused with the Concierge DM?

If everyone else is removed/leaves, it'll still be a "Group" technically and not be confused with the Concierge DM?

Removing all group members won't convert it to a DM. Leaving the group chat will remove the report.

Based on the design spec, then we should be able to add a concierge to the group. We can update the non-addable to group account list later if needed.

Yeah basically Group Chats are not defined by the number or makeup of their members. You can have a Group Chat with yourself as the only user. You can have a Group Chat with you and Concierge. You can remove Concierge from that chat later if you want. The 1:1 DM with Concierge will always be a 1:1 DM with Concierge though and you should not have more than 1 of those. Hope that makes sense!

Great, thanks for the confirmation!

@abdulrahuman5196 we can start the review here then

…-be-added-to-group

abdulrahuman5196 · 2024-08-25T18:13:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-25.at.11.35.40.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-08-25.at.11.37.29.PM.mov

iOS: Native

Screen.Recording.2024-08-25.at.11.32.30.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-08-25.at.11.34.24.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-25.at.11.23.16.PM.mov

MacOS: Desktop

Screen.Recording.2024-08-25.at.11.24.40.PM.mov

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @iwiznia

🎀 👀 🎀
C+ Reviewed

abdulrahuman5196 · 2024-08-29T17:42:00Z

Gentle ping @iwiznia

marcaaron

@iwiznia is OOO. I can help with this.

OSBotify · 2024-08-30T01:10:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-30T18:49:15Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.0.27-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-02T23:26:57Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.27-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hide add to group button for notification and chronos account

00b5c06

bernhardoj requested a review from a team as a code owner August 21, 2024 06:38

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team August 21, 2024 06:38

bernhardoj commented Aug 21, 2024

View reviewed changes

bernhardoj added 2 commits August 23, 2024 23:08

Merge branch 'main' into fix/43841-dont-allow-adding-notifications-to…

8689ad3

…-be-added-to-group

lint

140dcff

abdulrahuman5196 approved these changes Aug 25, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia August 25, 2024 18:14

marcaaron approved these changes Aug 30, 2024

View reviewed changes

marcaaron merged commit a37a613 into Expensify:main Aug 30, 2024
16 of 18 checks passed

github-actions bot mentioned this pull request Aug 30, 2024

Deploy Checklist: New Expensify 2024-08-30 #48360

Closed

45 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide add to group button for notification and chronos account #47770

Hide add to group button for notification and chronos account #47770

bernhardoj commented Aug 21, 2024

melvin-bot bot commented Aug 21, 2024

bernhardoj Aug 21, 2024

trjExpensify Aug 23, 2024

JmillsExpensify Aug 23, 2024

trjExpensify Aug 23, 2024

bernhardoj Aug 23, 2024

marcaaron Aug 23, 2024

bernhardoj Aug 24, 2024

abdulrahuman5196 commented Aug 25, 2024

abdulrahuman5196 left a comment

abdulrahuman5196 commented Aug 29, 2024

marcaaron left a comment

OSBotify commented Aug 30, 2024

OSBotify commented Aug 30, 2024

OSBotify commented Sep 2, 2024

	const excludedUsers = useMemo(
	() => [...PersonalDetailsUtils.getLoginsByAccountIDs(ReportUtils.getParticipantsAccountIDsForDisplay(report, false, true)), ...CONST.EXPENSIFY_EMAILS],

Hide add to group button for notification and chronos account #47770

Hide add to group button for notification and chronos account #47770

Conversation

bernhardoj commented Aug 21, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 21, 2024

bernhardoj Aug 21, 2024

Choose a reason for hiding this comment

trjExpensify Aug 23, 2024

Choose a reason for hiding this comment

JmillsExpensify Aug 23, 2024

Choose a reason for hiding this comment

trjExpensify Aug 23, 2024

Choose a reason for hiding this comment

bernhardoj Aug 23, 2024

Choose a reason for hiding this comment

marcaaron Aug 23, 2024

Choose a reason for hiding this comment

bernhardoj Aug 24, 2024

Choose a reason for hiding this comment

abdulrahuman5196 commented Aug 25, 2024

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

abdulrahuman5196 commented Aug 29, 2024

marcaaron left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 30, 2024

OSBotify commented Aug 30, 2024

OSBotify commented Sep 2, 2024