[NO-QA]: Company cards toggle #47719

narefyev91 · 2024-08-20T14:38:44Z

Details

Company cards toggle in workspace More features

Fixed Issues

$ #47376
PROPOSAL:

Tests

Test with collect Plan:

Open any workspace in which you are an admin
Go to More Features
Verify that user sees a new item "Company Cards"
Switch on - verify that upgrade plan right panel will be shown
Upgrade to a new plan
Switch on -> verify that a new row appears in left menu item
Verify that the new menu item is highlighted
Click in Company Cards - Verify that a new screen is opened

Test disabled toggle:

Switch on a new feature "Company Cards"
Add true flag to line 135 src/pages/workspace/WorkspaceMoreFeaturesPage.tsx
Verify that toggle will have lock icon
Click on toggle
Verify that toggle is still in active state
Verify that modal is shown
Verify that Cancel button is closing modal
Verify that go to concierge button will open concierge chat

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

desktop2.mov

melvin-bot · 2024-08-20T14:38:50Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

# Conflicts: # src/libs/API/parameters/index.ts

assets/images/simple-illustrations/simple-illustration__twocards-horizontal.svg

Pujan92 · 2024-08-21T17:55:41Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

ancc2.webm

Android: mWeb Chrome

andcc1.webm

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-22.at.00.10.02.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-22.at.00.15.40.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-08-21.at.23.43.54.mov

MacOS: Desktop

Screen.Recording.2024-08-22.at.00.13.16.mov

Pujan92 · 2024-08-21T17:59:54Z

@narefyev91 are you getting a success response from EnablePolicyCompanyCards API? I am receiving 404 for it.

Pujan92

LGTM, for 404 api error I believe the backend isn't updated yet.

melvin-bot · 2024-08-21T18:57:00Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #47376 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

Pujan92

Approving again to assign an internal engineer.

# Conflicts: # src/CONST.ts # src/languages/en.ts # src/languages/es.ts # src/libs/Navigation/types.ts # src/pages/workspace/WorkspaceInitialPage.tsx

narefyev91 · 2024-08-23T08:29:16Z

@iwiznia friendly bump on this one - we need this PR to merge to unblock others
cc @mountiny @alexpensify

src/libs/Navigation/types.ts

src/libs/actions/Policy/Policy.ts

src/pages/workspace/WorkspaceMoreFeaturesPage.tsx

src/ROUTES.ts

koko57 · 2024-08-23T14:32:31Z

@iwiznia approved

OSBotify · 2024-08-23T14:53:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-26T23:19:15Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.0.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-08-27T00:09:37Z

🚀 Deployed to staging by https://github.com/iwiznia in version: 9.0.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Company cards toggle

43cf578

narefyev91 requested review from a team as code owners August 20, 2024 14:38

melvin-bot bot requested review from Pujan92 and removed request for a team August 20, 2024 14:38

Merge branch 'refs/heads/main' into company-cards-initial-setup

0a8a904

# Conflicts: # src/libs/API/parameters/index.ts

shawnborton reviewed Aug 20, 2024

View reviewed changes

assets/images/simple-illustrations/simple-illustration__twocards-horizontal.svg Outdated Show resolved Hide resolved

update icon

ee8ed54

narefyev91 changed the title ~~Company cards toggle~~ [NO-QA]: Company cards toggle Aug 21, 2024

updates

4441dc0

Pujan92 approved these changes Aug 21, 2024

View reviewed changes

melvin-bot bot requested a review from iwiznia August 21, 2024 19:00

This was referenced Aug 22, 2024

[No QA] [3rd Party Feeds] Feeds Selector page #47851

Merged

[hold for payment 2024-09-10] [3rd Party Feeds] Card Feed Settings #47378

Closed

Merge branch 'refs/heads/main' into company-cards-initial-setup

a2645b5

# Conflicts: # src/CONST.ts # src/languages/en.ts # src/languages/es.ts # src/libs/Navigation/types.ts # src/pages/workspace/WorkspaceInitialPage.tsx

koko57 reviewed Aug 23, 2024

View reviewed changes

src/libs/Navigation/types.ts Show resolved Hide resolved

remove duplication after merge conflicts

7b2f7b8

iwiznia requested changes Aug 23, 2024

View reviewed changes

koko57 reviewed Aug 23, 2024

View reviewed changes

src/ROUTES.ts Outdated Show resolved Hide resolved

fixes after review

e61db6c

narefyev91 requested a review from iwiznia August 23, 2024 14:02

iwiznia approved these changes Aug 23, 2024

View reviewed changes

iwiznia requested a review from koko57 August 23, 2024 14:20

koko57 approved these changes Aug 23, 2024

View reviewed changes

iwiznia merged commit d6b7bd8 into Expensify:main Aug 23, 2024
17 checks passed

github-actions bot mentioned this pull request Aug 26, 2024

Deploy Checklist: New Expensify 2024-08-26 #48035

Closed

joekaufmanexpensify mentioned this pull request Sep 3, 2024

[$250] Upgrading for Company Cards doesn't enable Company Cards #48425

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO-QA]: Company cards toggle #47719

[NO-QA]: Company cards toggle #47719

narefyev91 commented Aug 20, 2024 •

edited

Loading

melvin-bot bot commented Aug 20, 2024

Pujan92 commented Aug 21, 2024 •

edited

Loading

Pujan92 commented Aug 21, 2024

Pujan92 left a comment

melvin-bot bot commented Aug 21, 2024

Pujan92 left a comment

narefyev91 commented Aug 23, 2024

koko57 commented Aug 23, 2024

OSBotify commented Aug 23, 2024

OSBotify commented Aug 26, 2024

OSBotify commented Aug 27, 2024

[NO-QA]: Company cards toggle #47719

[NO-QA]: Company cards toggle #47719

Conversation

narefyev91 commented Aug 20, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 20, 2024

Pujan92 commented Aug 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

Pujan92 commented Aug 21, 2024

Pujan92 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 21, 2024

Pujan92 left a comment

Choose a reason for hiding this comment

narefyev91 commented Aug 23, 2024

koko57 commented Aug 23, 2024

OSBotify commented Aug 23, 2024

OSBotify commented Aug 26, 2024

OSBotify commented Aug 27, 2024

narefyev91 commented Aug 20, 2024 •

edited

Loading

Pujan92 commented Aug 21, 2024 •

edited

Loading