-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Chat - Unable to deselect user using The Tab key. #47705
Conversation
Signed-off-by: krishna2323 <[email protected]>
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: Native2024-08-20.19.59.40.movAndroid: mWeb Chrome2024-08-20.20.01.32.moviOS: Nativeios.moviOS: mWeb Safariios-web.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
Could you provide videos for buttons which were IMAGEBUTTONs, please? |
And we only have one place left where we use ACCESSIBILITY_ROLE App/src/components/Button/index.tsx Line 131 in d43f6e1
Does it make sense to replace this with ROLE? |
I think so,
Monosnap.screencast.2024-08-21.03-36-31.mp4 |
Signed-off-by: krishna2323 <[email protected]>
Updated, should we remove |
I think yes |
Signed-off-by: krishna2323 <[email protected]>
@ZhenjaHorbach, removed |
It looks like deleting ACCESSIBILITY_ROLE didn't cause any regressions |
Okay, so I think this is mostly fine! The only changes I'm a bit concerned about are the swaps from It might be fine though? @stitesExpensify do you have any thoughts here since I know you're interested in accessibility stuff as well? |
Hmm yeah I'm not sure. It seems like |
given that in the react-native docs they say |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.25-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.25-0 🚀
|
Details
Fixed Issues
$ #47306
PROPOSAL: #47306 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_chrome.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_safari.mp4
MacOS: Chrome / Safari
web_chrome.mp4
MacOS: Desktop
desktop_app.mp4