Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the note of cards from the settings menu to only leave domains #47119

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Remove the note of cards from the settings menu to only leave domains #47119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
492ac2a
Remove the note of cards from the settings
mountiny Aug 8, 2024
4e7461e
Use globe icon for the domains row
mountiny Aug 8, 2024
6e64eec
Remove unused icon
mountiny Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion assets/images/cards-and-domains.svg
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/components/Icon/Expensicons.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import Calendar from '@assets/images/calendar.svg';
import Camera from '@assets/images/camera.svg';
import CarWithKey from '@assets/images/car-with-key.svg';
import Car from '@assets/images/car.svg';
import CardsAndDomains from '@assets/images/cards-and-domains.svg';
import Cash from '@assets/images/cash.svg';
import Chair from '@assets/images/chair.svg';
import ChatBubbleAdd from '@assets/images/chatbubble-add.svg';
Expand Down Expand Up @@ -220,7 +219,6 @@ export {
Calendar,
Camera,
Car,
CardsAndDomains,
Cash,
ChatBubble,
ChatBubbles,
Expand Down
2 changes: 1 addition & 1 deletion src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ export default {
},
allSettingsScreen: {
subscription: 'Subscription',
cardsAndDomains: 'Cards & Domains',
domains: 'Domains',
},
tabSelector: {
chat: 'Chat',
Expand Down
2 changes: 1 addition & 1 deletion src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,7 +618,7 @@ export default {
},
allSettingsScreen: {
subscription: 'Suscripcion',
cardsAndDomains: 'Tarjetas y Dominios',
domains: 'Dominios',
},
tabSelector: {
chat: 'Chat',
Expand Down
4 changes: 2 additions & 2 deletions src/pages/home/sidebar/AllSettingsScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ function AllSettingsScreen({policies}: AllSettingsScreenProps) {
]
: []),
{
translationKey: 'allSettingsScreen.cardsAndDomains',
icon: Expensicons.CardsAndDomains,
translationKey: 'allSettingsScreen.domains',
icon: Expensicons.Globe,
action: () => {
Link.openOldDotLink(CONST.OLDDOT_URLS.ADMIN_DOMAINS_URL);
},
Expand Down
4 changes: 2 additions & 2 deletions src/pages/settings/InitialSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ function InitialSettingsPage({session, userWallet, bankAccountList, fundList, wa
brickRoadIndicator: hasGlobalWorkspaceSettingsRBR(policies) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined,
},
{
translationKey: 'allSettingsScreen.cardsAndDomains',
icon: Expensicons.CardsAndDomains,
translationKey: 'allSettingsScreen.domains',
icon: Expensicons.Globe,
action: () => {
Link.openOldDotLink(CONST.OLDDOT_URLS.ADMIN_DOMAINS_URL);
},
Expand Down
Loading