Feat/44305 be integration configure expensify cards for policy #46564

koko57 · 2024-07-31T09:44:49Z

Details

Fixed Issues

$ #44305
PROPOSAL:

Tests

PREREQUISITES: all betas/workspaceFeed beta enabled

Go to Workspace -> select workspace (you're admin of) -> go to More Features
Enable Expensify Card -> go to Expensify Card page
Issue New Card -> you should be redirected to Choose Bank Account page
Choose a bank account from the list
Verify that ConfigureExpensifyCardsForPolicy is sent.

Verify that no errors appear in the JS console

Offline tests

QA Steps

PREREQUISITES: all betas/workspaceFeed beta enabled

Go to Workspace -> select workspace (you're admin of) -> go to More Features
Enable Expensify Card -> go to Expensify Card page
Issue New Card -> you should be redirected to Choose Bank Account page
Choose a bank account from the list
Verify that ConfigureExpensifyCardsForPolicy is sent.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…CardsForPolicy

koko57 · 2024-08-07T08:11:52Z

@MariaHCD @mountiny Can I open the PR? I'm getting 401 error on this request, but maybe because I don't have an eligible account so I sent a bankAccountID of an ineligible one. I am the workspace admin, though

mountiny · 2024-08-07T11:39:48Z

@koko57 Discussing in DM, logs are here. This error means the user is not a domain admin.

Have you created this policy and account recently? We had this bug when we initially deployed this command, where the existing policy members and admins were not added as domain admins/ members which would explain this error.

But this should be fixed for new workspace feeds

mountiny · 2024-08-07T14:59:15Z

src/libs/PolicyUtils.ts

+    if (!policy) {
+        return '';
+    }
+    return policy.workspaceAccountID ?? '';


I think the workspaceAccountID should be Number same as the user accountID

mountiny · 2024-08-07T14:59:42Z

src/types/onyx/Policy.ts

@@ -1536,6 +1536,9 @@ type Policy = OnyxCommon.OnyxValueWithOfflineFeedback<

        /** Whether GL codes are enabled */
        glCodes?: boolean;
+
+        /** Workspace account ID configured for Expensify Card */
+        workspaceAccountID?: string;


I think this has to be a number

melvin-bot · 2024-08-07T16:29:58Z

@DylanDylann @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

koko57 · 2024-08-07T16:30:49Z

opening this one for review as I can't add a bank account through VBBA for a new Workspace

koko57 · 2024-08-08T07:48:44Z

Finally were able to get a proper 200 response from the ConfigureExpensifyCardsForPolicy

koko57 · 2024-08-08T09:11:32Z

I have a problem with paymentAccountID - all of a sudden (after merging with main) it's typed like this:

I haven't changed the type - it should be number

koko57 · 2024-08-09T09:18:11Z

The API returns: "400 ConfigureExpensifyCard returned a non-200 response: 401 Missing balance verification""

Screen.Recording.2024-08-09.at.15.06.03.mov

@mountiny @MariaHCD what could have happened?

koko57 · 2024-08-09T09:20:30Z

@DylanDylann I've addressed your comment with the policyID being sent instead of workspaceAccountID, now I will address the bug you've found

koko57 · 2024-08-09T14:16:20Z

@DylanDylann issue with not redirecting to the VBBA fixed

DylanDylann · 2024-08-10T05:40:45Z

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardBankAccounts.tsx

        const eligibleBankAccounts = CardUtils.getEligibleBankAccountsForCard(bankAccountsList);

        return eligibleBankAccounts.map((bankAccount) => {
            const bankName = (bankAccount.accountData?.addressName ?? '') as BankName;
            const bankAccountNumber = bankAccount.accountData?.accountNumber ?? '';
-            // TODO: change 1 to 0 - applied for testing purposes, as sometimes accountData lacks fundID
-            const bankAccountID = bankAccount.accountData?.fundID ?? 1;
+            const bankAccountID = bankAccount.accountData?.bankAccountID ?? 0;


@koko57

First question, why do we use fundID before?

Why do we use 0 as the default value in API params? If bankAccount.accountData?.bankAccountID is undefined we should prevent from calling API instead of calling API with value as 0

@mountiny should we use fundID or bankAccountID?

it should be bankAccountID

@koko57 Bump

Why do we use 0 as the default value in API params? If bankAccount.accountData?.bankAccountID is undefined we should prevent from calling API instead of calling API with value as 0

@DylanDylann for eslint not to complain, but ok, fixed it for you

mountiny · 2024-08-11T23:07:02Z

@DylanDylann Have you connected the bank account via plaid? I can see this error can only show up if you have connected the account with Plaid as we might need to do some additional checks

DylanDylann · 2024-08-12T11:26:37Z

@mountiny I connected bank accounts following this guideline

DylanDylann · 2024-08-12T11:26:56Z

@koko57 Thanks for your update. I will review again today

koko57 · 2024-08-12T12:36:08Z

@DylanDylann great, thanks!

DylanDylann · 2024-08-12T16:33:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

MacOS: Chrome / Safari

Screen.Recording.2024-08-12.at.23.34.46.mov

DylanDylann · 2024-08-12T16:36:20Z

NOTE:

The ConfigureExpensifyCardsForPolicy API still returns the wrong data. We need to test again in #46570

mountiny

Thanks, one very minor comment, all yours @MariaHCD

mountiny · 2024-08-12T16:51:56Z

src/pages/workspace/expensifyCard/WorkspaceCardListHeader.tsx

@@ -22,7 +22,7 @@ function WorkspaceCardListHeader() {
    const isLessThanMediumScreen = isMediumScreenWidth || isSmallScreenWidth;

    // TODO: uncomment the code line below to use cardSettings data from Onyx when it's supported
-    // const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.SHARED_NVP_PRIVATE_EXPENSIFY_CARD_SETTINGS}${policyID}`);
+    // const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_SETTINGS}${policyID}`);


Suggested change

// const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_SETTINGS}${policyID}`);

// const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_SETTINGS}${workspaceAccountID}`);

mountiny

Thanks! I will merge this as Maria is ooo tomorrow

OSBotify · 2024-08-12T17:50:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-13T20:38:49Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.20-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Beamanator · 2024-08-16T19:50:44Z

FYI I believe this was deployed to prod yesterday, from this checklist - #47356

koko57 added 3 commits July 30, 2024 12:19

feat: add new write command - ConfigureExpensifyCardForPolicy

1a19a65

feat: use new api call in WorkspaceExpensifyCardBankAccounts page

3abc929

fix: replace policyID for workspaceAccountID

8cc9256

koko57 mentioned this pull request Jul 31, 2024

[$250] [Workspace Feeds] [External] Create Issue new card logic - existing bank accounts #44305

Closed

koko57 added 7 commits July 31, 2024 12:21

fix: lint

ed8ac0c

Merge branch 'main' into feat/44305-be-integration-ConfigureExpensify…

c822a00

…CardsForPolicy

fix: resolve conflicts

1e51c2a

fix: remove sharedNvp prefix

e2b5d8e

Merge branch 'main' into feat/44305-be-integration-ConfigureExpensify…

91f4dfc

…CardsForPolicy

fix: lint

03a18c7

fix: minor fix

abfb9cf

VickyStash mentioned this pull request Aug 7, 2024

[Workspace Feeds] [External] Create new Card List page #44310

Closed

mountiny assigned koko57 Aug 7, 2024

mountiny requested review from MariaHCD and mountiny August 7, 2024 11:16

mountiny requested changes Aug 7, 2024

View reviewed changes

fix: change workspaceAccountID type

8c040fb

koko57 marked this pull request as ready for review August 7, 2024 16:29

koko57 requested a review from a team as a code owner August 7, 2024 16:29

melvin-bot bot requested review from DylanDylann and mountiny and removed request for a team August 7, 2024 16:29

fix: resolve conflicts

3eec68c

fix: typecheck

bd89ae2

koko57 added 2 commits August 9, 2024 11:47

fix: minor fix

8c66efd

fix: redirect to a proper page when no elligible bank account

4620f69

koko57 mentioned this pull request Aug 9, 2024

[No QA] Issue New Card Bank Accounts Logic #45069

Merged

61 tasks

DylanDylann reviewed Aug 10, 2024

View reviewed changes

koko57 added 3 commits August 12, 2024 09:48

fix: resolve conflicts

a3c40c6

fix: typecheck

784f1f2

fix: lint

ee65625

waterim mentioned this pull request Aug 12, 2024

Feature: Integrate OpenPolicyEditCardLimitTypePage api command to the app #47092

Merged

58 tasks

fix: minor fix

b76ab11

DylanDylann approved these changes Aug 12, 2024

View reviewed changes

mountiny previously approved these changes Aug 12, 2024

View reviewed changes

fix: rename to private

39545cd

koko57 dismissed mountiny’s stale review via 39545cd August 12, 2024 17:05

fix: revert naming for reconciliation connection keys

c25fba0

mountiny approved these changes Aug 12, 2024

View reviewed changes

mountiny merged commit 3fe25da into Expensify:main Aug 12, 2024
15 checks passed

koko57 mentioned this pull request Aug 13, 2024

[Workspace Feeds] Web - Card - Added bank account isn't showing for Expensify Card #47239

Closed

6 tasks

github-actions bot mentioned this pull request Aug 13, 2024

Deploy Checklist: New Expensify 2024-08-13 #47356

Closed

72 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/44305 be integration configure expensify cards for policy #46564

Feat/44305 be integration configure expensify cards for policy #46564

koko57 commented Jul 31, 2024 •

edited by github-actions bot

Loading

koko57 commented Aug 7, 2024

mountiny commented Aug 7, 2024

mountiny Aug 7, 2024

mountiny Aug 7, 2024

melvin-bot bot commented Aug 7, 2024

koko57 commented Aug 7, 2024

koko57 commented Aug 8, 2024

koko57 commented Aug 8, 2024

koko57 commented Aug 9, 2024

koko57 commented Aug 9, 2024

koko57 commented Aug 9, 2024

DylanDylann Aug 10, 2024

koko57 Aug 12, 2024

mountiny Aug 12, 2024

DylanDylann Aug 12, 2024

koko57 Aug 12, 2024

mountiny commented Aug 11, 2024

DylanDylann commented Aug 12, 2024

DylanDylann commented Aug 12, 2024

koko57 commented Aug 12, 2024

DylanDylann commented Aug 12, 2024 •

edited

Loading

DylanDylann commented Aug 12, 2024

mountiny left a comment

mountiny Aug 12, 2024

mountiny left a comment

OSBotify commented Aug 12, 2024

OSBotify commented Aug 13, 2024

Beamanator commented Aug 16, 2024

	// const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_SETTINGS}${policyID}`);
	// const [cardSettings] = useOnyx(`${ONYXKEYS.COLLECTION.EXPENSIFY_CARD_SETTINGS}${workspaceAccountID}`);

Feat/44305 be integration configure expensify cards for policy #46564

Feat/44305 be integration configure expensify cards for policy #46564

Conversation

koko57 commented Jul 31, 2024 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

koko57 commented Aug 7, 2024

mountiny commented Aug 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Aug 7, 2024

koko57 commented Aug 7, 2024

koko57 commented Aug 8, 2024

koko57 commented Aug 8, 2024

koko57 commented Aug 9, 2024

koko57 commented Aug 9, 2024

koko57 commented Aug 9, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mountiny commented Aug 11, 2024

DylanDylann commented Aug 12, 2024

DylanDylann commented Aug 12, 2024

koko57 commented Aug 12, 2024

DylanDylann commented Aug 12, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Aug 12, 2024

NOTE:

mountiny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 12, 2024

OSBotify commented Aug 13, 2024

Beamanator commented Aug 16, 2024

koko57 commented Jul 31, 2024 •

edited by github-actions bot

Loading

DylanDylann commented Aug 12, 2024 •

edited

Loading