Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump expensify-common to v2.0.57 #46321

Merged
merged 5 commits into from
Jul 27, 2024
Merged

Bump expensify-common to v2.0.57 #46321

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7be9e68
bump expensify-common to v2.0.57
gijoe0295 Jul 26, 2024
d29e1b7
fix gh actions check failure
gijoe0295 Jul 26, 2024
1bb2fae
revert: fix gh actions check failure
gijoe0295 Jul 26, 2024
5a9dcb5
Merge branch 'gijoe/45635' of https://github.com/gijoe0295/App into g…
gijoe0295 Jul 26, 2024
59fd014
Revert "fix gh actions check failure"
gijoe0295 Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .github/actions/javascript/proposalPoliceComment/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18487,12 +18487,6 @@ class GithubUtils {
})
.then((response) => response.data.workflow_runs[0]?.id);
}
/**
* Generate the well-formatted body of a production release.
*/
static getReleaseBody(pullRequests) {
return pullRequests.map((number) => `- ${this.getPullRequestURLFromNumber(number)}`).join('\r\n');
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was to resolve this error. But let me try reverting.

Copy link
Contributor Author

@gijoe0295 gijoe0295 Jul 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@roryabraham I faced this error while upgrading expensify-common version in this PR:

Screenshot 2024-07-27 at 03 16 03

I ran npm run gh-actions-build resulting in the above lines removal. Do you have any idea why changes in this PR caused that test failure; and is the above lines removal proper? Tagging you here since you added the verifyActions test. Thanks in advance!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have touch action files in this PR. If there is an error, it must be from another PR which will be handled separately.

/**
* Generate the URL of an New Expensify pull request given the PR number.
*/
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
"date-fns-tz": "^2.0.0",
"dom-serializer": "^0.2.2",
"domhandler": "^4.3.0",
"expensify-common": "2.0.49",
"expensify-common": "2.0.57",
"expo": "^50.0.3",
"expo-av": "~13.10.4",
"expo-image": "1.11.0",
Expand Down
Loading