-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop user to main chat screen after onboarding #45705
Conversation
src/libs/Navigation/AppNavigator/Navigators/OnboardingModalNavigator.tsx
Outdated
Show resolved
Hide resolved
@filip-solecki could you please review this PR given your context |
Btw. I've tested it on newest main and on small screens I wasn't even once redirected to Concierge. I was always staying on Home screen. |
Screen.Recording.2024-07-22.at.08.02.43.mov |
I am also not able to reproduce with the latest main. |
@mountiny @filip-solecki Now I am able to reproduce the issue again. Basically, it gets navigated to the concierge sometimes and sometimes not. It seems to be reproduced when Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-23.at.11.30.00.mp4 |
@Pujan92 I updated. |
@adamgrzybowski @WojtekBoman @filip-solecki can you review as well please? Thanks |
Is there any reason to remove |
As per the issue, we need to avoid entering into the Concierge chat and stay on the home route for the smaller screens. For that reason, we removed |
And what about the wide layout? Should we redirect to the concierge chat? |
No, it is added here for the transitioning issue. But now we use
This isn't working correctly for the below usecase.
Screen.Recording.2024-07-24.at.16.51.02.mov |
@mountiny For a wider screen we can keep the existing behavior of navigating to the Concierge chat due to the use case #45705 (comment) which isn't solved only with the Thougths @filip-solecki @adamgrzybowski ? |
src/libs/Navigation/AppNavigator/Navigators/OnboardingModalNavigator.tsx
Show resolved
Hide resolved
@Pujan92 I updated. |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeabcd.webmiOS: NativeSimulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-29.at.23.35.24.mp4MacOS: Chrome / SafariScreen.Recording.2024-07-29.at.23.23.32.movMacOS: DesktopScreen.Recording.2024-07-29.at.23.48.30.mov |
src/libs/Navigation/AppNavigator/Navigators/OnboardingModalNavigator.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Bump @mountiny for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets try this one thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
FYI I believe this was deployed to prod yesterday, from this checklist - #47219 |
Details
Fixed Issues
$ #45094
PROPOSAL: #45094 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-07-19.at.00.01.42.mp4
Android: mWeb Chrome
Screen.Recording.2024-07-18.at.23.53.12.mov
iOS: Native
Screen.Recording.2024-07-18.at.23.43.43.mp4
iOS: mWeb Safari
Screen.Recording.2024-07-18.at.23.48.15.mov
MacOS: Chrome / Safari
Screen.Recording.2024-07-18.at.23.24.16.mp4
MacOS: Desktop
Screen.Recording.2024-07-18.at.23.32.52.mp4