-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Card settings page #45415
Merged
MariaHCD
merged 34 commits into
Expensify:main
from
koko57:feature/44311-card-settings-page
Jul 22, 2024
Merged
[No QA] Card settings page #45415
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
222f339
feat: setup settings page
koko57 df5c63a
feat: routes setup for account and frequency settings
koko57 3061716
feat: create account and frequency page
koko57 b86b49e
fix: resolve conflicts
koko57 9ad8395
fix: restore navigating to settings page
koko57 05f5ae8
feat: add translations, add data to be displayed on frequency page
koko57 c8d83f6
Merge branch 'main' into feature/44311-card-settings-page
koko57 640e883
Merge branch 'main' into feature/44311-card-settings-page
koko57 982795f
fix: resolve conflicts
koko57 3be64f9
fix: revert unnecessary change
koko57 15a4d3c
fix: resolve conflicts
koko57 760be43
fix: minor fix
koko57 d10c084
feat: update frequency and account logic
koko57 3f70bff
feat: add reconciliation account info, add icon to the RadioListItem
koko57 b10bae6
fix: styles
koko57 0c4ab59
fix: minor fix
koko57 28f4e49
fix: minor fixes
koko57 6ff1005
fix: resolve conflicts
koko57 9d3658a
fix: minor fixes
koko57 7a5306e
fix: change onyx key
koko57 423bc0d
fix: create type WorkspaceCardSettingsPageProps
koko57 4c7c53b
fix: move hint text to the MenuItem, create a proper condition for di…
koko57 0d40c8c
fix: lint
koko57 9ccc526
Merge branch 'main' into feature/44311-card-settings-page
koko57 08097f7
fix: apply requested changes
koko57 b0fc7c7
fix: minor fix
koko57 ade4696
fix: lint
koko57 8573725
fix: resolve conflicts
koko57 aabc037
fix: apply requested changes
koko57 e31a945
fix: reconciliation connection
koko57 5f0f41f
fix: resolve conflicts
koko57 4965c6a
fix: implement a proper back button handler
koko57 5fa6164
fix: wrap accounts content in ScrollView
koko57 eb2323b
fix: change the condition for elligible bank account
koko57 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MariaHCD @mountiny - just to make sure, sharedNVP_expensifyCard_continuousReconciliationConnection_ should store connection name, not the bank account data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, sharedNVP_expensifyCard_continuousReconciliationConnection_ will just store the name of the connection like
quickbooksOnline
,xero
,netsuite
orintacct
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, thanks! So it's now fixed in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not related but just for info, is that an
array
? can we have multiple connections at once?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will just be a string. I believe it's only one connection at a time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, thanks