fix: list not scrolling to the linked report action #44819

hurali97 · 2024-07-04T11:26:58Z

Details

This fixes the issue where the list doesn't scroll to the linked report action. This happens because isLoadingApp is false and that’s why the ?? operator doesn’t execute the right hand side. So the solution is to use || operator, so that the right hand side is evaluated if LHS is false.

Fixed Issues

$ #44625
PROPOSAL:

Tests

Open a chat with a user and send a lot of comments so that there is a scrollable history
Go to the top comment and copy the link to that comment
Open another chat and navigate to the copied link
Verify that the chat page scrolls to that specific comment

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

Not able to load the web app on emulator

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-07-04T11:27:03Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rayane-djouah · 2024-07-04T11:28:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

screen-20240704-140248.mp4

Android: mWeb Chrome

screen-20240704-131520.mp4

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-04.at.13.08.31.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-07-04.at.13.04.57.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-07-04.at.12.47.12.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-04.at.12.48.14.PM.mov

mountiny · 2024-07-04T12:24:45Z

Screen.Recording.2024-07-04.at.13.16.59.mp4

github-actions · 2024-07-04T12:33:05Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/44819/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/44819/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://44819.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

mountiny · 2024-07-04T13:02:01Z

src/pages/home/ReportScreen.tsx

@@ -406,7 +406,8 @@ function ReportScreen({
        return reportIDFromRoute !== '' && !!report.reportID && !isTransitioning;
    }, [report, reportIDFromRoute]);

-    const isLoading = isLoadingApp ?? (!reportIDFromRoute || (!isSidebarLoaded && !isReportOpenInRHP) || PersonalDetailsUtils.isPersonalDetailsEmpty());
+    // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing


It might be good to leave some comment why we have to use || here

rayane-djouah

Looks good! Thank you

mountiny

Thanks, going to merge this now as Bondy is ooo for the rest of the week I believe

OSBotify · 2024-07-04T16:33:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T09:58:34Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:54:57Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:06:47Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:25:29Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hurali97 added 2 commits July 4, 2024 16:20

fix: list not scrolling to the linked action

0f24979

revert: [CP Staging] Add back comment linking beta

e19bc4a

hurali97 requested a review from a team as a code owner July 4, 2024 11:26

melvin-bot bot requested review from rayane-djouah and removed request for a team July 4, 2024 11:27

mountiny assigned hurali97 Jul 4, 2024

mountiny added the Ready To Build label Jul 4, 2024

mountiny previously approved these changes Jul 4, 2024

View reviewed changes

rayane-djouah approved these changes Jul 4, 2024

View reviewed changes

melvin-bot bot requested a review from bondydaa July 4, 2024 13:07

docs: add comments

d6add19

hurali97 dismissed mountiny’s stale review via d6add19 July 4, 2024 13:21

mountiny approved these changes Jul 4, 2024

View reviewed changes

mountiny merged commit f73cdc4 into Expensify:main Jul 4, 2024
15 of 16 checks passed

This was referenced Jul 4, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Build apk from delta ref #44857

Closed

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

lanitochka17 mentioned this pull request Jul 9, 2024

mWeb - Chat scrolls back to linked message after receiving new message #45093

Closed

6 tasks

melvin-bot bot mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-24] [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] [$250] Comment link - Navigating to a report action comment doesn't scroll the report page #44625

Closed

6 tasks

rayane-djouah mentioned this pull request Jul 20, 2024

Fix deep linking to reports after signing in #43307

Merged

48 tasks

kirillzyusko mentioned this pull request Oct 18, 2024

fix: do not show spinner if data is already there #51098

Merged

48 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: list not scrolling to the linked report action #44819

fix: list not scrolling to the linked report action #44819

hurali97 commented Jul 4, 2024 •

edited

Loading

melvin-bot bot commented Jul 4, 2024

rayane-djouah commented Jul 4, 2024 •

edited

Loading

mountiny commented Jul 4, 2024

github-actions bot commented Jul 4, 2024

mountiny Jul 4, 2024

rayane-djouah left a comment

mountiny left a comment

OSBotify commented Jul 4, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

fix: list not scrolling to the linked report action #44819

fix: list not scrolling to the linked report action #44819

Conversation

hurali97 commented Jul 4, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 4, 2024

rayane-djouah commented Jul 4, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

mountiny commented Jul 4, 2024

github-actions bot commented Jul 4, 2024

mountiny Jul 4, 2024

Choose a reason for hiding this comment

rayane-djouah left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 4, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

hurali97 commented Jul 4, 2024 •

edited

Loading

rayane-djouah commented Jul 4, 2024 •

edited

Loading