[No QA]: Workspace Feed - Initial card page #44770

narefyev91 · 2024-07-03T12:08:01Z

Details

Workspace Feed - Initial card page

Fixed Issues

$ #44304
PROPOSAL:

Tests

Enable Expensify card in more features for workspace
Open Expensify card page
Verify UI

Verify that no errors appear in the JS console

Offline tests

Enable Expensify card in more features for workspace
Open Expensify card page
Verify UI

QA Steps

Enable Expensify card in more features for workspace
Open Expensify card page
Verify UI

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-07-03T12:08:06Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx

assets/images/expensifyCard/cardIllustration.svg

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx

allgandalf · 2024-07-03T13:05:10Z

I will review the PR from technical standpoint once the design team gets their 👀 on the styles

assets/images/expensifyCard/cardIllustration.svg

src/pages/workspace/expensifyCard/WorkspaceCardPageEmptyState.tsx

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx

allgandalf

Left some comments, lets get the ball rolling!!

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx

src/pages/workspace/expensifyCard/WorkspaceCardPageEmptyState.tsx

allgandalf · 2024-07-03T17:19:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-07-03.at.11.26.51.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-07-03.at.11.28.00.PM.mov

iOS: Native

Screen.Recording.2024-07-03.at.11.21.53.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-07-03.at.11.25.43.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-07-03.at.11.09.25.PM.mov

MacOS: Desktop

Screen.Recording.2024-07-03.at.11.18.35.PM.mov

allgandalf · 2024-07-04T11:38:43Z

bump @mountiny for review

MariaHCD

Looks good to me, overall. Just one question.

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx

mountiny

Just one comment same as Maria

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx

mountiny

Thank you

OSBotify · 2024-07-04T13:20:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-08T09:58:25Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:54:48Z

🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T11:06:29Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:25:11Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

shawnborton · 2024-07-17T13:01:53Z

Sorry for missing this - but it looks like we don't have the proper 32px of padding in the empty state card on desktop. Here is what it looks like now:

But notice how the padding is different for the workspaces empty state:

dannymcclain · 2024-07-17T13:09:02Z

Great catch! I missed that too.

koko57 · 2024-07-18T14:31:06Z

@shawnborton I can take care of it in my PR for Empty State modal (#44306)

shawnborton · 2024-07-18T14:51:41Z

Amazing, thanks Agata! We have a thread in Slack with some other feedback too in case you can handle that as well, cc @mountiny

koko57 · 2024-07-18T16:04:46Z

@shawnborton I can't access this thread 😅 Can you @ mention me please, if it's a channel that I have an access to? 😃

shawnborton · 2024-07-18T16:38:45Z

Ah no worries, here are the other two comments besides the observation about modal padding:

koko57 · 2024-07-18T17:22:58Z

@shawnborton ok, thanks! I'll be integrating the card flow with the BE, so I'll take care of these issues there 🙂 #44309

shawnborton · 2024-07-18T18:27:11Z

Sounds good!

Pujan92 · 2024-08-16T18:47:46Z

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPageEmptyState.tsx

+        >
+            <View style={[styles.mt3, shouldUseNarrowLayout ? styles.workspaceSectionMobile : styles.workspaceSection]}>
+                <FeatureList
+                    menuItems={expensifyCardFeatures}


For these screen items, the text gets truncated on a smaller screen which caused issue #45901

narefyev91 added 2 commits July 3, 2024 15:01

Workspace Feed - Initial card page

cff92c5

naming

11fb5fd

narefyev91 requested review from a team as code owners July 3, 2024 12:08

melvin-bot bot removed the request for review from a team July 3, 2024 12:08

melvin-bot bot requested a review from allgandalf July 3, 2024 12:08

allgandalf reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceExpensifyCardPage.tsx Show resolved Hide resolved

koko57 mentioned this pull request Jul 3, 2024

[$250] [Workspace Feeds] [External] Create Issue new card logic - existing bank accounts #44305

Closed

shawnborton reviewed Jul 3, 2024

View reviewed changes

assets/images/expensifyCard/cardIllustration.svg Outdated Show resolved Hide resolved

shawnborton reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx Outdated Show resolved Hide resolved

shawnborton reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx Outdated Show resolved Hide resolved

rollback page

72c7515

shawnborton reviewed Jul 3, 2024

View reviewed changes

assets/images/expensifyCard/cardIllustration.svg Outdated Show resolved Hide resolved

update illustration

2107dcb

shawnborton reviewed Jul 3, 2024

View reviewed changes

assets/images/expensifyCard/cardIllustration.svg Outdated Show resolved Hide resolved

narefyev91 added 2 commits July 3, 2024 16:31

update illustration

1c7c872

combine both empty states and existed card page under one wrapper

38b48d0

allgandalf reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageEmptyState.tsx Outdated Show resolved Hide resolved

allgandalf reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx Outdated Show resolved Hide resolved

allgandalf reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx Outdated Show resolved Hide resolved

allgandalf reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx Outdated Show resolved Hide resolved

allgandalf reviewed Jul 3, 2024

View reviewed changes

updates after review

95ab2ba

allgandalf reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx Outdated Show resolved Hide resolved

updates after review

2696c2c

narefyev91 requested a review from allgandalf July 3, 2024 15:24

allgandalf reviewed Jul 3, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageEmptyState.tsx Outdated Show resolved Hide resolved

update notes

bb76ce4

narefyev91 changed the title ~~Workspace Feed - Initial card page~~ [No QA]: Workspace Feed - Initial card page Jul 4, 2024

MariaHCD reviewed Jul 4, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx Outdated Show resolved Hide resolved

mountiny assigned narefyev91 Jul 4, 2024

mountiny previously approved these changes Jul 4, 2024

View reviewed changes

src/pages/workspace/expensifyCard/WorkspaceCardPageFeed.tsx Outdated Show resolved Hide resolved

update file namings

a8dc61f

narefyev91 dismissed mountiny’s stale review via a8dc61f July 4, 2024 12:31

narefyev91 requested a review from mountiny July 4, 2024 13:01

mountiny approved these changes Jul 4, 2024

View reviewed changes

MariaHCD approved these changes Jul 4, 2024

View reviewed changes

MariaHCD merged commit 2784712 into Expensify:main Jul 4, 2024
16 checks passed

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

melvin-bot bot mentioned this pull request Jul 10, 2024

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Workspace Feeds] [External] Create a new Expensify Card workspace page - empty state #44304

Closed

koko57 mentioned this pull request Jul 18, 2024

[HOLD for payment 2024-08-07] [Workspace Feeds] [External] Create UI and logic for Steps 1-6 #44309

Closed

Pujan92 reviewed Aug 16, 2024

View reviewed changes

Pujan92 mentioned this pull request Aug 16, 2024

[HOLD for payment 2024-08-14] [$250] iOS - Expensify Card - Content on Expensify Card intro screen is truncated #45901

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA]: Workspace Feed - Initial card page #44770

[No QA]: Workspace Feed - Initial card page #44770

narefyev91 commented Jul 3, 2024

melvin-bot bot commented Jul 3, 2024

allgandalf commented Jul 3, 2024

allgandalf left a comment

allgandalf commented Jul 3, 2024 •

edited

Loading

allgandalf commented Jul 4, 2024

MariaHCD left a comment

mountiny left a comment

mountiny left a comment

OSBotify commented Jul 4, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

shawnborton commented Jul 17, 2024

dannymcclain commented Jul 17, 2024

koko57 commented Jul 18, 2024

shawnborton commented Jul 18, 2024

koko57 commented Jul 18, 2024

shawnborton commented Jul 18, 2024

koko57 commented Jul 18, 2024

shawnborton commented Jul 18, 2024

Pujan92 Aug 16, 2024

[No QA]: Workspace Feed - Initial card page #44770

[No QA]: Workspace Feed - Initial card page #44770

Conversation

narefyev91 commented Jul 3, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 3, 2024

allgandalf commented Jul 3, 2024

allgandalf left a comment

Choose a reason for hiding this comment

allgandalf commented Jul 3, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf commented Jul 4, 2024

MariaHCD left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 4, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

shawnborton commented Jul 17, 2024

dannymcclain commented Jul 17, 2024

koko57 commented Jul 18, 2024

shawnborton commented Jul 18, 2024

koko57 commented Jul 18, 2024

shawnborton commented Jul 18, 2024

koko57 commented Jul 18, 2024

shawnborton commented Jul 18, 2024

Pujan92 Aug 16, 2024

Choose a reason for hiding this comment

allgandalf commented Jul 3, 2024 •

edited

Loading