-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: List still shows receipt when removed #44762
Conversation
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Will review in the morning. |
@thesahindia friendly bump |
For some reason, my comment didn't get posted.
The second part of the issue is still reproducible. Screen.Recording.2024-07-05.at.10.21.32.PM.mov |
@thesahindia I can't reproduce this bug. Please add more detailed steps. web-resize.mp4 |
In order to repro this you have to make sure that the image is visible in the preview. Then you can go offline and delete it. Screen.Recording.2024-07-11.at.10.13.09.PM.mov |
@thesahindia I updated, please help to check again. |
It's still reproducible @nkdengineer Screen.Recording.2024-07-16.at.11.51.17.PM.mov |
Bump @nkdengineer |
I will update tomorrow morning. |
@thesahindia I checked this bug and it also happens on staging. I think we should handle this bug as a separate issue. |
@nkdengineer, this will need to be fixed here since it was already mentioned in the OP at the last step.
|
Thanks. I will check this again. |
@thesahindia I fixed this bug and tested, please help to check again. |
I can still repro it. |
@thesahindia I can't reproduce it anymore. I just updated to fix another bug when adding the receipt again. Please help to check again. Screen.Recording.2024-07-26.at.13.37.46.mp4 |
@thesahindia Friendly bump. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-07-30.at.1.47.05.PM.movAndroid: mWeb ChromeScreen.Recording.2024-07-30.at.1.41.03.PM.moviOS: NativeScreen.Recording.2024-07-30.at.12.17.25.PM.moviOS: mWeb SafariScreen.Recording.2024-07-30.at.12.22.18.PM.movMacOS: Chrome / SafariScreen.Recording.2024-07-30.at.11.21.21.AM.movMacOS: DesktopScreen.Recording.2024-07-30.at.12.10.35.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
Note: it's unlikely this PR introduced the regression. The regression has been introduced earlier and thus all following PRs will run into the same regression. |
True, I saw that here as well: #45961 (comment), but the percentage increase value is different. 😕 |
yeah the tests are not producing the same results 100% of the time, as its depending on the devices condition, they can lead to different values, however, that still means that a regression was detected. |
🚀 Deployed to staging by https://github.com/techievivek in version: 9.0.15-0 🚀
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.15-9 🚀
|
Details
Fixed Issues
$ #44000
PROPOSAL: #44000 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-mweb-resize.mp4
iOS: Native
ios.mov
iOS: mWeb Safari
ios-mweb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mov