Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WS invite message shows html message briefly #44657

Merged
merged 5 commits into from
Jul 17, 2024
Merged

Fix WS invite message shows html message briefly #44657

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
23f098a
no need to convert to markdown
bernhardoj Jun 29, 2024
93b8f92
remove unused variable
bernhardoj Jun 29, 2024
42efbdd
Merge branch 'main' into fix/42668-ws-invite-msg-shows-html-briefly
bernhardoj Jul 9, 2024
f362989
Merge branch 'main' into fix/42668-ws-invite-msg-shows-html-briefly
bernhardoj Jul 10, 2024
c27688c
remove unused import
bernhardoj Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/pages/workspace/WorkspaceInviteMessagePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import useThemeStyles from '@hooks/useThemeStyles';
import Navigation from '@libs/Navigation/Navigation';
import * as OptionsListUtils from '@libs/OptionsListUtils';
import Parser from '@libs/Parser';

Check failure on line 25 in src/pages/workspace/WorkspaceInviteMessagePage.tsx

View workflow job for this annotation

GitHub Actions / Run ESLint 

'Parser' is defined but never used
import * as PolicyUtils from '@libs/PolicyUtils';
import updateMultilineInputRange from '@libs/updateMultilineInputRange';
import type {SettingsNavigatorParamList} from '@navigation/types';
Expand Down Expand Up @@ -85,15 +85,13 @@
// policy?.description can be an empty string
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
policy?.description ||
Parser.replace(
translate('workspace.common.welcomeNote', {
workspaceName: policy?.name ?? '',
}),
);
translate('workspace.common.welcomeNote', {
workspaceName: policy?.name ?? '',
});

useEffect(() => {
if (!isEmptyObject(invitedEmailsToAccountIDsDraft)) {
setWelcomeNote(Parser.htmlToMarkdown(getDefaultWelcomeNote()));
setWelcomeNote(getDefaultWelcomeNote());
return;
}
Navigation.goBack(ROUTES.WORKSPACE_INVITE.getRoute(route.params.policyID), true);
Expand Down
Loading