Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Unable to proceed to the next tab from Invite new members with Enter key. #44542

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: Unable to proceed to the next tab from Invite new members with Enter key. #44542

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ac6f30
fix: Unable to proceed to the next tab from Invite new members with E…
Krishna2323 Jun 27, 2024
c453158
remove disablePressOnEnter prop.
Krishna2323 Jul 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/pages/InviteReportParticipantsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ function InviteReportParticipantsPage({betas, personalDetails, report, didScreen
onSubmit={inviteUsers}
containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto]}
enabledWhenOffline
disablePressOnEnter
disablePressOnEnter={false}
Copy link
Contributor

@Ollyws Ollyws Jun 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we passing {false} as opposed to just removing the prop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly mistake, sorry. I was looking at FormWrapper component which has true as the default value of disablePressOnEnter. Updated now.

/>
),
[selectedOptions.length, inviteUsers, translate, styles],
Expand Down
2 changes: 1 addition & 1 deletion src/pages/RoomInvitePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ function RoomInvitePage({
onSubmit={inviteUsers}
containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto, styles.mb5, styles.ph5]}
enabledWhenOffline
disablePressOnEnter
disablePressOnEnter={false}
isAlertVisible={false}
/>
</View>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/WorkspaceInvitePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ function WorkspaceInvitePage({route, betas, invitedEmailsToAccountIDsDraft, poli
message={policy?.alertMessage ?? ''}
containerStyles={[styles.flexReset, styles.flexGrow0, styles.flexShrink0, styles.flexBasisAuto]}
enabledWhenOffline
disablePressOnEnter
disablePressOnEnter={false}
/>
),
[inviteUser, policy?.alertMessage, selectedOptions.length, shouldShowAlertPrompt, styles, translate],
Expand Down
Loading