Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old logic as we don't reposition the report preview anymore #44501

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Remove old logic as we don't reposition the report preview anymore #44501

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions src/pages/home/report/ReportActionsView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,37 +404,6 @@ function ReportActionsView({
Timing.end(CONST.TIMING.SWITCH_REPORT, hasCachedActionOnFirstRender ? CONST.TIMING.WARM : CONST.TIMING.COLD);
}, [hasCachedActionOnFirstRender]);

useEffect(() => {
// Temporary solution for handling REPORT_PREVIEW. More details: https://expensify.slack.com/archives/C035J5C9FAP/p1705417778466539?thread_ts=1705035404.136629&cid=C035J5C9FAP
// This code should be removed once REPORT_PREVIEW is no longer repositioned.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer reposition the report preview.

// We need to call openReport for gaps created by moving REPORT_PREVIEW, which causes mismatches in previousReportActionID and reportActionID of adjacent reportActions. The server returns the correct sequence, allowing us to overwrite incorrect data with the correct one.
const shouldOpenReport =
newestReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW &&
!hasCreatedAction &&
isReadyForCommentLinking &&
reportActions.length < 24 &&
reportActions.length >= 1 &&
!isLoadingInitialReportActions &&
!isLoadingOlderReportActions &&
!isLoadingNewerReportActions &&
!ReportUtils.isInvoiceRoom(report);

if (shouldOpenReport) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code sometimes causes an infinite loop of OpenReport

Report.openReport(reportID, reportActionID);
}
}, [
hasCreatedAction,
reportID,
reportActions,
reportActionID,
newestReportAction?.actionName,
isReadyForCommentLinking,
isLoadingOlderReportActions,
isLoadingNewerReportActions,
isLoadingInitialReportActions,
report,
]);

// Check if the first report action in the list is the one we're currently linked to
const isTheFirstReportActionIsLinked = newestReportAction?.reportActionID === reportActionID;

Expand Down
Loading