Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: composer not cleared when sending message #44285

Closed
wants to merge 48 commits into from
Closed

fix: composer not cleared when sending message #44285

wants to merge 48 commits into from

Commits on Jun 24, 2024

  1. add patch

    @hannojg
    hannojg committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    2828112 View commit details
    Browse the repository at this point in the history

  2. wip

    @hannojg
    hannojg committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    97769d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. wip

    @hannojg
    hannojg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    cf0ad39 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' of github.com:Expensify/App into fix/composer-not… 

    …-being-cleared
    @hannojg
    hannojg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    b78967e View commit details
    Browse the repository at this point in the history

  3. wip: fix typing comment

    @hannojg
    hannojg committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a0c387c View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. minor cleanup

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6aa7df5 View commit details
    Browse the repository at this point in the history

  2. wip: restore functionality, but broken: 

    - emoji with colon is broken
- emoji picker is broken
- selecting text when it contains an emoji is broken
    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    add1df6 View commit details
    Browse the repository at this point in the history

  3. fix inserting emojis via colon is broken

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d9f197e View commit details
    Browse the repository at this point in the history

  4. add todo

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    87a286e View commit details
    Browse the repository at this point in the history

  5. removed migrated onTextChange

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    5b89d05 View commit details
    Browse the repository at this point in the history

  6. rename to handleInputChange

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d8fdf33 View commit details
    Browse the repository at this point in the history

  7. update isCommentEmpty from effect

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    da9d7b2 View commit details
    Browse the repository at this point in the history

  8. fix: remove unused setValue props from Suggestions

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d4927cb View commit details
    Browse the repository at this point in the history

  9. fix updateComment in SilentCommentUpdater to update text input directly

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6715b48 View commit details
    Browse the repository at this point in the history

  10. fix use case of replaceSelectionWithText

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6c49d98 View commit details
    Browse the repository at this point in the history

  11. rename to handleComposerUpdate

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    d8f8147 View commit details
    Browse the repository at this point in the history

  12. explain it a bit better

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    97ef3bb View commit details
    Browse the repository at this point in the history

  13. migrated Suggestions to new composer API using handleComposerUpdate

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fd5b913 View commit details
    Browse the repository at this point in the history

  14. cleanup

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    bc3add2 View commit details
    Browse the repository at this point in the history

  15. remove debug code

    @hannojg
    hannojg committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    33bfda5 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. fix bug: type, send, text reappears

    @hannojg
    hannojg committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    3aaef88 View commit details
    Browse the repository at this point in the history

  2. fix draft comment not being cleared when sending

    @hannojg
    hannojg committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    130a41a View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of github.com:Expensify/App into fix/composer-not… 

    …-being-cleared
    @hannojg
    hannojg committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    97d965b View commit details
    Browse the repository at this point in the history

  4. provide web patch

    @hannojg
    hannojg committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    eca8677 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. fix: pressing send not working on web

    @hannojg
    hannojg committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0904ac6 View commit details
    Browse the repository at this point in the history

  2. add comment updater back

    @hannojg
    hannojg committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    1bc30e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. Merge branch 'main' of github.com:Expensify/App into fix/composer-not… 

    …-being-cleared
    @hannojg
    hannojg committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    1d56523 View commit details
    Browse the repository at this point in the history

  2. fix bugs during deleting/replacing on web

    @hannojg
    hannojg committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    a27219d View commit details
    Browse the repository at this point in the history

  3. fix backwards delete

    @hannojg
    hannojg committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    b933802 View commit details
    Browse the repository at this point in the history

  4. web: fix deleting all content

    @hannojg
    hannojg committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    c3a40d6 View commit details
    Browse the repository at this point in the history

  5. fix deleting not working properly

    @hannojg
    hannojg committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    2285a53 View commit details
    Browse the repository at this point in the history

  6. fix web inserting emojis selection was off

    @hannojg
    hannojg committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    f3251b8 View commit details
    Browse the repository at this point in the history

  7. remove unused dep

    @hannojg
    hannojg committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    5b32732 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. web: fix deleting multi-character glyphs

    @hannojg
    hannojg committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    5417cfb View commit details
    Browse the repository at this point in the history

  2. remove debug log

    @hannojg
    hannojg committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a982d2f View commit details
    Browse the repository at this point in the history

  3. remove half-bakes cosmetic changes

    @hannojg
    hannojg committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    b929348 View commit details
    Browse the repository at this point in the history

  4. add comments + prettier format

    @hannojg
    hannojg committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    305882e View commit details
    Browse the repository at this point in the history

  5. ran prettier

    @hannojg
    hannojg committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    a1d1aa9 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2024

  1. Merge branch 'main' of github.com:margelo/expensify-app-fork into fix… 

    …/composer-not-being-cleared
    @hannojg
    hannojg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    d0cb9e7 View commit details
    Browse the repository at this point in the history

  2. fix: deleting text then writing is buggy

    @hannojg
    hannojg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    ea2889c View commit details
    Browse the repository at this point in the history

  3. remove handlePaste change

    @hannojg
    hannojg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    1fc7285 View commit details
    Browse the repository at this point in the history

  4. fix eslint

    @hannojg
    hannojg committed Jul 5, 2024
    Configuration menu
    Copy the full SHA
    c489b4b View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Merge branch 'main' of github.com:Expensify/App into fix/composer-not… 

    …-being-cleared
    @hannojg
    hannojg committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    05c617f View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'main' of github.com:Expensify/App into fix/composer-not… 

    …-being-cleared
    @hannojg
    hannojg committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    4973d78 View commit details
    Browse the repository at this point in the history

  2. remove unused code

    @hannojg
    hannojg committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e8f8e0a View commit details
    Browse the repository at this point in the history

  3. delete now included patch

    @hannojg
    hannojg committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9f5fa16 View commit details
    Browse the repository at this point in the history

  4. fix Suggestion usage in message edit

    @hannojg
    hannojg committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a3fb1a3 View commit details
    Browse the repository at this point in the history

  5. ran prettier

    @hannojg
    hannojg committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    32ac0de View commit details
    Browse the repository at this point in the history