-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Travel] Create Trip Receipt for newDot #44086
Merged
yuwenmemon
merged 11 commits into
Expensify:main
from
software-mansion-labs:trip-corrected/trip-receipt
Jul 3, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ee0f65b
add trip receipt case
cdOut 4e34eb1
fix prettier
cdOut 44a368f
correct type imports and lint
cdOut 85f4941
set correct icon for accommodation
cdOut 95ce1e6
Merge branch 'main' into trip-corrected/trip-receipt
cdOut 2e3821b
Merge branch 'main' into trip-corrected/trip-receipt
cdOut 4d700b7
correct conditional for displaying the EReceipt icon
cdOut c13f952
fix conditional for displaying travel ereceipt
cdOut f502c83
Merge branch 'main' into trip-corrected/trip-receipt
cdOut c40f681
correct logic for displaying the trip receipt
cdOut d627fdd
Merge branch 'main' into trip-corrected/trip-receipt
cdOut File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to remove tripBGColor and calculate the color combos using the same methods in https://github.com/Expensify/App/blob/main/src/components/EReceipt.tsx#L35-L36