fix change the status bar color #44048

tienifr · 2024-06-19T21:50:10Z

Details

Fixed Issues

$ #38594 (comment)
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-20.at.05.01.55.mov

Android: mWeb Chrome

Light:

Screen.Recording.2024-06-28.at.18.47.35.mov

Dark:

Screen.Recording.2024-06-28.at.18.48.25.mov

iOS: Native

Light:

Screen.Recording.2024-06-28.at.18.44.28.mov

Dark:

Screen.Recording.2024-06-28.at.18.45.31.mov

iOS: mWeb Safari

Light:

Screen.Recording.2024-06-28.at.18.46.56.mov

Dark:

Screen.Recording.2024-06-28.at.18.51.25.mov

MacOS: Chrome / Safari

Light:

Screen.Recording.2024-06-28.at.18.54.55.mov

Dark:

Screen.Recording.2024-06-28.at.18.54.32.mov

MacOS: Desktop

Light:

Screen.Recording.2024-06-28.at.19.00.41.mov

Dark:

Screen.Recording.2024-06-28.at.19.00.23.mov

melvin-bot · 2024-06-19T22:03:14Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/styles/theme/themes/light.ts

tienifr · 2024-06-24T10:56:41Z

After the change, it looks like:

Dark:

Light:

tienifr · 2024-06-24T10:57:24Z

@shawnborton @alitoshmatov Can you confirm if it looks good.

shawnborton · 2024-06-24T10:57:43Z

Looks good to me!

dannymcclain · 2024-06-24T13:25:15Z

I assume it's unrelated that the troubleshoot illustration no longer has a background color? Ignore me if that's expected right now!

shawnborton · 2024-06-24T14:29:56Z

Oh gosh how did I miss that. We absolutely want to keep the illustration background color, we just want to change the color of the text in the very top status bar.

shawnborton · 2024-06-24T14:30:29Z

src/styles/theme/themes/light.ts

@@ -136,8 +136,8 @@ const lightTheme = {
            statusBarStyle: CONST.STATUS_BAR_STYLE.DARK_CONTENT,
        },
        [SCREENS.SETTINGS.TROUBLESHOOT]: {
-            backgroundColor: colors.blue700,
-            statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT,
+            backgroundColor: colors.productLight100,


Sorry, we actually do want to keep the existing backgroundColor here, cc @dannymcclain

shawnborton · 2024-06-24T14:30:40Z

src/styles/theme/themes/dark.ts

@@ -136,7 +136,7 @@ const darkTheme = {
            statusBarStyle: CONST.STATUS_BAR_STYLE.LIGHT_CONTENT,
        },
        [SCREENS.SETTINGS.TROUBLESHOOT]: {
-            backgroundColor: colors.blue700,
+            backgroundColor: colors.productDark100,


Let's please revert this back to what it was

alitoshmatov · 2024-06-24T15:44:35Z

Nice catch

alitoshmatov · 2024-06-24T15:46:44Z

@tienifr I think we should apply background color to illustration as we are doing in other places: we should apply backgroundColor here:

App/src/components/LottieAnimations/index.tsx

Lines 70 to 74 in 3e1c0b8

    
           Desk: { 
        
               file: require('@assets/animations/Desk.lottie'), 
        
               w: 200, 
        
               h: 120, 
        
           },

And remove it from here:

App/src/pages/settings/Troubleshoot/TroubleshootPage.tsx

Line 108 in a08557b

    
           illustrationBackgroundColor={theme.PAGE_THEMES[SCREENS.SETTINGS.TROUBLESHOOT].backgroundColor}

Then we can keep productLight100 here:

App/src/styles/theme/themes/light.ts

Line 139 in 6ef72be

backgroundColor: colors.blue700,

Thus we can keep background color in illustration and fix status bar color:

tienifr · 2024-06-26T03:52:14Z

@shawnborton @alitoshmatov I updated PR.
Light:
Dark:

shawnborton · 2024-06-26T06:22:32Z

Looks good to me!

alitoshmatov · 2024-06-27T10:53:54Z

src/styles/theme/themes/light.ts

@@ -137,7 +137,7 @@ const lightTheme = {
        },
        [SCREENS.SETTINGS.TROUBLESHOOT]: {
            backgroundColor: colors.blue700,


@tienifr Shouldn't this also be changed to colors.productLight100

Why do we need to do that? I think we do not use value this value anymore, so we do not need to change it.

This is still causing blue statusbar in mweb safari, isn't it?

Ah, that makes sense. I updated the PR to fix it.

tienifr · 2024-06-28T12:03:26Z

@alitoshmatov I updated PR and added all videos in light and dark mode.

alitoshmatov · 2024-06-28T18:34:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

![Simulator Screenshot - iPhone 15 Plus - 2024-06-28 at 23 34 24](https://github.com/Expensify/App/assets/59907218/a9e2495d-cca3-4b78-a08a-8b963ce4a054)

iOS: mWeb Safari

![Simulator Screenshot - iPhone 15 Plus - 2024-06-24 at 20 47 21](https://github.com/Expensify/App/assets/59907218/a264e83e-7cdc-4fd8-9a55-50971698f739)

MacOS: Chrome / Safari

MacOS: Desktop

alitoshmatov

LGTM!

OSBotify · 2024-06-28T21:00:09Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-07-03T20:00:51Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.0.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-04T22:13:18Z

🚀 Cherry-picked to staging by https://github.com/tgolen in version: 9.0.4-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-07-10T10:57:53Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:19:32Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix change the status bar color

47a543a

tienifr marked this pull request as ready for review June 19, 2024 22:03

tienifr requested review from a team as code owners June 19, 2024 22:03

melvin-bot bot removed the request for review from a team June 19, 2024 22:03

melvin-bot bot requested a review from alitoshmatov June 19, 2024 22:03

tienifr mentioned this pull request Jun 19, 2024

[HOLD for payment 2024-07-17][$500] Move "Troubleshoot" out of About and into Settings as its own nav item #38594

Closed

shawnborton reviewed Jun 20, 2024

View reviewed changes

src/styles/theme/themes/light.ts Outdated Show resolved Hide resolved

tienifr added 2 commits June 24, 2024 17:35

fix merge main

a954539

fix use colors.product100 for backgroundColor

24ee166

shawnborton reviewed Jun 24, 2024

View reviewed changes

tienifr added 2 commits June 26, 2024 10:32

fix merge main

d123594

fix remove illustrationBackgroundColor

3430398

alitoshmatov reviewed Jun 27, 2024

View reviewed changes

shawnborton mentioned this pull request Jun 27, 2024

Troubleshoot page has blue color status bar #44484

Closed

6 tasks

fix status bar issue safari

3b06703

alitoshmatov approved these changes Jun 28, 2024

View reviewed changes

melvin-bot bot requested a review from danieldoglas June 28, 2024 18:34

danieldoglas approved these changes Jun 28, 2024

View reviewed changes

danieldoglas merged commit f9a18c3 into Expensify:main Jun 28, 2024
18 checks passed

ishpaul777 mentioned this pull request Jul 1, 2024

[HOLD for payment 2024-08-07] [$250] mweb - Wrong status bar color at the top in safari #44685

Closed

6 tasks

github-actions bot mentioned this pull request Jul 3, 2024

Deploy Checklist: New Expensify 2024-07-03 #44782

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix change the status bar color #44048

fix change the status bar color #44048

tienifr commented Jun 19, 2024 •

edited

Loading

melvin-bot bot commented Jun 19, 2024

tienifr commented Jun 24, 2024

tienifr commented Jun 24, 2024

shawnborton commented Jun 24, 2024

dannymcclain commented Jun 24, 2024

shawnborton commented Jun 24, 2024

shawnborton Jun 24, 2024

shawnborton Jun 24, 2024

alitoshmatov commented Jun 24, 2024

alitoshmatov commented Jun 24, 2024 •

edited

Loading

tienifr commented Jun 26, 2024

shawnborton commented Jun 26, 2024

alitoshmatov Jun 27, 2024 •

edited

Loading

tienifr Jun 27, 2024 •

edited

Loading

alitoshmatov Jun 27, 2024

tienifr Jun 28, 2024

tienifr commented Jun 28, 2024

alitoshmatov commented Jun 28, 2024

alitoshmatov left a comment

OSBotify commented Jun 28, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

fix change the status bar color #44048

fix change the status bar color #44048

Conversation

tienifr commented Jun 19, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 19, 2024

tienifr commented Jun 24, 2024

tienifr commented Jun 24, 2024

shawnborton commented Jun 24, 2024

dannymcclain commented Jun 24, 2024

shawnborton commented Jun 24, 2024

shawnborton Jun 24, 2024

Choose a reason for hiding this comment

shawnborton Jun 24, 2024

Choose a reason for hiding this comment

alitoshmatov commented Jun 24, 2024

alitoshmatov commented Jun 24, 2024 • edited Loading

tienifr commented Jun 26, 2024

shawnborton commented Jun 26, 2024

alitoshmatov Jun 27, 2024 • edited Loading

Choose a reason for hiding this comment

tienifr Jun 27, 2024 • edited Loading

Choose a reason for hiding this comment

alitoshmatov Jun 27, 2024

Choose a reason for hiding this comment

tienifr Jun 28, 2024

Choose a reason for hiding this comment

tienifr commented Jun 28, 2024

alitoshmatov commented Jun 28, 2024

Reviewer Checklist

Screenshots/Videos

alitoshmatov left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 28, 2024

OSBotify commented Jul 3, 2024

OSBotify commented Jul 4, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

tienifr commented Jun 19, 2024 •

edited

Loading

alitoshmatov commented Jun 24, 2024 •

edited

Loading

alitoshmatov Jun 27, 2024 •

edited

Loading

tienifr Jun 27, 2024 •

edited

Loading