-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Payment card / Subscription] Integrate “Subscription settings” section with backend data #43367
Merged
blimpich
merged 22 commits into
Expensify:main
from
JKobrynski:implementAllToggleActions
Jun 18, 2024
Merged
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
80b5c36
display values from API in subscription settings section
JKobrynski 90d8701
Merge branch 'main' into integrateSubscriptionSettingsWithBackend
JKobrynski 0214f78
Merge branch 'feat/subsription-settings-ui' into integrateSubscriptio…
JKobrynski 2e571e9
add new api commands for subscription settings
JKobrynski a91bd2f
implement auto-increase annual seats setting
JKobrynski 32bc827
Merge branch 'main' into implementAllToggleActions
JKobrynski b6bfeb6
start integrating UpdateSubscriptionAutoRenew API method
JKobrynski 5919906
Merge branch 'main' into implementAllToggleActions
JKobrynski 7718cda
integrate auto renew setting and feedback survey with API
JKobrynski d2e0378
add offline support to subscription settings
JKobrynski 49d387a
apply suggested changes
JKobrynski 51466c3
avoid overwriting values in successData
JKobrynski 816da16
remove disableAutoRenewAdditionalNote param from UpdateSubscriptionAu…
JKobrynski 941875a
Merge branch 'main' into implementAllToggleActions
JKobrynski 7c23447
bring disableAutoRenewAdditionalNote back, add an input for it
JKobrynski 972d967
Merge branch 'main' into implementAllToggleActions
JKobrynski 2839c6a
Merge branch 'main' into implementAllToggleActions
JKobrynski 07dffcc
apply suggested changes
JKobrynski fc13ff4
replace pendingAction with pendingFields
JKobrynski 98217b1
remove comments, add enabledWhenOffline to FeedbackSurvey submit button
JKobrynski d1cbc24
Merge branch 'main' into implementAllToggleActions
JKobrynski 9b805ba
apply suggested changes
JKobrynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
src/libs/API/parameters/UpdateSubscriptionAddNewUsersAutomaticallyParams.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
type UpdateSubscriptionAddNewUsersAutomaticallyParams = { | ||
addNewUsersAutomatically: boolean; | ||
}; | ||
|
||
export default UpdateSubscriptionAddNewUsersAutomaticallyParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import type {FeedbackSurveyOptionID} from '@src/CONST'; | ||
|
||
type UpdateSubscriptionAutoRenewParams = { | ||
autoRenew: boolean; | ||
disableAutoRenewReason?: FeedbackSurveyOptionID; | ||
disableAutoRenewAdditionalNote?: string; | ||
}; | ||
|
||
export default UpdateSubscriptionAutoRenewParams; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's trim
additionalNote
before submitting