[Travel] Bring back refactored `AddressPage` #43348

mateuuszzzzz · 2024-06-10T09:55:46Z

Details

PR brings back refactored AddressPage which had a bug with CountrySelector before.
Initially fix supposed to change useMemo dependencies in AddressPage. Nevertheless, on the latest main AddressPage works again without those changes so I'm leaving it as it was implemented initially.
Bug is still reproducible but it's harder to reproduce it. So the fix was reintroduced.

NOTE: We have another bug on main, related to AddressPage that is not addressed in this PR.

Fixed Issues

$ #42638
$ #41965
PROPOSAL:

Tests

Go to Account Settings > Profile and open Address Form by clicking on Address.
Try to change/set a new country and optionally save form.
Repeat step 2 a few times to make sure it works as expected.
Country should change to the newly selected one. (State, city and zip code probably won't clear, but this is another bug not handled in this PR)

Offline tests

N/A

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Android.native.mov

Android: mWeb Chrome

Android.mWeb.mov

iOS: Native

iOS.native.mov

iOS: mWeb Safari

iOS.mWeb.mov

MacOS: Chrome / Safari

Browser.mov

MacOS: Desktop

Deskop.mov

melvin-bot · 2024-06-10T12:47:48Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

getusha · 2024-06-11T10:53:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-06-27.at.5.16.02.in.the.afternoon.mov

Android: mWeb Chrome

Screen.Recording.2024-06-17.at.2.14.53.in.the.afternoon.mov

iOS: Native

Screen.Recording.2024-06-27.at.5.13.45.in.the.afternoon.mov

iOS: mWeb Safari

Screen.Recording.2024-06-18.at.12.25.13.in.the.afternoon.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-17.at.2.08.07.in.the.afternoon.mov

MacOS: Desktop

Screen.Recording.2024-06-18.at.12.33.13.in.the.afternoon.mov

getusha · 2024-06-12T10:41:43Z

@mateuuszzzzz is there any fix we applied to fix #42638 other than bringing back #41970? i can't seem to find it

blazejkustra · 2024-06-12T11:06:35Z

@getusha It's the same code, context in the PR's description:

getusha · 2024-06-12T11:08:12Z

Thanks @blazejkustra! i missed that 😄

getusha · 2024-06-12T11:29:17Z

BUG: Address line 1 input loses focus after entering a character

Open workspace/personal profile page > Address
Enter any letter

Screen.Recording.2024-06-12.at.2.26.15.in.the.afternoon.mov

blazejkustra · 2024-06-12T11:31:25Z

BUG: Address line 1 input loses focus after entering a character

Open workspace/personal profile page > Address

Enter any letter

Screen.Recording.2024-06-12.at.2.26.15.in.the.afternoon.mov

Is this reproducible on main?

getusha · 2024-06-13T07:57:56Z

@blazejkustra not reproducible on main and staging

Screen.Recording.2024-06-13.at.10.57.22.in.the.morning.mov

mateuuszzzzz · 2024-06-13T09:30:49Z

@blazejkustra not reproducible on main and staging

Screen.Recording.2024-06-13.at.10.57.22.in.the.morning.mov

@getusha I'll take a look at this bug this evening 👌

mateuuszzzzz · 2024-06-13T21:26:14Z

@getusha it should work now

demo.mov

getusha · 2024-06-14T04:02:29Z

I noticed #42638 is still kind of reproducible, i am not able to repro it consistently

Screen.Recording.2024-06-14.at.6.59.27.in.the.morning.mov

mateuuszzzzz · 2024-06-14T09:53:38Z

I noticed #42638 is still kind of reproducible, i am not able to repro it consistently

Screen.Recording.2024-06-14.at.6.59.27.in.the.morning.mov

It's very specific bug. I was trying to reproduce the steps that you showed on the demo but I am not able to do it.

I will introduce previous fix and we can check once again if problem disappeared.

mateuuszzzzz · 2024-06-14T10:06:50Z

@getusha ready

getusha · 2024-06-18T09:51:36Z

BUG: The State/Province input is cleared right after being filled if a location other than the US is selected.

Select any address in US
Change the location to UK address

Screen.Recording.2024-06-18.at.12.47.02.in.the.afternoon.mov

Not sure, if this is reproducible on main/staging will try it & only able to reproduce it on iOS native.

zfurtak · 2024-06-18T14:04:49Z

@getusha @mateuuszzzzz

hello 😊 Recently Mateusz has had time-consuming tasks connected to hybrid app, so I will take over this PR.

zfurtak · 2024-06-20T14:34:33Z

@getusha

BUG: The State/Province input is cleared right after being filled if a location other than the US is selected.

I've managed to reproduce this issue and I'll be looking for a solution.

github-actions · 2024-06-25T15:01:18Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

zfurtak · 2024-06-25T15:01:28Z

I have read the CLA Document and I hereby sign the CLA

zfurtak · 2024-06-25T15:04:26Z

hi @getusha 😊

BUG: The State/Province input is cleared right after being filled if a location other than the US is selected.

The bug was appearing every time when country was changed. I think now it's solved, can you check out if it's working for you?

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx

getusha · 2024-07-03T19:43:23Z

@zfurtak friendly bump

blazejkustra · 2024-07-04T06:24:18Z

@zfurtak is OOO, I merged the newest main and adjusted the code for you @getusha

mountiny

Thank you for getting this done

OSBotify · 2024-07-08T09:57:25Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-08T10:53:45Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.5-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-07-10T10:55:20Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-07-15T20:18:35Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Bring back refactored AddressPage

3b9cc3b

blazejkustra approved these changes Jun 10, 2024

View reviewed changes

Merge branch 'main' into travel/address-page-country-fix

93d7077

mateuuszzzzz marked this pull request as ready for review June 10, 2024 12:47

mateuuszzzzz requested a review from a team as a code owner June 10, 2024 12:47

melvin-bot bot removed the request for review from a team June 10, 2024 12:47

melvin-bot bot requested a review from getusha June 10, 2024 12:47

mountiny assigned mateuuszzzzz Jun 12, 2024

mateuuszzzzz added 2 commits June 13, 2024 22:51

Merge branch 'main' into travel/address-page-country-fix

3afdf17

Remove file that was readded during main merge

8b40d84

Reintroduce old fix

d017bf5

zfurtak added 3 commits June 21, 2024 15:15

Fix deleting state

fb48d1f

Merge branch 'main' into travel/address-page-country-fix

f185433

Merge main

aca57a8

getusha reviewed Jun 27, 2024

View reviewed changes

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx Outdated Show resolved Hide resolved

src/libs/Navigation/AppNavigator/ModalStackNavigators/index.tsx Outdated Show resolved Hide resolved

blazejkustra added 2 commits July 4, 2024 08:21

Merge branch 'main' into travel/address-page-country-fix

7287fe1

Change path to PersonalAddressPage component

aee01b3

getusha approved these changes Jul 4, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny July 4, 2024 09:29

mountiny assigned zfurtak Jul 4, 2024

mountiny approved these changes Jul 4, 2024

View reviewed changes

mountiny merged commit d93e24b into Expensify:main Jul 4, 2024
16 checks passed

github-actions bot mentioned this pull request Jul 8, 2024

Deploy Checklist: New Expensify 2024-07-08 #44947

Closed

86 tasks

lakchote mentioned this pull request Jul 8, 2024

[$250] Address - Country field reverts to the previous selection after selecting a new state #44957

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Travel] Bring back refactored `AddressPage` #43348

[Travel] Bring back refactored `AddressPage` #43348

mateuuszzzzz commented Jun 10, 2024 •

edited by mountiny

Loading

melvin-bot bot commented Jun 10, 2024

getusha commented Jun 11, 2024 •

edited

Loading

getusha commented Jun 12, 2024

blazejkustra commented Jun 12, 2024

getusha commented Jun 12, 2024

getusha commented Jun 12, 2024

blazejkustra commented Jun 12, 2024

getusha commented Jun 13, 2024

mateuuszzzzz commented Jun 13, 2024

mateuuszzzzz commented Jun 13, 2024

getusha commented Jun 14, 2024

mateuuszzzzz commented Jun 14, 2024

mateuuszzzzz commented Jun 14, 2024

getusha commented Jun 18, 2024

zfurtak commented Jun 18, 2024

zfurtak commented Jun 20, 2024

github-actions bot commented Jun 25, 2024 •

edited

Loading

zfurtak commented Jun 25, 2024

zfurtak commented Jun 25, 2024

getusha commented Jul 3, 2024

blazejkustra commented Jul 4, 2024

mountiny left a comment

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

[Travel] Bring back refactored AddressPage #43348

[Travel] Bring back refactored AddressPage #43348

Conversation

mateuuszzzzz commented Jun 10, 2024 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 10, 2024

getusha commented Jun 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

getusha commented Jun 12, 2024

blazejkustra commented Jun 12, 2024

getusha commented Jun 12, 2024

getusha commented Jun 12, 2024

blazejkustra commented Jun 12, 2024

getusha commented Jun 13, 2024

mateuuszzzzz commented Jun 13, 2024

mateuuszzzzz commented Jun 13, 2024

getusha commented Jun 14, 2024

mateuuszzzzz commented Jun 14, 2024

mateuuszzzzz commented Jun 14, 2024

getusha commented Jun 18, 2024

zfurtak commented Jun 18, 2024

zfurtak commented Jun 20, 2024

github-actions bot commented Jun 25, 2024 • edited Loading

zfurtak commented Jun 25, 2024

zfurtak commented Jun 25, 2024

getusha commented Jul 3, 2024

blazejkustra commented Jul 4, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 8, 2024

OSBotify commented Jul 8, 2024

OSBotify commented Jul 10, 2024

OSBotify commented Jul 15, 2024

[Travel] Bring back refactored `AddressPage` #43348

[Travel] Bring back refactored `AddressPage` #43348

mateuuszzzzz commented Jun 10, 2024 •

edited by mountiny

Loading

getusha commented Jun 11, 2024 •

edited

Loading

github-actions bot commented Jun 25, 2024 •

edited

Loading