fix: app goes back to confirmation page from category page while categorizing #43163

tienifr · 2024-06-06T09:28:25Z

Details

App goes back to confirmation page from category page while categorizing expense. This PR fixes that.

Fixed Issues

$ #41783
PROPOSAL: #41783 (comment)

Tests

Log in with an account with no workspace
Create a track expense
Press Categorize it
Press Back
Verify app dismisses the RHP
Press Share it with my accountant
Press Back
Verify app dismisses the RHP

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Log in with an account with no workspace
Create a track expense
Press Categorize it
Press Back
Verify app dismisses the RHP
Press Share it with my accountant
Press Back
Verify app dismisses the RHP

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

video_2024-06-06_16-49-57.mp4

iOS: Native

Screen.Recording.2024-06-06.at.16.47.41-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-06-06.at.16.48.35-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-06.at.16.43.08-compressed.mov

MacOS: Desktop

Screen.Recording.2024-06-06.at.16.44.54-compressed.mov

melvin-bot · 2024-06-06T09:50:42Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane · 2024-06-07T09:13:25Z

@tienifr The app crashes when trying to select a category or while trying to Share it with accountant. I am not sure if it is related to your PR. But it is blocking the test. Can you check it at your end?

Untitled.mov

tienifr · 2024-06-07T09:30:56Z

@sobitneupane It's this one #43073.

We can either:

Hold for that issue; or
Apply a temporary fix to test this PR fix: not found page when select draft policy #43153 (comment).

sobitneupane · 2024-06-10T08:07:03Z

Those changes solve the issue with "Share it with my accountant" but this issue in "Categorize it" is reproducible.

sobitneupane · 2024-06-10T08:29:25Z

@tienifr Still, there are some inconsistencies when user is using draft policy.

When I am using an account with workspace or when I am using "Share it with my accountant" (with or without workspace), if I open Category, Select one and go back, I am not redirected to the category page which is not the case with "Categorize it" function using an account with draft policy only.

Screen.Recording.2024-06-10.at.14.09.28.mov

srikarparsi · 2024-06-18T02:15:40Z

Hey @tienifr how is this one going?

tienifr · 2024-06-26T10:26:58Z

Working on this now.

sobitneupane · 2024-07-02T07:33:11Z

@tienifr Any update?

tienifr · 2024-07-09T11:41:40Z

Taking a look now.

tienifr · 2024-07-11T05:42:42Z

@sobitneupane

The crash issue here is no longer reproducible.
For this issue, the minimum reproducible steps are:

Press Categorize it (Category page)
Select a category (Confirmation page)
Press Category menu (Category page)
Press back (Confirmation page)
Press back
BUG: Now it's participant selector page (EXPECTED: Category selector page)

This only happens when we press the Category menu item in confirmation page, not with other menus (Description, Date, Merchant...) because the second category page in step 3 will replace the first category page in step 1 in the navigation stack history. Later when we go back in step 5, there's no route in the stack and thus fallbackRoute is enforced to use which is the participant selector page.

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 190 in 07ed4b9

    
           Navigation.goBack(ROUTES.MONEY_REQUEST_STEP_PARTICIPANTS.getRoute(iouType, transactionID, reportID, undefined, action));

I think this has a different root cause relating to navigation state and should be fixed via a separate issue. Wdyt?

sobitneupane · 2024-07-19T07:11:32Z

This only happens when we press the Category menu item in confirmation page, not with other menus (Description, Date, Merchant...) because the second category page in step 3 will replace the first category page in step 1 in the navigation stack history. Later when we go back in step 5, there's no route in the stack and thus fallbackRoute is enforced to use which is the participant selector page.

@tienifr This issue is reproducible only if there are no policies. Why doesn't the issue occur if there is an existing policy?

I think this has a different root cause relating to navigation state and should be fixed via a separate issue. Wdyt?

The issue is very much similar to the original issue. So, I think it makes sense to handle it here.

tienifr · 2024-07-30T11:04:00Z

@sobitneupane The above issue was resolved in #45560. Now we only have 2 bugs mentioned in PR description remained.

sobitneupane

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-01.at.16.44.56.mov

Screen.Recording.2024-08-01.at.16.46.27.mov

iOS: Native

Screen.Recording.2024-08-01.at.16.40.13.mov

Screen.Recording.2024-08-01.at.16.41.28.mov

iOS: mWeb Safari

Screen.Recording.2024-08-01.at.16.42.11.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-01.at.16.27.35.mov

MacOS: Desktop

Screen.Recording.2024-08-01.at.16.33.12.mov

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2024-08-02T02:27:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-06T04:27:26Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.0.17-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

lanitochka17 · 2024-08-06T12:52:20Z

This PR is failing because of issue #46879

The issue is reproducible in: mWeb/Chrome

Bug6563076_1722927494306.video_2024-08-06_09-55-47.mp4

OSBotify · 2024-08-07T22:03:16Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-08T04:52:53Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-08T20:04:17Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.0.17-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

tienifr added 2 commits June 6, 2024 16:04

fix: app goes back to confirmation page from category page

5023b92

fix in category page

57422f8

tienifr marked this pull request as ready for review June 6, 2024 09:50

tienifr requested a review from a team as a code owner June 6, 2024 09:50

melvin-bot bot requested review from sobitneupane and removed request for a team June 6, 2024 09:50

Merge branch 'main' of https://github.com/tienifr/App into fix/41783

693c045

tienifr added 2 commits July 10, 2024 15:53

Merge branch 'main' of https://github.com/tienifr/App into fix/41783

804a739

Merge branch 'main' of https://github.com/tienifr/App into fix/41783

3ae716e

Merge branch 'main' of https://github.com/tienifr/App into fix/41783

615a831

sobitneupane reviewed Aug 1, 2024

View reviewed changes

sobitneupane approved these changes Aug 1, 2024

View reviewed changes

melvin-bot bot requested a review from srikarparsi August 1, 2024 11:13

srikarparsi approved these changes Aug 2, 2024

View reviewed changes

srikarparsi merged commit b783854 into Expensify:main Aug 2, 2024
15 of 16 checks passed

github-actions bot mentioned this pull request Aug 6, 2024

Deploy Checklist: New Expensify 2024-08-06 #46849

Closed

83 tasks

lanitochka17 mentioned this pull request Aug 6, 2024

[$250] [CRITICAL] [CVP] Track Expense - App crashes when tracking an expense #46879

Closed

6 tasks

melvin-bot bot mentioned this pull request Aug 7, 2024

[HOLD for payment 2024-08-14] [$250] Track expense - App returns to confirmation page when tapping back button on category page #41783

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: app goes back to confirmation page from category page while categorizing #43163

fix: app goes back to confirmation page from category page while categorizing #43163

tienifr commented Jun 6, 2024 •

edited

Loading

melvin-bot bot commented Jun 6, 2024

sobitneupane commented Jun 7, 2024 •

edited

Loading

tienifr commented Jun 7, 2024

sobitneupane commented Jun 10, 2024

sobitneupane commented Jun 10, 2024

srikarparsi commented Jun 18, 2024

tienifr commented Jun 26, 2024

sobitneupane commented Jul 2, 2024

tienifr commented Jul 9, 2024

tienifr commented Jul 11, 2024

sobitneupane commented Jul 19, 2024

tienifr commented Jul 30, 2024

sobitneupane left a comment

sobitneupane left a comment

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

lanitochka17 commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 8, 2024

OSBotify commented Aug 8, 2024

fix: app goes back to confirmation page from category page while categorizing #43163

fix: app goes back to confirmation page from category page while categorizing #43163

Conversation

tienifr commented Jun 6, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 6, 2024

sobitneupane commented Jun 7, 2024 • edited Loading

tienifr commented Jun 7, 2024

sobitneupane commented Jun 10, 2024

sobitneupane commented Jun 10, 2024

srikarparsi commented Jun 18, 2024

tienifr commented Jun 26, 2024

sobitneupane commented Jul 2, 2024

tienifr commented Jul 9, 2024

tienifr commented Jul 11, 2024

sobitneupane commented Jul 19, 2024

tienifr commented Jul 30, 2024

sobitneupane left a comment

Choose a reason for hiding this comment

Screenshots/Videos

sobitneupane left a comment

Choose a reason for hiding this comment

Reviewer Checklist

OSBotify commented Aug 2, 2024

OSBotify commented Aug 6, 2024

lanitochka17 commented Aug 6, 2024

OSBotify commented Aug 7, 2024

OSBotify commented Aug 8, 2024

OSBotify commented Aug 8, 2024

tienifr commented Jun 6, 2024 •

edited

Loading

sobitneupane commented Jun 7, 2024 •

edited

Loading