-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pay as Business option for invoices sent to an individual who is admin of their primary workspace #43036
Merged
cristipaval
merged 20 commits into
Expensify:main
from
VickyStash:feature/40438-pay-as-business
Jul 3, 2024
Merged
Changes from 19 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
9229520
Support invoice paying as business
VickyStash 7f6e6eb
UI updates to support B2B invoices rooms
VickyStash 5064821
Minor improvements
VickyStash 74e0b25
Lint fix
VickyStash e940e2d
Merge branch 'main' into feature/40438-pay-as-business
VickyStash 1ea212e
Minor UI fixes
VickyStash 97bf8d6
Improve the check
VickyStash 9ca57be
Merge branch 'main' into feature/40438-pay-as-business
VickyStash ef5f19b
Fix ts error
VickyStash 37f1863
Merge branch 'main' into feature/40438-pay-as-business
VickyStash db1aa8a
Minor fix
VickyStash aa9bd53
Hide Pay as individual option in B2B room
VickyStash 4393a76
Merge branch 'main' into feature/40438-pay-as-business
VickyStash b6c45bd
Merge branch 'main' into feature/40438-pay-as-business
VickyStash d295bbf
Align secondary avatar display with the main branch
VickyStash f3fe9a8
Move the b2c invoice to an existing b2b room
VickyStash 7301646
Fix expense created in a wrong chat
VickyStash 968373e
Minor code improvement
VickyStash f780f3d
Update the check
VickyStash 4a17fdc
Merge remote-tracking branch 'origin/main' into feature/40438-pay-as-…
cristipaval File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -678,6 +678,7 @@ export default { | |
settledExpensify: 'Pagado', | ||
settledElsewhere: 'Pagado de otra forma', | ||
individual: 'Individual', | ||
business: 'Empresa', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've asked about translation confirmation in the slack |
||
settleExpensify: ({formattedAmount}: SettleExpensifyCardParams) => (formattedAmount ? `Pagar ${formattedAmount} con Expensify` : `Pagar con Expensify`), | ||
settlePersonal: ({formattedAmount}: SettleExpensifyCardParams) => (formattedAmount ? `Pago ${formattedAmount} como individuo` : `Pago individual`), | ||
settlePayment: ({formattedAmount}: SettleExpensifyCardParams) => `Pagar ${formattedAmount}`, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will work right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really, it gives TS error, cause the second params are incompatible