Get rid of missing translation #42970

nkdengineer · 2024-06-02T17:08:23Z

Details

Fixed Issues

$ #42539
PROPOSAL: #42539 (comment)

Tests

Login to Expensify
Try editing the form with errors
Test all features of Expensify
Verify that: There is no missing translation

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login to app
Try editing the form with errors
Test other features of Expensify
Verify that: There is no missing translation

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-resize.mp4

Android: mWeb Chrome

android-mweb-resize.mp4

iOS: Native

ios-resize.mp4

iOS: mWeb Safari

ios-mweb-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

desktop-resize.mp4

melvin-bot · 2024-06-02T17:08:27Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-06-03T17:40:57Z

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/MagicCodeInput.tsx

src/components/AddressForm.tsx

src/pages/workspace/tags/WorkspaceEditTagsPage.tsx

src/pages/workspace/WorkspaceNewRoomPage.tsx

src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

src/components/MoneyRequestConfirmationList.tsx

src/components/PDFView/PDFPasswordForm.tsx

fedirjh · 2024-06-04T15:40:59Z

There is conflict

nkdengineer · 2024-06-04T17:49:03Z

@fedirjh thanks your review, i'm working on this issue now.

nkdengineer · 2024-06-04T18:38:58Z

@fedirjh I have finished updating according to your suggestions.
Please check again 🙏

fedirjh

Let's remove function translateIfPhraseKey declaration as it's not used anymore.

These files needs to be updated :

src/pages/settings/Profile/Contacts/ValidateCodeForm/BaseValidateCodeForm.tsx
src/pages/settings/Wallet/ExpensifyCardPage.tsx

src/components/AddressForm.tsx

src/pages/workspace/WorkspaceNewRoomPage.tsx

src/pages/ReimbursementAccount/BusinessInfo/substeps/AddressBusiness.tsx

src/components/MoneyRequestConfirmationList.tsx

src/libs/ErrorUtils.ts

src/components/MoneyRequestConfirmationList.tsx

fedirjh · 2024-06-05T17:18:23Z

@nkdengineer There is a typescript check error and there is a failing unit test.

nkdengineer · 2024-06-13T15:58:29Z

Fixed now.

fedirjh · 2024-06-13T17:19:39Z

@nkdengineer conflicts again

francoisl · 2024-06-13T18:04:20Z

For the second QA step:

Login to app

Try editing the form with errors

Can we edit it to be a bit more specific? Specifically what form is it referring to (looks like it's the name step of the onboarding flow), and how do you force an error (e.g. use a reserved name like Expensify or Concierge)?

fedirjh · 2024-06-13T18:43:19Z

Can we edit it to be a bit more specific?

@francoisl Actually, we edited all forms in the codebase, not just forms but all components where we have been passing the translation keys instead of translated values. we just need to verify that the errors are displayed correctly.

francoisl · 2024-06-13T18:06:11Z

src/components/AmountPicker/types.ts

@@ -1,6 +1,5 @@
 import type {AmountFormProps} from '@components/AmountForm';
 import type {MenuItemBaseProps} from '@components/MenuItem';
-import type {MaybePhraseKey} from '@libs/Localize';


Looks like this type is not used anywhere anymore, we might as well remove it?

francoisl · 2024-06-13T19:04:00Z

Actually, we edited all forms in the codebase, not just forms but all components where we have been passing the translation keys instead of translated values

Yeah makes sense, maybe we can say something like "interact with forms in the app and fill them out incorrectly (e.g. missing values for required fields, values too long, etc.)".

Although now that I think about it, most forms already have regression tests that would catch any issues so maybe we're fine.

nkdengineer · 2024-06-14T10:30:47Z

@francoisl @fedirjh i updated, please check again

francoisl · 2024-06-14T16:42:02Z

Aw there's a conflict in src/pages/settings/Subscription/SubscriptionSize/utils.ts, can you fix please?

nkdengineer · 2024-06-17T03:02:53Z

@francoisl fixed, please check again

OSBotify · 2024-06-17T17:31:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-17T23:47:32Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-18T00:04:58Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-18T16:01:43Z

🚀 Deployed to staging by https://github.com/francoisl in version: 1.4.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-06-21T16:48:33Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.85-7 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

alitoshmatov · 2024-08-10T06:02:32Z

src/pages/signin/LoginForm/BaseLoginForm.tsx

@@ -60,7 +59,7 @@ function BaseLoginForm({account, credentials, closeAccount, blurOnSubmit = false
    const {translate} = useLocalize();
    const input = useRef<BaseTextInputRef | null>(null);
    const [login, setLogin] = useState(() => Str.removeSMSDomain(credentials?.login ?? ''));
-    const [formError, setFormError] = useState<TranslationPaths | undefined>();


We had related issue when form error was shown and user changed language in login page the error would still be in old language. We basically applied old logic to this page reverting its changes. Unfortunately I didn't see this PR before our implementation, I would've discussed this more thoroughly. But so far our changes works as expected

Related issue: #44849

get rid of missing translation FormHelpMessage

7dae918

nkdengineer added 10 commits June 3, 2024 13:02

Fix translate error for DotIndicatorMessage

7010adf

fix test

7d39bf5

fix error utils test

6177f8b

complete fix tes

0451213

fix translation error

7b70d73

remove the use of MaybePhraseKey type

55a9077

merge main

4320a8c

fix test

20e829f

fix lint

a7fb548

fix test

6d3a233

nkdengineer force-pushed the fix/42539 branch from 27a7a5e to 6d3a233 Compare June 3, 2024 09:22

fix prettier

0c4cabc

fedirjh mentioned this pull request Jun 3, 2024

[HOLD for payment 2024-06-28] [$250] Get rid of MISSING TRANSLATION errors once and for all #42539

Closed

add missing form helper error translation

f29281c

nkdengineer marked this pull request as ready for review June 3, 2024 17:40

nkdengineer requested a review from a team as a code owner June 3, 2024 17:40

melvin-bot bot requested review from fedirjh and removed request for a team June 3, 2024 17:40

fedirjh suggested changes Jun 4, 2024

View reviewed changes

nkdengineer added 3 commits June 5, 2024 00:59

merge main

74f3f1d

merge main

5fb3199

clean code

ba60fea

fedirjh suggested changes Jun 5, 2024

View reviewed changes

fix lint

b6b85d2

fedirjh approved these changes Jun 13, 2024

View reviewed changes

melvin-bot bot requested a review from francoisl June 13, 2024 17:18

merge main

61255a3

francoisl reviewed Jun 13, 2024

View reviewed changes

remove type MaybePhraseKey

7603cb4

francoisl previously approved these changes Jun 14, 2024

View reviewed changes

merge main

899dc4e

nkdengineer dismissed francoisl’s stale review via 899dc4e June 17, 2024 02:48

Merge branch 'main' into fix/42539

1ef917b

francoisl approved these changes Jun 17, 2024

View reviewed changes

francoisl merged commit 67ec334 into Expensify:main Jun 17, 2024
15 checks passed

github-actions bot mentioned this pull request Jun 17, 2024

Deploy Checklist: New Expensify 2024-06-17 #43871

Closed

44 tasks

fedirjh mentioned this pull request Jun 18, 2024

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-28] mWeb - Room description - When saving specific room description different error shown in stg&pro #43925

Closed

6 tasks

alitoshmatov reviewed Aug 10, 2024

View reviewed changes

alitoshmatov mentioned this pull request Aug 10, 2024

[HOLD for payment 2024-08-07] [$250] Login – Please enter an email or phone number is not is not displayed in Spanish #44849

Closed

6 tasks

bernhardoj mentioned this pull request Oct 5, 2024

[HOLD for payment 2024-10-25] Contact method - unlinkLoginForm.succesfullyUnlinkedLogin after unlinking secondary login #50256

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Get rid of missing translation #42970

Get rid of missing translation #42970

nkdengineer commented Jun 2, 2024 •

edited

Loading

melvin-bot bot commented Jun 2, 2024

melvin-bot bot commented Jun 3, 2024

fedirjh commented Jun 4, 2024

nkdengineer commented Jun 4, 2024

nkdengineer commented Jun 4, 2024

fedirjh left a comment

fedirjh commented Jun 5, 2024

nkdengineer commented Jun 13, 2024

fedirjh commented Jun 13, 2024

francoisl commented Jun 13, 2024

fedirjh commented Jun 13, 2024

francoisl Jun 13, 2024

francoisl commented Jun 13, 2024

nkdengineer commented Jun 14, 2024

francoisl commented Jun 14, 2024

nkdengineer commented Jun 17, 2024

OSBotify commented Jun 17, 2024

OSBotify commented Jun 17, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 21, 2024

alitoshmatov Aug 10, 2024

Get rid of missing translation #42970

Get rid of missing translation #42970

Conversation

nkdengineer commented Jun 2, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 2, 2024

melvin-bot bot commented Jun 3, 2024

fedirjh commented Jun 4, 2024

nkdengineer commented Jun 4, 2024

nkdengineer commented Jun 4, 2024

fedirjh left a comment

Choose a reason for hiding this comment

fedirjh commented Jun 5, 2024

nkdengineer commented Jun 13, 2024

fedirjh commented Jun 13, 2024

francoisl commented Jun 13, 2024

fedirjh commented Jun 13, 2024

francoisl Jun 13, 2024

Choose a reason for hiding this comment

francoisl commented Jun 13, 2024

nkdengineer commented Jun 14, 2024

francoisl commented Jun 14, 2024

nkdengineer commented Jun 17, 2024

OSBotify commented Jun 17, 2024

OSBotify commented Jun 17, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 18, 2024

OSBotify commented Jun 21, 2024

alitoshmatov Aug 10, 2024

Choose a reason for hiding this comment

nkdengineer commented Jun 2, 2024 •

edited

Loading