Fix: intercept mouse selection when out of input field #42823

dragnoir · 2024-05-30T09:23:18Z

Details

This PR fixes the issue when the cursor is dragged outside input and released, the user profile opens

Fixed Issues

$ #41803
PROPOSAL: #41803 (comment)

Tests

Go to staging.new.expensify.com
Go to group chat
Go to + > Split expense
Enter amount > Next
Drag the split amount in the input field from left to outside the input on the right (the cursor touches user row)
Release the cursor
Verify that the user profile is not opened

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to staging.new.expensify.com
Go to group chat
Go to + > Split expense
Enter amount > Next
Drag the split amount in the input field from left to outside the input on the right (the cursor touches user row)
Release the cursor
Verify that the user profile is not opened

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

NA

Android: mWeb Chrome

NA

iOS: Native

NA

iOS: mWeb Safari

NA

MacOS: Chrome / Safari

20240530_111658.mp4

MacOS: Desktop

20240530_111823.mp4

melvin-bot · 2024-05-30T10:18:59Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2024-05-30T10:19:35Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

c3024 · 2024-05-30T11:48:58Z

@dragnoir

You did not even remove console.log statements?

If this is still in draft please change it to draft.

dragnoir · 2024-05-30T11:59:21Z

@c3024 fixed

c3024

NAB: Few minor changes

src/hooks/useMouseContext.tsx

c3024 · 2024-05-30T12:07:15Z

src/hooks/useMouseContext.tsx

+    return <MouseContext.Provider value={value}>{children}</MouseContext.Provider>;
+}
+
+// Custom hook to use the mouse context


Suggested change

// Custom hook to use the mouse context

c3024 · 2024-05-30T12:37:47Z

src/components/SelectionList/BaseListItem.tsx

@@ -36,12 +37,19 @@ function BaseListItem<TItem extends ListItem>({
    const theme = useTheme();
    const styles = useThemeStyles();
    const {hovered, bind} = useHover();
+    const {isMouseDownOnInput} = useMouseContext();


Suggested change

const {isMouseDownOnInput} = useMouseContext();

const {isMouseDownOnInput, setMouseUp} = useMouseContext();

c3024 · 2024-05-30T12:38:15Z

src/components/SelectionList/BaseListItem.tsx


    const pressableRef = useRef<View>(null);

    // Sync focus on an item
    useSyncFocus(pressableRef, Boolean(isFocused), shouldSyncFocus);

+    const {setMouseUp} = useMouseContext();


Suggested change

const {setMouseUp} = useMouseContext();

c3024 · 2024-05-30T12:39:54Z

Please merge main. A test is failing. Tests are working fine on main.

c3024 · 2024-05-30T15:42:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

interceptMouseAndroid.mp4

Android: mWeb Chrome

interceptMouseAndroidmWeb.mp4

iOS: Native

interceptMouseiOS.mp4

iOS: mWeb Safari

interceptMouseiOSmWeb.mp4

MacOS: Chrome / Safari

interceptMouseChrome.mp4

MacOS: Desktop

interceptMouseDesktop.mp4

c3024

LGTM!

OSBotify · 2024-06-03T20:54:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-06T12:36:03Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dragnoir added 2 commits May 20, 2024 20:29

progress..

40aaf0f

fix mouse leave

3f7fb92

dragnoir changed the title ~~41803 fix~~ Fix: intercept mouse selection when out of input field May 30, 2024

Rachid L added 3 commits May 30, 2024 10:32

Merge branch 'main' into 41803-fix

d1409fd

lint

bb768a4

fix ts

fd90ced

dragnoir marked this pull request as ready for review May 30, 2024 10:19

dragnoir requested a review from a team as a code owner May 30, 2024 10:19

melvin-bot bot requested review from c3024 and removed request for a team May 30, 2024 10:19

remove console.log

c0701b3

c3024 reviewed May 30, 2024

View reviewed changes

dragnoir added 4 commits May 30, 2024 18:03

removce comments

f715455

remove comment

af76e42

fix code

01f3ae8

Merge branch 'Expensify:main' into 41803-fix

cdea07c

dragnoir requested a review from c3024 May 30, 2024 18:25

c3024 approved these changes May 31, 2024

View reviewed changes

melvin-bot bot requested a review from youssef-lr May 31, 2024 06:48

Merge branch 'Expensify:main' into 41803-fix

f66765b

youssef-lr approved these changes Jun 3, 2024

View reviewed changes

youssef-lr merged commit 305af4b into Expensify:main Jun 3, 2024
15 checks passed

github-actions bot mentioned this pull request Jun 4, 2024

Deploy Checklist: New Expensify 2024-06-04 #43037

Closed

melvin-bot bot mentioned this pull request Jun 6, 2024

[HOLD for payment 2024-06-13] [$250] [Uneven Splits] [Polish] - User profile opens every time the cursor is dragged outside input and released #41803

Closed

6 tasks

ishpaul777 mentioned this pull request Jun 10, 2024

[HOLD for payment 2024-06-20] [$125] [Search v1] Receipt thumbnail background doesn't change back to correct color after hover #43412

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: intercept mouse selection when out of input field #42823

Fix: intercept mouse selection when out of input field #42823

dragnoir commented May 30, 2024 •

edited

Loading

melvin-bot bot commented May 30, 2024

melvin-bot bot commented May 30, 2024

c3024 commented May 30, 2024

dragnoir commented May 30, 2024

c3024 left a comment

c3024 May 30, 2024

c3024 May 30, 2024

c3024 May 30, 2024

c3024 commented May 30, 2024

c3024 commented May 30, 2024 •

edited

Loading

c3024 left a comment

OSBotify commented Jun 3, 2024

OSBotify commented Jun 6, 2024

	const {isMouseDownOnInput} = useMouseContext();
	const {isMouseDownOnInput, setMouseUp} = useMouseContext();

Fix: intercept mouse selection when out of input field #42823

Fix: intercept mouse selection when out of input field #42823

Conversation

dragnoir commented May 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 30, 2024

melvin-bot bot commented May 30, 2024

c3024 commented May 30, 2024

dragnoir commented May 30, 2024

c3024 left a comment

Choose a reason for hiding this comment

c3024 May 30, 2024

Choose a reason for hiding this comment

c3024 May 30, 2024

Choose a reason for hiding this comment

c3024 May 30, 2024

Choose a reason for hiding this comment

c3024 commented May 30, 2024

c3024 commented May 30, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

c3024 left a comment

Choose a reason for hiding this comment

OSBotify commented Jun 3, 2024

OSBotify commented Jun 6, 2024

dragnoir commented May 30, 2024 •

edited

Loading

c3024 commented May 30, 2024 •

edited

Loading