Fix NVP_HOLD_USE_EXPLAINED useOnyx wrong config #42819

bernhardoj · 2024-05-30T08:12:06Z

Details

There is a wrong config being set for NVP_HOLD_USE_EXPLAINED in MoneyRequestHeader. This PR fix it.

Fixed Issues

$ #42334 (comment)
PROPOSAL:

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite:

have a money request and hold it
Confirm the hold education modal

Steps:

Go to the on-hold transaction
Verify there is no hold education modal shown because you already confirm it before
Refresh the page (only on web)
Verify there is no hold education modal shown
Repeat 3-4 a few times

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-30.at.17.27.12.mov

Android: mWeb Chrome

Screen.Recording.2024-05-30.at.17.21.47.mov

iOS: Native

Screen.Recording.2024-05-30.at.17.26.52.mov

iOS: mWeb Safari

Screen.Recording.2024-05-30.at.17.23.59.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-30.at.17.11.48.mov

MacOS: Desktop

Screen.Recording.2024-05-30.at.17.19.42.mov

melvin-bot · 2024-05-30T08:12:35Z

@techievivek Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2024-05-30T08:13:05Z

src/components/MoneyRequestHeader.tsx

@@ -52,7 +52,7 @@ function MoneyRequestHeader({report, parentReportAction, policy, shouldUseNarrow
    const [transaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION}${(parentReportAction as ReportAction & OriginalMessageIOU)?.originalMessage?.IOUTransactionID ?? 0}`);
    const [transactionViolations] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS);
    const [session] = useOnyx(ONYXKEYS.SESSION);
-    const [shownHoldUseExplanation] = useOnyx(ONYXKEYS.NVP_HOLD_USE_EXPLAINED, {initWithStoredValues: false});
+    const [shownHoldUseExplanation] = useOnyx(ONYXKEYS.NVP_HOLD_USE_EXPLAINED, {initialValue: false});


initWithStoredValues is "true by default", so we don't need to set it explicitly.

Btw, @DylanDylann do you know what issue this causes so I can test it?

@bernhardoj The initial value should be true

@bernhardoj What is difference between initWithStoredValues and initialValue

If initWithStoredValues is false, it won't use the stored values, so it will return undefined, but it will still receive the update.

initialValue will be used if the data is not ready yet. So in this case, it will be false first and then true.

bernhardoj · 2024-05-30T08:13:45Z

@techievivek fyi, this is a follow up from #42334

DylanDylann · 2024-05-30T08:45:44Z

@bernhardoj The current bug: When you first load the page, the hold education modal will appear for a bit and then close automatically. Because shownHoldUseExplanation is initially undefined

…hold education modal

bernhardoj · 2024-05-30T09:08:24Z

src/components/MoneyRequestHeader.tsx

+        if (isLoadingHoldUseExplained) {
+            return;
+        }
+        setShouldShowHoldMenu(isOnHold && !holdUseExplained);


I have found the code that causes the issue and pushed a new fix. We can't set the prop default value as the onyx initial value because it will be used when the data is still loading by the onyx. Instead, I do an early return when the data is still loading.

bernhardoj · 2024-05-30T09:32:46Z

Thanks, I can repro it and have added the test step and recordings.

bernhardoj · 2024-06-01T03:53:20Z

@DylanDylann sorry, just to confirm, you are going to review this one, right?

techievivek · 2024-06-06T09:04:27Z

Gentle bump @DylanDylann to review the PR.

DylanDylann · 2024-06-06T09:28:40Z

Whoops, I missed this PR. Sorry

DylanDylann · 2024-06-07T11:21:16Z

@bernhardoj Could you explain why we should remove initial value of shownHoldUseExplanation? We need to ensure that it doesn't break any other flows

bernhardoj · 2024-06-07T12:54:56Z

I mentioned it here why.

DylanDylann · 2024-06-10T10:07:02Z

Oh, thanks. LGTM 💯

DylanDylann · 2024-06-10T10:14:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-06-10.at.17.21.05.mov

iOS: Native

iOS: mWeb Safari

Screen.Recording.2024-06-10.at.17.19.38.mov

MacOS: Chrome / Safari

Screen.Recording.2024-06-10.at.17.18.38.mov

MacOS: Desktop

Screen.Recording.2024-06-10.at.17.25.56.mov

DylanDylann · 2024-06-10T10:24:37Z

@bernhardoj The popover still displays for the first time going to the transaction report after login again

Screen.Recording.2024-06-10.at.17.23.24.mov

bernhardoj · 2024-06-10T10:26:02Z

NVP_HOLD_USE_EXPLAIND is saved locally only, so if you log out or switch devices, the value is false. You can check the value in the storage.

DylanDylann · 2024-06-10T10:26:46Z

Updated: Wrong video

@bernhardoj I see the status is loaded

Screen.Recording.2024-06-10.at.17.25.56.mov

bernhardoj · 2024-06-10T10:30:01Z

The NVP_HOLD_USE_EXPLAIND onyx value, not the loading state. It's either false or empty.

DylanDylann · 2024-06-10T10:32:55Z

@bernhardoj I don't understand your mean

bernhardoj · 2024-06-10T10:36:09Z

If you relogin, NVP_HOLD_USE_EXPLAIND doesn't exist on onyx, so the hold modal shows again.

App/src/components/MoneyRequestHeader.tsx

Lines 174 to 176 in 66cd707

    
           useEffect(() => { 
        
               setShouldShowHoldMenu(isOnHold && !shownHoldUseExplanation); 
        
           }, [isOnHold, shownHoldUseExplanation]);

so isOnHold && !shownHoldUseExplanation becomes true.

DylanDylann · 2024-06-10T10:36:22Z

The NVP_HOLD_USE_EXPLAIND onyx value, not the loading state. It's either false or empty.

holdUseExplained doesn't exist on Onyx

Ok, I see. I get confused about above comment

melvin-bot · 2024-06-10T10:38:13Z

🎯 @DylanDylann, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #43350.

DylanDylann · 2024-06-12T07:42:38Z

@techievivek All yours

OSBotify · 2024-06-13T12:24:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-14T23:03:10Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix wrong config

5fd1a14

bernhardoj requested a review from a team as a code owner May 30, 2024 08:12

bernhardoj mentioned this pull request May 30, 2024

Fix chat header appears after delay when opening expense/transaction report #42334

Merged

50 tasks

melvin-bot bot requested review from techievivek and removed request for a team May 30, 2024 08:12

bernhardoj commented May 30, 2024

View reviewed changes

bernhardoj added 2 commits May 30, 2024 17:06

wait until hold use explained onyx data is loaded before showing the …

4130de7

…hold education modal

prettier

d888b3a

bernhardoj commented May 30, 2024

View reviewed changes

techievivek assigned bernhardoj Jun 3, 2024

DylanDylann approved these changes Jun 10, 2024

View reviewed changes

melvin-bot bot mentioned this pull request Jun 10, 2024

Payment issue for E/App PR#42819 #43350

Closed

techievivek approved these changes Jun 13, 2024

View reviewed changes

techievivek merged commit 9792bb0 into Expensify:main Jun 13, 2024
17 of 19 checks passed

github-actions bot mentioned this pull request Jun 13, 2024

Deploy Checklist: New Expensify 2024-06-13 #43655

Closed

64 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix NVP_HOLD_USE_EXPLAINED useOnyx wrong config #42819

Fix NVP_HOLD_USE_EXPLAINED useOnyx wrong config #42819

bernhardoj commented May 30, 2024 •

edited

Loading

melvin-bot bot commented May 30, 2024

bernhardoj May 30, 2024

DylanDylann May 30, 2024

DylanDylann May 30, 2024

bernhardoj May 30, 2024

bernhardoj commented May 30, 2024

DylanDylann commented May 30, 2024

bernhardoj May 30, 2024

bernhardoj commented May 30, 2024

bernhardoj commented Jun 1, 2024

techievivek commented Jun 6, 2024

DylanDylann commented Jun 6, 2024

DylanDylann commented Jun 7, 2024

bernhardoj commented Jun 7, 2024

DylanDylann commented Jun 10, 2024

DylanDylann commented Jun 10, 2024 •

edited

Loading

DylanDylann commented Jun 10, 2024

bernhardoj commented Jun 10, 2024

DylanDylann commented Jun 10, 2024 •

edited

Loading

bernhardoj commented Jun 10, 2024 •

edited

Loading

DylanDylann commented Jun 10, 2024

bernhardoj commented Jun 10, 2024

DylanDylann commented Jun 10, 2024 •

edited

Loading

melvin-bot bot commented Jun 10, 2024

DylanDylann commented Jun 12, 2024

OSBotify commented Jun 13, 2024

OSBotify commented Jun 14, 2024

Fix NVP_HOLD_USE_EXPLAINED useOnyx wrong config #42819

Fix NVP_HOLD_USE_EXPLAINED useOnyx wrong config #42819

Conversation

bernhardoj commented May 30, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 30, 2024

bernhardoj May 30, 2024

Choose a reason for hiding this comment

DylanDylann May 30, 2024

Choose a reason for hiding this comment

DylanDylann May 30, 2024

Choose a reason for hiding this comment

bernhardoj May 30, 2024

Choose a reason for hiding this comment

bernhardoj commented May 30, 2024

DylanDylann commented May 30, 2024

bernhardoj May 30, 2024

Choose a reason for hiding this comment

bernhardoj commented May 30, 2024

bernhardoj commented Jun 1, 2024

techievivek commented Jun 6, 2024

DylanDylann commented Jun 6, 2024

DylanDylann commented Jun 7, 2024

bernhardoj commented Jun 7, 2024

DylanDylann commented Jun 10, 2024

DylanDylann commented Jun 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Jun 10, 2024

bernhardoj commented Jun 10, 2024

DylanDylann commented Jun 10, 2024 • edited Loading

bernhardoj commented Jun 10, 2024 • edited Loading

DylanDylann commented Jun 10, 2024

bernhardoj commented Jun 10, 2024

DylanDylann commented Jun 10, 2024 • edited Loading

melvin-bot bot commented Jun 10, 2024

DylanDylann commented Jun 12, 2024

OSBotify commented Jun 13, 2024

OSBotify commented Jun 14, 2024

bernhardoj commented May 30, 2024 •

edited

Loading

DylanDylann commented Jun 10, 2024 •

edited

Loading

DylanDylann commented Jun 10, 2024 •

edited

Loading

bernhardoj commented Jun 10, 2024 •

edited

Loading

DylanDylann commented Jun 10, 2024 •

edited

Loading