Allow messages scrolling within edit box. #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helaoutar
force-pushed
the
bugfix/4132_edit_message_scroll
branch
from
d2a7dca to
9be3668
Compare
deetergp
approved these changes
Jul 27, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
71 tasks
|
🚀 Deployed to staging in version: 1.0.80-3🚀
|
|
🚀 Deployed to production in version: 1.0.81-4🚀
|
98 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #4132
Tests
Tested on Chrome, FireFox, Safari and on Desktop.
QA Steps
Expected:
The message should be scrollable within the edit box.
Expected:
The message should NOT be scrollable, but the page should be.
Expected:
The message should not be scrollable neither from nor within the edit box.
Tested On
Screenshots
Web
edit.comment.chrome.mov
Mobile Web
Screen.Recording.2021-07-26.at.19.58.55.mov
Desktop
edit.demo.5.mov
iOS
Android