Android anchor markdown format 40564 #42147

samilabud · 2024-05-14T11:32:24Z

Details

We are using navigator.clipboard to handle the copy if web client supports it, but Android Native do not support it and we use Clipboard library (@react-native-clipboard/clipboard) instead to handle the copy functionality (in the composer).
Inside the setClipboardMessage we should validate if the content is only an URL, if that we should use the markdown format Clipboard.setString(parser.htmlToMarkdown(content));, with this we going to have a standard copy of any link when using the composer.

Fixed Issues

$ #40564
PROPOSAL: #40564 (comment)

Tests

Go to expensify url or open the native app (IOS or Android or Desktop)
Tap on a report
Enter an url and send
Long press the url message
Select copy to clipboard and paste in compose
Note the markdown format
This could be pasted in other/same platform with the same format
Note the url name and url could be different and works (optional)

Verify that no errors appear in the JS console

Offline tests

Go to expensify url or open the native app (IOS or Android or Desktop)
Tap on a report
Enter an url and send
Long press the url message
Select copy to clipboard and paste in compose
Note the markdown format
This could be pasted in other/same platform with the same format
Note the url name and url could be different and works (optional)

QA Steps

Go to expensify url or open the native app (IOS or Android or Desktop)
Tap on a report
Enter an url and send
Long press the url message
Select copy to clipboard and paste in compose
Note the markdown format
This could be pasted in other/same platform with the same format
Note the url name and url could be different and works (optional)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android.-.copied.link.format.test.mp4

Android: mWeb Chrome

Android.Chrome.-.copied.link.format.test.mp4

iOS: Native

Iphone.-.copied.link.format.test.mp4

iOS: mWeb Safari

IPhone.Safari.-.copied.link.format.test.mp4

MacOS: Chrome / Safari

MAC.Chrome.-.Copied.link.format.test.mp4

MacOS: Desktop

MAC.Desktop.-.copied.link.format.test.mp4

melvin-bot · 2024-05-15T12:44:39Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-05-17T08:52:42Z

src/pages/home/report/ContextMenu/ContextMenuActions.tsx

@@ -45,7 +45,9 @@ function setClipboardMessage(content: string) {
    if (!Clipboard.canSetHtml()) {
        Clipboard.setString(parser.htmlToMarkdown(content));
    } else {
-        const plainText = parser.htmlToText(content);
+        const anchorRegex = /<a\s+(?:[^>]*?\s+)?href=['"](.*?)['"]/;


Could we reuse this regex?

App/src/libs/ReportActionsUtils.ts

Line 403 in e8ae3c5

const regex = /<a\s+(?:[^>]*?\s+)?href="([^"]*)"/gi;

DylanDylann · 2024-05-17T08:53:08Z

@samilabud Also help to merge the latest main

samilabud · 2024-05-17T11:25:39Z

@samilabud Also help to merge the latest main

I have merged and did the change, but I found an error by accident (no related to this PR):

App/src/components/ReportActionItem/ReportPreview.tsx

Line 144 in e8ae3c5

const showRTERViolationMessage =

Sometimes this allTransactions[0].transactionID comes null and expensify shows the following error:

expensify.crashed.mp4

We should put the transactionID as optional because is not always present like allTransactions[0]?.transactionID.

Can we correct it in this PR or how can we report it?

DylanDylann · 2024-05-20T07:30:43Z

@samilabud Please resolve lint error

DylanDylann · 2024-05-20T07:31:20Z

src/pages/home/report/ContextMenu/ContextMenuActions.tsx

@@ -45,7 +45,10 @@ function setClipboardMessage(content: string) {
    if (!Clipboard.canSetHtml()) {
        Clipboard.setString(parser.htmlToMarkdown(content));
    } else {
-        const plainText = parser.htmlToText(content);
+        const anchorRegex = /<a\s+(?:[^>]*?\s+)?href="([^"]*)"/gi;


Should we create a CONST for this regex to avoid duplicated code?

@samilabud Please test again to make sure this regex also works well

samilabud · 2024-05-20T12:35:54Z

@DylanDylann done!, please take another look.

Extra tests

MarkDown.MAC.Web.Chrome.Test.mp4

MarkDown.Android.Test.mp4

DylanDylann · 2024-05-21T08:52:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native && mWeb Chrome

Screen.Recording.2024-05-21.at.16.01.37.mov

iOS: Native && mWeb Safari

Screen.Recording.2024-05-21.at.15.58.13.mov

MacOS: Chrome / Safari && MacOS: Desktop

Screen.Recording.2024-05-21.at.15.57.08.mov

deetergp

LGTM

deetergp · 2024-05-21T21:06:26Z

Approved but holding since we are still in a merge freeze.

OSBotify · 2024-05-24T01:47:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-27T14:25:29Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-29T09:18:10Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

samilabud added 2 commits May 10, 2024 13:25

Fixed anchor links when copied from android native from composer

c0aecb3

Merge branch 'main' into android_anchor_markdown_format_40564

4b44324

samilabud mentioned this pull request May 14, 2024

[HOLD for payment 2024-06-05] [$500] Android - Chat - Edited url is not shown & Url is changed as URL name #40564

Closed

6 tasks

Merge branch 'main' into android_anchor_markdown_format_40564

72a163d

samilabud marked this pull request as ready for review May 15, 2024 12:44

samilabud requested a review from a team as a code owner May 15, 2024 12:44

melvin-bot bot removed the request for review from a team May 15, 2024 12:44

melvin-bot bot requested a review from DylanDylann May 15, 2024 12:44

DylanDylann reviewed May 17, 2024

View reviewed changes

samilabud added 2 commits May 17, 2024 06:41

Merge branch 'main' into android_anchor_markdown_format_40564

0ed65b7

Updated regex to get link in href prop inside of <a/> component

3857608

DylanDylann reviewed May 20, 2024

View reviewed changes

Created and used constant to get the link in href inside anchor tag

e4a4d6e

DylanDylann approved these changes May 21, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp May 21, 2024 09:03

deetergp approved these changes May 21, 2024

View reviewed changes

chiragsalian merged commit b168d20 into Expensify:main May 24, 2024
16 checks passed

github-actions bot mentioned this pull request May 27, 2024

Deploy Checklist: New Expensify 2024-05-27 #42636

Closed

69 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android anchor markdown format 40564 #42147

Android anchor markdown format 40564 #42147

samilabud commented May 14, 2024 •

edited

Loading

melvin-bot bot commented May 15, 2024

DylanDylann May 17, 2024

DylanDylann commented May 17, 2024

samilabud commented May 17, 2024

DylanDylann commented May 20, 2024

DylanDylann May 20, 2024

DylanDylann May 20, 2024 •

edited

Loading

samilabud commented May 20, 2024

DylanDylann commented May 21, 2024 •

edited

Loading

deetergp left a comment

deetergp commented May 21, 2024

OSBotify commented May 24, 2024

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

Android anchor markdown format 40564 #42147

Android anchor markdown format 40564 #42147

Conversation

samilabud commented May 14, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 15, 2024

DylanDylann May 17, 2024

Choose a reason for hiding this comment

DylanDylann commented May 17, 2024

samilabud commented May 17, 2024

DylanDylann commented May 20, 2024

DylanDylann May 20, 2024

Choose a reason for hiding this comment

DylanDylann May 20, 2024 • edited Loading

Choose a reason for hiding this comment

samilabud commented May 20, 2024

DylanDylann commented May 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

deetergp left a comment

Choose a reason for hiding this comment

deetergp commented May 21, 2024

OSBotify commented May 24, 2024

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

samilabud commented May 14, 2024 •

edited

Loading

DylanDylann May 20, 2024 •

edited

Loading

DylanDylann commented May 21, 2024 •

edited

Loading