Update LHN to display transaction level actions for one-transaction reports #42005

NikkiWines · 2024-05-10T20:13:04Z

Details

Fixes the LHN for one transaction reports so we display the latest action in the LHN regardless of whether or not it occurred on the report or transaction level

Fixed Issues

$ #39450

Tests

Log into an account that is on a workspace
Create a single money request in the workspace chat
Navigate to the money request and add a comment
Confirm the LHN entry for the report updates accordingly
Modify the request by changing the description, merchant, category, etc.
Confirm the LHN entry for the report updates accordingly

Verify that no errors appear in the JS console

Offline tests

Repeat online steps from step 3 onwards.

Screen.Recording.2024-05-10.at.14.13.55.mov

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-14.at.14.50.24.mov

Android: mWeb Chrome

android.mweb.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-14.at.18.07.09.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-14.at.18.11.38.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-05-10.at.14.12.31.mov

MacOS: Desktop

Screen.Recording.2024-05-10.at.14.29.44.mov

…eports

melvin-bot · 2024-05-10T20:13:09Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NikkiWines · 2024-05-14T21:52:04Z

@Ollyws friendly bump here

Ollyws · 2024-05-15T07:19:20Z

Aplologies, completely missed this one. Will review today.

Ollyws · 2024-05-15T10:40:32Z

It's working fine on web, but on mWeb and mobile platforms for me it's showing the first report action as opposed to the most recent report action (notice on the second pinned chat the merchant is 'Test 8' but the report action is shown as 'Test 1'):

NikkiWines · 2024-05-15T17:05:08Z

🤔 good catch @Ollyws, that's super weird. I'll look into it today!

NikkiWines · 2024-05-15T19:19:04Z

🤔 I can't seem to reproduce the issue you're experiencing @Ollyws

Android/iOS Screen Recordings

Android mWeb

Screen.Recording.2024-05-15.at.11.56.17.mov

Android Native

Screen.Recording.2024-05-15.at.11.58.05.mov

iOS mWeb

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-15.at.12.10.05.mp4

iOS Native

Simulator.Screen.Recording.-.iPhone.15.-.2024-05-15.at.12.17.51.mp4

Ollyws · 2024-05-15T19:27:47Z

That's strange as I could reproduce on more than one platform, I'll look into wether it's my setup causing the issue somehow.

Ollyws · 2024-05-16T13:47:56Z

src/libs/OptionsListUtils.ts

+                    reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED &&
+                    reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
+            );
+            visibleReportActionItems[reportID] = reportActionsForDisplay[reportActionsForDisplay.length - 1];


I don't think it's a problem on my side, as reverting this back to visibleReportActionItems[reportID] = reportActionsForDisplay[0]; seems to fix the problem.

Weird, it's bizarre that we'd have different orders for web/desktop and ios/android

Seems to work on web + mobile with the original index now, so we can go with that instead of using [reportActionsForDisplay.length - 1]

src/libs/OptionsListUtils.ts

Co-authored-by: Olly <[email protected]>

…tions

NikkiWines · 2024-05-16T23:09:23Z

@Ollyws updated once more!

NikkiWines · 2024-05-18T03:02:59Z

@Ollyws friendly bump on the re-review 🙇

Ollyws · 2024-05-20T15:17:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

melvin-bot · 2024-05-20T15:18:37Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-05-27T14:25:08Z

🚀 Deployed to staging by https://github.com/chiragsalian in version: 1.4.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kavimuru · 2024-05-28T12:57:15Z

PR fails with existing bug #39450 not fixed in mweb.
https://platform.applause.com/services/links/v1/external/1835d146cc0c481a0c2f6b3f3e237754fe7bb877510ce319a4b275871cfd01e8

OSBotify · 2024-05-29T09:17:46Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

update LHN to display transaction level actions for one-transaction r…

9dcd99a

…eports

NikkiWines self-assigned this May 10, 2024

NikkiWines requested a review from a team as a code owner May 10, 2024 20:13

melvin-bot bot requested review from Ollyws and removed request for a team May 10, 2024 20:13

lint/type/prettier

12f040e

Ollyws reviewed May 16, 2024

View reviewed changes

src/libs/OptionsListUtils.ts Outdated Show resolved Hide resolved

NikkiWines and others added 3 commits May 16, 2024 12:39

fix typo in comment

a0b7ecf

Co-authored-by: Olly <[email protected]>

Merge branch 'main' of github.com:Expensify/App into nikki-fix-lhn-ac…

82d4835

…tions

use 0 instead of reportActionsForDisplay.length - 1

ce5243b

Ollyws approved these changes May 20, 2024

View reviewed changes

melvin-bot bot requested a review from cristipaval May 20, 2024 15:18

NikkiWines mentioned this pull request May 20, 2024

[$250] Expense - Combined report in LHN is always bolded after modifying transaction #41088

Closed

6 tasks

cristipaval approved these changes May 22, 2024

View reviewed changes

chiragsalian merged commit c7d9804 into main May 24, 2024
16 checks passed

chiragsalian deleted the nikki-fix-lhn-actions branch May 24, 2024 00:24

github-actions bot mentioned this pull request May 27, 2024

Deploy Checklist: New Expensify 2024-05-27 #42636

Closed

69 tasks

melvin-bot bot mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-05] [One expense reports] System message for request edit does not show up in LHN when there is a single request #39450

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update LHN to display transaction level actions for one-transaction reports #42005

Update LHN to display transaction level actions for one-transaction reports #42005

NikkiWines commented May 10, 2024 •

edited

Loading

melvin-bot bot commented May 10, 2024

NikkiWines commented May 14, 2024

Ollyws commented May 15, 2024

Ollyws commented May 15, 2024

NikkiWines commented May 15, 2024

NikkiWines commented May 15, 2024

Ollyws commented May 15, 2024

Ollyws May 16, 2024

NikkiWines May 16, 2024

NikkiWines May 16, 2024 •

edited

Loading

NikkiWines commented May 16, 2024

NikkiWines commented May 18, 2024

Ollyws commented May 20, 2024

Ollyws left a comment

melvin-bot bot commented May 20, 2024

OSBotify commented May 27, 2024

kavimuru commented May 28, 2024 •

edited

Loading

OSBotify commented May 29, 2024

Update LHN to display transaction level actions for one-transaction reports #42005

Update LHN to display transaction level actions for one-transaction reports #42005

Conversation

NikkiWines commented May 10, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 10, 2024

NikkiWines commented May 14, 2024

Ollyws commented May 15, 2024

Ollyws commented May 15, 2024

NikkiWines commented May 15, 2024

NikkiWines commented May 15, 2024

Ollyws commented May 15, 2024

Ollyws May 16, 2024

Choose a reason for hiding this comment

NikkiWines May 16, 2024

Choose a reason for hiding this comment

NikkiWines May 16, 2024 • edited Loading

Choose a reason for hiding this comment

NikkiWines commented May 16, 2024

NikkiWines commented May 18, 2024

Ollyws commented May 20, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

melvin-bot bot commented May 20, 2024

OSBotify commented May 27, 2024

kavimuru commented May 28, 2024 • edited Loading

OSBotify commented May 29, 2024

NikkiWines commented May 10, 2024 •

edited

Loading

NikkiWines May 16, 2024 •

edited

Loading

kavimuru commented May 28, 2024 •

edited

Loading