Fix can't navigate with arrow key to admin in group members page #41968

bernhardoj · 2024-05-10T09:27:55Z

Details

It's currently not possible to navigate to the admin member with arrow key in the group members page. This PR fix it.

Fixed Issues

$ #41570
PROPOSAL: #41570 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: Create a new group chat

Open the group chat
Press the header to open the detail and press Members
Use arrow key/down to navigate between the list
Verify it can highlight the admin member.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-10.at.17.21.39.mov

Android: mWeb Chrome

Screen.Recording.2024-05-10.at.17.20.18.mov

iOS: Native

Screen.Recording.2024-05-10.at.17.21.12.mov

iOS: mWeb Safari

Screen.Recording.2024-05-10.at.17.22.06.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-10.at.17.13.35.mov

MacOS: Desktop

Screen.Recording.2024-05-10.at.17.14.58.mov

melvin-bot · 2024-05-10T09:28:00Z

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-05-13T08:22:19Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Can't reproduce on physical devices

Android: mWeb Chrome

Can't reproduce on physical devices

iOS: Native

Can't reproduce on physical devices

iOS: mWeb Safari

Can't reproduce on physical devices

MacOS: Chrome / Safari

Screen.Recording.2024-05-13.at.15.43.36.mov

Screen.Recording.2024-05-13.at.15.49.14.mov

MacOS: Desktop

Screen.Recording.2024-05-13.at.15.49.38.mov

Screen.Recording.2024-05-13.at.15.46.34.mov

puneetlath · 2024-05-14T15:19:18Z

src/components/SelectionList/BaseSelectionList.tsx

@@ -109,6 +109,7 @@ function BaseSelectionList<TItem extends ListItem>(
        const allOptions: TItem[] = [];

        const disabledOptionsIndexes: number[] = [];
+        const disabledArrowKeyOptionsIndexes: number[] = [];


Can we add a comment explaining what these two arrays are for? Or add it to the comment above the flattenedSections function.

Added the comment

Thanks for adding. It's not super obvious to me how disabledOptionsIndexes and disabledArrowKeyOptionsIndexes are different. Can we try to make that a little bit more explicit and obvious?

Conflicts solved and comment updated. Please check

…-item-using-arrow-keyboard

puneetlath

Also you have conflicts now.

puneetlath · 2024-05-15T15:09:00Z

src/components/SelectionList/BaseSelectionList.tsx

@@ -101,14 +101,16 @@ function BaseSelectionList<TItem extends ListItem>(
    /**
     * Iterates through the sections and items inside each section, and builds 3 arrays along the way:


This comment is now wrong.

puneetlath · 2024-05-15T15:09:35Z

src/components/SelectionList/BaseSelectionList.tsx

@@ -109,6 +109,7 @@ function BaseSelectionList<TItem extends ListItem>(
        const allOptions: TItem[] = [];

        const disabledOptionsIndexes: number[] = [];
+        const disabledArrowKeyOptionsIndexes: number[] = [];


Thanks for adding. It's not super obvious to me how disabledOptionsIndexes and disabledArrowKeyOptionsIndexes are different. Can we try to make that a little bit more explicit and obvious?

…-item-using-arrow-keyboard

DylanDylann · 2024-05-27T02:47:56Z

@bernhardoj Please resolve conflict

…-item-using-arrow-keyboard

bernhardoj · 2024-05-27T05:56:53Z

Solved

OSBotify · 2024-05-27T14:24:56Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 1.4.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-29T09:17:34Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.76-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix can't navigate with arrow key to disabled checkbox item

f1990c4

bernhardoj requested a review from a team as a code owner May 10, 2024 09:27

melvin-bot bot requested review from DylanDylann and removed request for a team May 10, 2024 09:27

DylanDylann approved these changes May 13, 2024

View reviewed changes

melvin-bot bot requested a review from puneetlath May 13, 2024 08:52

puneetlath requested changes May 14, 2024

View reviewed changes

bernhardoj added 2 commits May 15, 2024 10:57

update comment

78cae44

Merge branch 'main' into fix/41570-cant-navigate-to-disabled-checkbox…

1ef3a47

…-item-using-arrow-keyboard

puneetlath requested changes May 15, 2024

View reviewed changes

bernhardoj added 2 commits May 16, 2024 11:20

Merge branch 'main' into fix/41570-cant-navigate-to-disabled-checkbox…

742b440

…-item-using-arrow-keyboard

update comment

d66f315

puneetlath previously approved these changes May 21, 2024

View reviewed changes

Merge branch 'main' into fix/41570-cant-navigate-to-disabled-checkbox…

acc4b28

…-item-using-arrow-keyboard

bernhardoj dismissed puneetlath’s stale review via acc4b28 May 27, 2024 05:56

puneetlath approved these changes May 27, 2024

View reviewed changes

puneetlath merged commit b565af1 into Expensify:main May 27, 2024
16 checks passed

github-actions bot mentioned this pull request May 27, 2024

Deploy Checklist: New Expensify 2024-05-27 #42636

Closed

69 tasks

melvin-bot bot mentioned this pull request May 29, 2024

[HOLD for payment 2024-06-05] [$250] Group chat - Inconsistency with highlight of group admin row by cursor, up & down and Tab key #41570

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix can't navigate with arrow key to admin in group members page #41968

Fix can't navigate with arrow key to admin in group members page #41968

bernhardoj commented May 10, 2024

melvin-bot bot commented May 10, 2024

DylanDylann commented May 13, 2024 •

edited

Loading

puneetlath May 14, 2024

bernhardoj May 15, 2024

puneetlath May 15, 2024

bernhardoj May 16, 2024

puneetlath left a comment

puneetlath May 15, 2024

bernhardoj May 16, 2024

puneetlath May 15, 2024

DylanDylann commented May 27, 2024

bernhardoj commented May 27, 2024

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

		@@ -101,14 +101,16 @@ function BaseSelectionList<TItem extends ListItem>(
		/**
		* Iterates through the sections and items inside each section, and builds 3 arrays along the way:

Fix can't navigate with arrow key to admin in group members page #41968

Fix can't navigate with arrow key to admin in group members page #41968

Conversation

bernhardoj commented May 10, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented May 10, 2024

DylanDylann commented May 13, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

puneetlath May 14, 2024

Choose a reason for hiding this comment

bernhardoj May 15, 2024

Choose a reason for hiding this comment

puneetlath May 15, 2024

Choose a reason for hiding this comment

bernhardoj May 16, 2024

Choose a reason for hiding this comment

puneetlath left a comment

Choose a reason for hiding this comment

puneetlath May 15, 2024

Choose a reason for hiding this comment

bernhardoj May 16, 2024

Choose a reason for hiding this comment

puneetlath May 15, 2024

Choose a reason for hiding this comment

DylanDylann commented May 27, 2024

bernhardoj commented May 27, 2024

OSBotify commented May 27, 2024

OSBotify commented May 29, 2024

DylanDylann commented May 13, 2024 •

edited

Loading