Animate sign-in pages #40337

tienifr · 2024-04-17T08:21:45Z

Details

Add animations to some sign-in pages.

Fixed Issues

$ #18262
PROPOSAL: #18262 (comment)

Tests

Enable 2FA for the account
Sign out
Open any previous magic link in a new tab (with correct environment URL)
Verify Here is your magic code page appears with the magic code animation
Sign in
Open the magic link in a new tab
Verify Two-factor authentication required page appears with the safe animation
Sign in with 2FA code
Verify Abracadabra, you are signed in! page appears with animation

Verify that no errors appear in the JS console

Offline tests

NA

QA Steps

Enable 2FA for the account
Sign out
Open any previous magic link in a new tab (with correct environment URL)
Verify Here is your magic code page appears with the magic code animation
Sign in
Open the magic link in a new tab
Verify Two-factor authentication required page appears with the safe animation
Sign in with 2FA code
Verify Abracadabra, you are signed in! page appears with animation

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: mWeb Chrome

Screen.Recording.2024-04-17.at.15.29.14-compressed.mov

Screen.Recording.2024-04-17.at.15.26.57-compressed.mov

Screen.Recording.2024-04-17.at.15.24.51-compressed.mov

iOS: mWeb Safari

Screen.Recording.2024-04-17.at.15.08.13-compressed.mov

Screen.Recording.2024-04-17.at.15.06.15-compressed.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.15.00.41-compressed.mov

Screen.Recording.2024-04-17.at.14.58.12-compressed.mov

Screen.Recording.2024-04-17.at.12.04.59-compressed.mov

melvin-bot · 2024-04-17T08:31:33Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2024-04-17T10:51:19Z

Looking good from a design perspective! cc @grgia for a second set of eyes too.

grgia · 2024-04-17T13:21:18Z

@shawnborton my only comment is that the magic ball feels slightly off center, but if you think it looks fine as is, I think we're good to go

shawnborton · 2024-04-17T13:25:17Z

Ooo that's fair. I don't feel too strongly, we could pull it over using some styles but hopefully we don't need to make a new animation!

tienifr · 2024-04-22T02:45:14Z

@shawnborton @grgia That already happened with the image itself (before animation). I think that's due to the 2 candles pushed to the far right. Also bump @eVoloshchak for review.

shawnborton · 2024-04-22T13:16:06Z

Got it - this one doesn't bother me too much, I'd be fine leaving as-is.

eVoloshchak

Looking good, let's rename both styles so the naming is consistent with the rest of the app

src/components/ValidateCode/JustSignedInModal.tsx

src/components/ValidateCode/ValidateCodeModal.tsx

src/styles/index.ts

…gn-in-pages-animation

tienifr · 2024-04-24T11:31:05Z

@eVoloshchak Updated.

eVoloshchak · 2024-04-25T17:26:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: mWeb Chrome

Screen.Recording.2024-04-25.at.21.55.49.mov

iOS: mWeb Safari

Screen.Recording.2024-04-25.at.21.49.52.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-25.at.21.47.06.mov

eVoloshchak · 2024-04-25T20:05:03Z

@tienifr, could you check if animation is working on Here is your magic code in Safari mWeb? For me it's just a static image, even though other animations are displayed correctly

Screen.Recording.2024-04-25.at.22.04.11.mov

Or 1:02 on iOS: mWeb Safari video

…gn-in-pages-animation

tienifr · 2024-05-29T22:44:53Z

@eVoloshchak As per here we can ignore the lagging issue on Safari because it seems to be a problem with the lottie file.

eVoloshchak · 2024-06-03T15:53:31Z

@tienifr, sure thing!
Could you please pull the latest changes from main so I can re-test this?

…gn-in-pages-animation

tienifr · 2024-06-04T20:08:39Z

@eVoloshchak Done!

eVoloshchak

LGTM!

grgia

Code LGTM, @shawnborton do you need to do another review or can I merge?

shawnborton · 2024-06-06T12:34:56Z

For the magic code illustration, I thought it was just laggy on Safari - I didn't realize it doesn't play at all on iOS. Is that what's going on here?

grgia · 2024-06-06T12:36:11Z

For the magic code illustration, I thought it was just laggy on Safari - I didn't realize it doesn't play at all on iOS. Is that what's going on here?

@roryabraham could you help fill me and @shawnborton in?

tienifr · 2024-06-06T13:04:26Z

I didn't realize it doesn't play at all on iOS

@shawnborton How could you trigger that illustration on iOS (or native platforms in general)?

shawnborton · 2024-06-06T13:32:22Z

I was just looking at the screenshots in the checklist here

tienifr · 2024-06-07T10:09:41Z

@shawnborton Don't worry because we couldn't reproduce the flow on native platforms.

shawnborton · 2024-06-07T10:13:12Z

Ah okay 👍

tienifr · 2024-06-10T04:51:38Z

@shawnborton Then do you have any other feedback?

shawnborton · 2024-06-10T06:31:01Z

No further comments from me

tienifr · 2024-06-10T06:43:33Z

@grgia ^ We're good to go!

OSBotify · 2024-06-12T14:23:19Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-06-14T23:02:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.83-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

animate sign-in pages

3b45b39

tienifr marked this pull request as ready for review April 17, 2024 08:31

tienifr requested review from a team as code owners April 17, 2024 08:31

melvin-bot bot requested review from eVoloshchak and removed request for a team April 17, 2024 08:31

tienifr mentioned this pull request Apr 17, 2024

[$250] Animate the Sign-In Link Pages #18262

Closed

shawnborton mentioned this pull request Apr 17, 2024

[HOLD for payment 2024-05-09] [Desktop] Create a page to show when we fail to close the window during the QBO Authentication flow #40365

Closed

6 tasks

eVoloshchak suggested changes Apr 23, 2024

View reviewed changes

tienifr added 2 commits April 24, 2024 18:28

Merge branch 'main' of https://github.com/tienifr/App into feature/si…

7d19d7c

…gn-in-pages-animation

rename variables

987f3f7

Merge branch 'main' of https://github.com/tienifr/App into feature/si…

7602c83

…gn-in-pages-animation

Merge branch 'main' of https://github.com/tienifr/App into feature/si…

4ff74f0

…gn-in-pages-animation

eVoloshchak approved these changes Jun 5, 2024

View reviewed changes

melvin-bot bot requested a review from grgia June 5, 2024 18:12

grgia approved these changes Jun 6, 2024

View reviewed changes

grgia merged commit cb02bb3 into Expensify:main Jun 12, 2024
16 checks passed

github-actions bot mentioned this pull request Jun 13, 2024

Deploy Checklist: New Expensify 2024-06-13 #43655

Closed

64 tasks

This was referenced Jun 13, 2024

[HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] mWeb - Login – Animation appears with delay when navigate via magic link in incognino tab #43718

Closed

Remove Magic Code Animation #43732

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Animate sign-in pages #40337

Animate sign-in pages #40337

tienifr commented Apr 17, 2024 •

edited

Loading

melvin-bot bot commented Apr 17, 2024

shawnborton commented Apr 17, 2024

grgia commented Apr 17, 2024

shawnborton commented Apr 17, 2024

tienifr commented Apr 22, 2024 •

edited

Loading

shawnborton commented Apr 22, 2024

eVoloshchak left a comment

tienifr commented Apr 24, 2024

eVoloshchak commented Apr 25, 2024 •

edited

Loading

eVoloshchak commented Apr 25, 2024

tienifr commented May 29, 2024 •

edited

Loading

eVoloshchak commented Jun 3, 2024

tienifr commented Jun 4, 2024

eVoloshchak left a comment

grgia left a comment

shawnborton commented Jun 6, 2024

grgia commented Jun 6, 2024

tienifr commented Jun 6, 2024

shawnborton commented Jun 6, 2024

tienifr commented Jun 7, 2024

shawnborton commented Jun 7, 2024

tienifr commented Jun 10, 2024

shawnborton commented Jun 10, 2024

tienifr commented Jun 10, 2024

OSBotify commented Jun 12, 2024

OSBotify commented Jun 14, 2024

Animate sign-in pages #40337

Animate sign-in pages #40337

Conversation

tienifr commented Apr 17, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 17, 2024

shawnborton commented Apr 17, 2024

grgia commented Apr 17, 2024

shawnborton commented Apr 17, 2024

tienifr commented Apr 22, 2024 • edited Loading

shawnborton commented Apr 22, 2024

eVoloshchak left a comment

Choose a reason for hiding this comment

tienifr commented Apr 24, 2024

eVoloshchak commented Apr 25, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak commented Apr 25, 2024

tienifr commented May 29, 2024 • edited Loading

eVoloshchak commented Jun 3, 2024

tienifr commented Jun 4, 2024

eVoloshchak left a comment

Choose a reason for hiding this comment

grgia left a comment

Choose a reason for hiding this comment

shawnborton commented Jun 6, 2024

grgia commented Jun 6, 2024

tienifr commented Jun 6, 2024

shawnborton commented Jun 6, 2024

tienifr commented Jun 7, 2024

shawnborton commented Jun 7, 2024

tienifr commented Jun 10, 2024

shawnborton commented Jun 10, 2024

tienifr commented Jun 10, 2024

OSBotify commented Jun 12, 2024

OSBotify commented Jun 14, 2024

tienifr commented Apr 17, 2024 •

edited

Loading

tienifr commented Apr 22, 2024 •

edited

Loading

eVoloshchak commented Apr 25, 2024 •

edited

Loading

tienifr commented May 29, 2024 •

edited

Loading