Export main page - initial #39191

narefyev91 · 2024-03-28T16:35:07Z

Details

Export main pages for QBO

Fixed Issues

$ #37780
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

Screen.Recording.2024-04-19.at.20.30.26.mov

iOS: mWeb Safari

Screen.Recording.2024-04-17.at.16.59.37.mov

MacOS: Chrome / Safari

Screen.Recording.2024-04-17.at.16.49.03.mov

MacOS: Desktop

Screen.Recording.2024-04-17.at.17.07.43.mov

# Conflicts: # src/languages/es.ts # src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts # src/libs/Navigation/linkingConfig/config.ts # src/libs/Navigation/types.ts # src/pages/workspace/accounting/WorkspaceAccountingPage.tsx # src/types/onyx/Policy.ts

narefyev91 · 2024-04-12T12:51:12Z

@shawnborton @Expensify/design Hey! Can i ask about first look at Export screens - probably not so many UI changes - but will be nice to get initial feedback. You will see that nothing is selected in the list - for now i'm working on some fake onyx integration - to make screens interactive - but should be ready earlier next week - after that we can run builds to see live. But for now just screenshots for initial review. Thanks!

shawnborton · 2024-04-12T13:11:31Z

For cases like these:

The text below the row should be styled like other hint text, where:

the text size is 13px (label)
the text color is textSupporting
the hint text is 8px away from the push row above

shawnborton · 2024-04-12T13:12:05Z

For this particular screen, the hint text seems to be too far below the push row (maybe just by 4px or so?) and the line height of the hint text seems too tall. It should be the same line height we use for other label text, which I believe is 16px?

… usage

hayata-suenaga · 2024-04-15T20:54:19Z

please mark this PR ready for review when the PR is ready

… doc

melvin-bot · 2024-04-16T15:17:39Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/accounting/qbo/export/QuickbooksExportConfigurationPage.tsx

src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

src/pages/workspace/accounting/qbo/export/QuickbooksExportConfigurationPage.tsx

s77rt · 2024-04-19T20:08:55Z

src/pages/workspace/accounting/qbo/export/QuickbooksOutOfPocketExpenseConfigurationPage.tsx

+                                    onPress={() => Navigation.navigate(ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_EXPORT_OUT_OF_POCKET_EXPENSES_ACCOUNT_SELECT.getRoute(policyID))}
+                                    brickRoadIndicator={errors?.exportAccount ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
+                                    shouldShowRightIcon
+                                    error={errors?.exportAccount ? translate('common.genericErrorMessage') : undefined}


Same question ^

@s77rt i think for now it will be default one - nothing was specified in high level doc, and after fixing errorText we will move to api errors directly

s77rt · 2024-04-19T20:46:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

hayata-suenaga · 2024-04-21T15:29:55Z

@s77t, where are we at with this PR? are we close to merging the PR? @narefyev91, there is one merge conflicts, can you solve it when you come back online?

s77rt · 2024-04-21T17:34:31Z

@hayata-suenaga Yes, this is pretty much ready. The above comments should be easy to address.

# Conflicts: # src/libs/PolicyUtils.ts

s77rt · 2024-04-22T08:04:32Z

Seems that this one is still unresolved #39191 (comment)
The BRB and pendingAction should be there if either export entity or export account have errors / pendingAction

narefyev91 · 2024-04-22T08:18:16Z

Seems that this one is still unresolved #39191 (comment) The BRB and pendingAction should be there if either export entity or export account have errors / pendingAction

@s77rt Not really sure why we should combine both export entity or export account as a indicator for this field? I'm not seeing connected logic between export entity and export account.

s77rt · 2024-04-22T08:28:50Z

Both are in the inner pages of that menu item.

Menu item A
- Menu item 1
- Menu item 2

If either menu item 1 or 2 have a BRB then menu item A should have it too. Otherwise you wouldn't know that we have errors

narefyev91 · 2024-04-22T08:36:39Z

Both are in the inner pages of that menu item.

Menu item A

Menu item 1

Menu item 2

If either menu item 1 or 2 have a BRB then menu item A should have it too. Otherwise you wouldn't know that we have errors

got it. Updated

s77rt · 2024-04-22T08:54:39Z

Thanks! Code looks good to me. I'm currently outside, once I get back I will give this the final test. Feel free to merge though as I don't see any blockers.

narefyev91 · 2024-04-22T12:12:46Z

@hayata-suenaga @shawnborton can someone from you create a follow up github issue - for Error text component based on this discussion - #39191 (comment) - i can probably with that as well

s77rt · 2024-04-22T13:41:06Z

I noticed that if we have an error in the preferred exporter we can't clear it if there is no other option to choose. This not a blocker. This is due to missing the failure logic in updatePolicyConnectionConfig, we are not reverting the settingValue

Screen.Recording.2024-04-22.at.2.36.02.PM.mov

github-actions · 2024-04-22T13:42:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/39191/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/39191/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://39191.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

hayata-suenaga · 2024-04-22T13:58:56Z

@hayata-suenaga @shawnborton can someone from you create a follow up github issue - for Error text component based on this discussion - #39191 (comment) - i can probably with that as well

Created one 😄 @narefyev91, could you comment something on the issue so that I can assign you there? 😄

hayata-suenaga

🟢 thank you so much everyone for pushing forward this PR!

OSBotify · 2024-04-23T23:42:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

narefyev91 added 5 commits March 28, 2024 18:25

Export main page - initial

c2a0b77

prettier

1dfc676

Export date page - initial

2743434

Merge branch 'main' into qbo-export-pages

21bc341

Export invoice page

b07c195

hayata-suenaga mentioned this pull request Apr 2, 2024

[Awaiting Payment 2nd May] [Wave Collect][QBO] Implement Advanced configuration screens #37799

Closed

narefyev91 added 3 commits April 3, 2024 17:36

Company card + company card selection screens

d0a4ccf

Export Preferred Exporter screen + sub screen

11c23ff

prettier

1c0d2f3

hayata-suenaga mentioned this pull request Apr 8, 2024

Add new HOC to get policy.connections data #39132

Merged

58 tasks

narefyev91 added 7 commits April 9, 2024 10:17

icon button

20814b7

renaming pages + correct routes + initial Expenses config page

05d2869

resolve conflicts

6490db7

resolve conflicts

a1349fc

Out of pocket sub page

5e1f432

Re-work on Preferred exporter with new design

d140a2a

Design updates + updates for translations + updates for onyx api keys…

a397b70

… usage

kadiealexander mentioned this pull request Apr 16, 2024

[$250] [Awaiting Payment May 1st] [Wave Collect][QBO] Implement Export-related screens #37780

Closed

narefyev91 added 3 commits April 16, 2024 13:54

Merge branch 'refs/heads/main' into qbo-export-pages

06f10aa

Updates for some mock api calls, clean based on the high level design…

d7a117b

… doc

fix ts

8ce62d9

narefyev91 marked this pull request as ready for review April 16, 2024 15:17

narefyev91 requested a review from a team as a code owner April 16, 2024 15:17

melvin-bot bot removed the request for review from a team April 16, 2024 15:17

updates

57840ba

narefyev91 requested a review from s77rt April 19, 2024 17:31

s77rt mentioned this pull request Apr 19, 2024

feature: implement qbo advanced configuration screens #39899

Merged

50 tasks

s77rt suggested changes Apr 19, 2024

View reviewed changes

narefyev91 added 2 commits April 22, 2024 10:04

Merge branch 'refs/heads/main' into qbo-export-pages

ea62635

# Conflicts: # src/libs/PolicyUtils.ts

updates

34d123b

narefyev91 requested a review from s77rt April 22, 2024 07:41

polish

1346a10

shawnborton added the Ready To Build label Apr 22, 2024

s77rt approved these changes Apr 22, 2024

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga April 22, 2024 13:41

hayata-suenaga mentioned this pull request Apr 22, 2024

[$250] [Wave Collect][QBO] Refactor the error text style #40697

Closed

hayata-suenaga approved these changes Apr 22, 2024

View reviewed changes

hayata-suenaga merged commit ba03153 into Expensify:main Apr 22, 2024
16 checks passed

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

hayata-suenaga mentioned this pull request May 1, 2024

Fix account type name constants #41155

Merged

48 tasks

hungvu193 mentioned this pull request Aug 31, 2024

[$250] Integrations - Preferred exporter check-mark is missing before manual change #46675

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Export main page - initial #39191

Export main page - initial #39191

narefyev91 commented Mar 28, 2024 •

edited

Loading

narefyev91 commented Apr 12, 2024

shawnborton commented Apr 12, 2024

shawnborton commented Apr 12, 2024

hayata-suenaga commented Apr 15, 2024

melvin-bot bot commented Apr 16, 2024

s77rt Apr 19, 2024

narefyev91 Apr 22, 2024

s77rt commented Apr 19, 2024 •

edited

Loading

hayata-suenaga commented Apr 21, 2024

s77rt commented Apr 21, 2024

s77rt commented Apr 22, 2024

narefyev91 commented Apr 22, 2024

s77rt commented Apr 22, 2024

narefyev91 commented Apr 22, 2024

s77rt commented Apr 22, 2024

narefyev91 commented Apr 22, 2024

s77rt commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

hayata-suenaga commented Apr 22, 2024 •

edited

Loading

hayata-suenaga left a comment

OSBotify commented Apr 23, 2024

Export main page - initial #39191

Export main page - initial #39191

Conversation

narefyev91 commented Mar 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

narefyev91 commented Apr 12, 2024

shawnborton commented Apr 12, 2024

shawnborton commented Apr 12, 2024

hayata-suenaga commented Apr 15, 2024

melvin-bot bot commented Apr 16, 2024

s77rt Apr 19, 2024

Choose a reason for hiding this comment

narefyev91 Apr 22, 2024

Choose a reason for hiding this comment

s77rt commented Apr 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

hayata-suenaga commented Apr 21, 2024

s77rt commented Apr 21, 2024

s77rt commented Apr 22, 2024

narefyev91 commented Apr 22, 2024

s77rt commented Apr 22, 2024

narefyev91 commented Apr 22, 2024

s77rt commented Apr 22, 2024

narefyev91 commented Apr 22, 2024

s77rt commented Apr 22, 2024

github-actions bot commented Apr 22, 2024

hayata-suenaga commented Apr 22, 2024 • edited Loading

hayata-suenaga left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 23, 2024

narefyev91 commented Mar 28, 2024 •

edited

Loading

s77rt commented Apr 19, 2024 •

edited

Loading

hayata-suenaga commented Apr 22, 2024 •

edited

Loading