[Simplified Collect][Taxes] Creating new taxes #37967

kosmydel · 2024-03-08T13:05:28Z

Details

This PR introduces the ability to create a new tax rate on the Taxes page:

the WorkspaceNewTaxPage,
the TextPicker component,
the AmountPicker component.

Fixed Issues

$ #37793
PROPOSAL: N/A

Tests

Make sure you are using the staging server (production doesn't support creating new taxes yet).
Go to the Workspace Collect.
(If needed) Turn on the Taxes feature in the More features tab.
Press the Add rate button in the top right corner.
Pick a name and value.
Press save.
Verify a new tax rate was added to the list.
Open again the Add rate modal.
Verify the form is cleared (draft is not stored).
Validations (remember to press Save each time):

Select a duplicated name.
Select an empty name.
Select an empty value.
Select a tax value of more than 100 percent.

Log out and log in to check if the changes are persisted on the backend (alternatively: use two devices).

Offline tests

Offline mode scenario:

Failure scenario:

Turn on Simulate failing network requests in the Troubleshoot menu.
Create a new tax rate.
Verify the error message is shown near the new tax rate (it should be displayed after 10 retries, so it might take a while).
Verify the brickRoadIndicator is displayed in the LHN list (near the Taxes item).
Verify you can clear the error message by clicking on it.

QA Steps

Verify that no errors appear in the JS console
Do the tests from the above.

PR Author Checklist

Screenshots/Videos

Android & iOS: Native

native.mov

Android & iOS: mWeb

mweb.mov

MacOS: Chrome / Safari

Uploading web.mov…

MacOS: Desktop

desktop.mov

melvin-bot · 2024-03-08T13:05:32Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

src/CONST.ts

src/ONYXKEYS.ts

src/libs/Navigation/linkingConfig/config.ts

src/SCREENS.ts

src/types/onyx/Policy.ts

src/libs/actions/TaxRate.ts

DylanDylann · 2024-03-18T12:26:33Z

@kosmydel minor comments. Please update it

Waiting for translation confirmation here

Co-authored-by: DylanDylann <[email protected]>

src/components/AmountPicker/types.ts

src/components/TextInputWithCurrencySymbol/types.ts

src/components/TextPicker/TextSelectorModal.tsx

src/components/TextPicker/types.ts

src/libs/actions/TaxRate.ts

mountiny · 2024-03-18T13:30:58Z

src/libs/actions/TaxRate.ts

+    return covertTaxNameToID(`${name}_${nextID}`);
+}
+
+function createPolicyTax(policyID: string, taxRate: TaxRate) {


We kept the create policy tags / categories in the policy.ts actions file. I think we should keep this in as well @luacmartins

I think we have decided to use a new file in the design doc:
https://docs.google.com/document/d/12FZycslrIE95QoKM8DZ37H_wLbH9w1jt3uA-a6BCqtc/edit#heading=h.2c5k7uahsdxe

Ok thanks for the link. I think we should then follow up with similar update for other Policy features. @luacmartins

Yea, I think we can clean this up later and create an utils file for each of them. Created issue here

src/libs/actions/TaxRate.ts

mountiny · 2024-03-18T13:32:25Z

src/libs/actions/TaxRate.ts

+                    taxRates: {
+                        taxes: {
+                            [taxRate.code]: {
+                                pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD,


+1 this has to be removed, user will remove the error using the red brick road and clicking X

DylanDylann · 2024-03-18T13:44:18Z

@kosmydel Updated suggestion: #37967 (comment)

DylanDylann · 2024-03-18T13:45:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-18.at.21.22.55.mov

Android: mWeb Chrome

Screen.Recording.2024-03-18.at.20.58.04.mov

iOS: Native

Screen.Recording.2024-03-18.at.21.23.27.mov

iOS: mWeb Safari

Screen.Recording.2024-03-18.at.20.48.57.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-18.at.20.46.46.mov

MacOS: Desktop

Screen.Recording.2024-03-18.at.20.58.45.mov

luacmartins · 2024-03-18T15:16:27Z

src/libs/actions/TaxRate.ts

+    return covertTaxNameToID(`${name}_${nextID}`);
+}
+
+function createPolicyTax(policyID: string, taxRate: TaxRate) {


Yea, I think we can clean this up later and create an utils file for each of them. Created issue here

melvin-bot · 2024-03-18T15:17:24Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

luacmartins · 2024-03-18T15:18:16Z

Tests were passing

OSBotify · 2024-03-18T15:23:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-18T16:30:25Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.54-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-03-19T23:11:29Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.4.54-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jayeshmangwani · 2024-06-06T12:23:45Z

src/pages/workspace/taxes/WorkspaceCreateTaxPage.tsx

+                                    maxLength={CONST.TAX_RATES.NAME_MAX_LENGTH}
+                                    multiline={false}
+                                    role={CONST.ROLE.PRESENTATION}
+                                    autoFocus


autoFocus does work properly for all the Platforms, We should use useFocusEffect hook to focus on the input which is also suggested in the docs. autoFocus cause this Issue #41800 and the keyboard does not automatically appear in the Name menu

kosmydel added 9 commits March 7, 2024 15:26

add initial new tax page

b7cdc1b

add API command

b351a28

add AmountSelectorModal

0f5eaad

add TextPicker

3c3fc37

fix new pickers

fd5029c

use pendingActions and errors in tax rates

9e492c2

draft

da6573f

Merge branch 'wave8/WorkspaceTaxesPage' into wave8/CreatingNewTaxes

4538c2a

fix validation

01a70b9

kosmydel added 9 commits March 8, 2024 14:09

add saving drafts

05f3a09

fix displaying tax rate in the list

c0ead40

change type names

34cef2a

Merge branch 'wave8/WorkspaceTaxesPage' into wave8/CreatingNewTaxes

d9574c2

add spanish translation drafts

71d90f4

fix translation

4be8838

Merge branch 'wave8/WorkspaceTaxesPage' into wave8/CreatingNewTaxes

ae25dc5

add auto focus

b6b6fd4

add brickRoadIndicator

6903cb5

filip-solecki reviewed Mar 12, 2024

View reviewed changes

src/CONST.ts Show resolved Hide resolved

src/ONYXKEYS.ts Show resolved Hide resolved

fix parameters

d461d15

luacmartins self-requested a review March 12, 2024 15:48

kosmydel added 8 commits March 13, 2024 09:59

Merge branch 'wave8/WorkspaceTaxesPage' into wave8/CreatingNewTaxes

4728b24

fix rhp mapping

7ba715e

clear drafts

c8ce6bb

cleanup

31d41b9

lint

3cf7374

Merge branch 'main' into wave8/CreatingNewTaxes

2747599

extract validation

5ebdcb1

fix types

46da5b0

kosmydel commented Mar 18, 2024

View reviewed changes

src/libs/Navigation/linkingConfig/config.ts Outdated Show resolved Hide resolved

rename TAX_CREATE screen

186a79b

DylanDylann reviewed Mar 18, 2024

View reviewed changes

src/SCREENS.ts Outdated Show resolved Hide resolved

src/types/onyx/Policy.ts Show resolved Hide resolved

DylanDylann reviewed Mar 18, 2024

View reviewed changes

src/libs/actions/TaxRate.ts Outdated Show resolved Hide resolved

src/libs/actions/TaxRate.ts Show resolved Hide resolved

src/libs/actions/TaxRate.ts Outdated Show resolved Hide resolved

kosmydel and others added 2 commits March 18, 2024 13:55

Update src/SCREENS.ts

79977f2

Co-authored-by: DylanDylann <[email protected]>

address review

4b764ea

mountiny reviewed Mar 18, 2024

View reviewed changes

fix comments

dd79adb

DylanDylann approved these changes Mar 18, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins March 18, 2024 14:25

luacmartins approved these changes Mar 18, 2024

View reviewed changes

luacmartins merged commit 623d084 into Expensify:main Mar 18, 2024
20 checks passed

melvin-bot bot added the Emergency label Mar 18, 2024

luacmartins removed the Emergency label Mar 18, 2024

github-actions bot mentioned this pull request Mar 18, 2024

Deploy Checklist: New Expensify 2024-03-18 #38489

Closed

65 tasks

francoisl mentioned this pull request Mar 18, 2024

[HOLD for payment 2024-04-05] [HOLD for payment 2024-03-29] [HOLD for payment 2024-03-26] [Simplified Collect][Taxes] iOS - Taxes - App crashes tapping tax value #38502

Closed

6 tasks

kbecciv mentioned this pull request Mar 19, 2024

[HOLD for payment 2024-04-05] [Simplified Collect][Taxes] Android - Workspace - Tax name field isn't auto focused the keyboard isn't visible #38572

Closed

6 tasks

izarutskaya mentioned this pull request Mar 19, 2024

[$250] Settings - Infinite loading on Private section if notification is received #38602

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 19, 2024

[HOLD for payment 2024-03-26] [Simplified Collect][Taxes] Create WorkspaceNewTaxPage #37793

Closed

jayeshmangwani reviewed Jun 6, 2024

View reviewed changes

jayeshmangwani mentioned this pull request Jun 6, 2024

[PAID][$250] Taxes - When creating a Tax, the keyboard does not automatically appear in the "Name" menu #41800

Closed

6 tasks

hungvu193 mentioned this pull request Aug 15, 2024

[HOLD for payment 2024-08-14] [$250] Tax-In tax name field, saving with code does not throw error #45887

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Simplified Collect][Taxes] Creating new taxes #37967

[Simplified Collect][Taxes] Creating new taxes #37967

kosmydel commented Mar 8, 2024 •

edited

Loading

melvin-bot bot commented Mar 8, 2024

DylanDylann commented Mar 18, 2024

mountiny Mar 18, 2024

kosmydel Mar 18, 2024

mountiny Mar 18, 2024

luacmartins Mar 18, 2024

mountiny Mar 18, 2024

DylanDylann commented Mar 18, 2024

DylanDylann commented Mar 18, 2024 •

edited

Loading

luacmartins Mar 18, 2024

melvin-bot bot commented Mar 18, 2024

luacmartins commented Mar 18, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

jayeshmangwani Jun 6, 2024

[Simplified Collect][Taxes] Creating new taxes #37967

[Simplified Collect][Taxes] Creating new taxes #37967

Conversation

kosmydel commented Mar 8, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 8, 2024

DylanDylann commented Mar 18, 2024

mountiny Mar 18, 2024

Choose a reason for hiding this comment

kosmydel Mar 18, 2024

Choose a reason for hiding this comment

mountiny Mar 18, 2024

Choose a reason for hiding this comment

luacmartins Mar 18, 2024

Choose a reason for hiding this comment

mountiny Mar 18, 2024

Choose a reason for hiding this comment

DylanDylann commented Mar 18, 2024

DylanDylann commented Mar 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

luacmartins Mar 18, 2024

Choose a reason for hiding this comment

melvin-bot bot commented Mar 18, 2024

luacmartins commented Mar 18, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 18, 2024

OSBotify commented Mar 19, 2024

jayeshmangwani Jun 6, 2024

Choose a reason for hiding this comment

kosmydel commented Mar 8, 2024 •

edited

Loading

DylanDylann commented Mar 18, 2024 •

edited

Loading