Feature/35716 changing owner flow #37869

burczu · 2024-03-07T08:27:57Z

Details

This PR introduces ability to change ownership of the paid workspace as part of the Simplified collect project.

Fixed Issues

$ #35716
PROPOSAL: n/a

Tests

Log in to the App as an admin of the paid workspace who is not an owner at the same time
Open paid workspace
Go to Members page
Click on the owner of the workspace
Click "Transfer owner"
Follow instructions and check if everything works correctly

Verify that no errors appear in the JS console

Offline tests

Changing ownership is not available in offline mode - check if the "Transfer owner" button is disabled

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-03-25.at.13.01.29.mov

Android: mWeb Chrome

Screen.Recording.2024-03-25.at.12.53.37.mov

iOS: Native

Screen.Recording.2024-03-25.at.12.45.51.mov

iOS: mWeb Safari

Screen.Recording.2024-03-25.at.12.48.50.mov

MacOS: Chrome / Safari

Screen.Recording.2024-03-25.at.12.18.04.mov

MacOS: Desktop

Screen.Recording.2024-03-25.at.12.21.19.mov

luacmartins

Looking better. I left a couple of comments. In addition, we have the following issues:

Unknown error page is not shown. I couldn't get to the unknown error page even when I got a 405 Resource in incorrect state error

error.mov

Stale error shows momentarily when navigating and before loading spinner

staleDataShows.mov

src/libs/WorkspacesSettingsUtils.ts

src/ROUTES.ts

src/pages/workspace/members/WorkspaceOwnerChangeErrorPage.tsx

luacmartins · 2024-03-25T18:14:40Z

It seems like the TS error might be related to cache. I see that we disable the default export error here.

Error: workflow_tests/failureNotifier.test.ts(6,8): error TS1192: Module '"/home/runner/work/App/App/workflow_tests/mocks/failureNotifierMocks"' has no default export.

…ition

burczu · 2024-03-26T10:01:26Z

@luacmartins I've just addressed your last comments including a refactor to handle payment card form inside the common change owner check page. Regarding bugs, you've raised:

Unknown error page is not shown. I couldn't get to the unknown error page even when I got a 405 Resource in incorrect state error

This was because I had to work with mocked API, and my assumption was that I'll get an errorFields object with some unexpected error messages - based on the example you've shown in your comment, it looks like in this case the errorFields object is cleared, so I've change the implementation accordingly and it should (hopefully) work now as expected. Please test it one more time.

Stale error shows momentarily when navigating and before loading spinner

I think I've managed to fix this for the case when we open the modal for the first time (like you've shown in the screen capture video). But there is still a glitch when we switch between errors in the opened modal - in some cases after the loader disappears, we see the previous texts for milliseconds. I didn't find out yet how to fix it, and will continue working on this, but maybe we could try to address it in a follow up issue in the worst case scenario?

burczu · 2024-03-26T10:11:00Z

@shawnborton regarding your comments:

The "Woohoo" area doesn't quite feel vertically centered in the space below the top page header area and the bottom green button. Can you check that out?

It is vertically centered:

The feeling that there is something wrong with the alignment comes from the fact that there is a lot of empty space in the animation/image. I've used existing component for this that we use, e.g., in the enable payment process or in the wallet's transfer balance page.

For these screens:
CleanShot 2024-03-25 at 10 14 08@2x

Can we tighten up the gap between headline and text? Maybe try 8px gap below the headline?

Do you mean the gap between the "Transfer owner" and "Outstanding balance" or between "Outstanding balance" and "The account owning the workspace..." text?

shawnborton · 2024-03-26T13:26:44Z

The feeling that there is something wrong with the alignment comes from the fact that there is a lot of empty space in the animation/image. I've used existing component for this that we use, e.g., in the enable payment process or in the wallet's transfer balance page.

Sounds good, thanks for confirming.

or between "Outstanding balance" and "The account owning the workspace..." text?

This, the headline and the text immediately below it.

burczu · 2024-03-26T13:37:48Z

@shawnborton Thanks for the answer. I've just changed the gap to 8px, as requested - it will look like below:

shawnborton · 2024-03-26T13:56:10Z

Thanks for the answer. I've just changed the gap to 8px, as requested - it will look like below:

Looks good, thanks!

luacmartins

Code LGTM. I'm still seeing a few small things that we need to address, but those can be done in a follow up:

Disable Transfer owner button if user is offline since we can only go through this flow while online.
Wrong error flashes momentarily

error_flash.mov

We're showing an error screen on success after adding a debit card

error_page_on_success.mov

We're showing three decimals for USD currency

luacmartins · 2024-03-26T16:30:20Z

I'll do the checklist on this one since it's hard for C+ to test it because we need the API in certain states to trigger errors.

luacmartins · 2024-03-26T16:30:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

chrome.mov

iOS: Native

ios.mov

iOS: mWeb Safari

safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

OSBotify · 2024-03-26T16:45:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

src/pages/workspace/members/WorkspaceOwnerPaymentCardCurrencyModal.tsx

iwiznia · 2024-05-08T22:23:33Z

src/languages/es.ts

+            failedToClearBalanceTitle: 'Failed to clear balance',
+            failedToClearBalanceButtonText: 'OK',
+            failedToClearBalanceText: 'We were unable to clear the balance. Please try again later.',


How come this is in english? This is against the checklists @burczu @luacmartins

Please send a PR to fix this @burczu

Damn, I thought we had updated all of them, but clearly we missed some. I'll put up a PR to fix it. Thanks for raising this.

shubham1206agra · 2024-09-25T09:27:32Z

src/pages/workspace/members/WorkspaceOwnerPaymentCardCurrencyModal.tsx

+            onClose={() => onClose?.()}
+            onModalHide={onClose}
+            hideModalContentWhileAnimating
+            useNativeDriver


We forgot to add onBackdropPress here which is causing inconsistency in the flow. More details #47559

burczu force-pushed the feature/35716-changing-owner-flow branch from 2660d0c to 2124c90 Compare March 7, 2024 09:29

burczu added 2 commits March 8, 2024 07:28

is selectable item property introduced

c49ce33

showing disable icon when item is not selectable

2d361a8

burczu force-pushed the feature/35716-changing-owner-flow branch from e14442c to 2d361a8 Compare March 8, 2024 06:28

burczu added 26 commits March 8, 2024 13:06

showing transfer owner button for owners opened by other admins

8d92c5e

variable names refactor

ad761d0

constraint removed

96ade46

fixed constraints for an owner

d1b40ae

Merge branch 'main' into feature/35716-changing-owner-flow

93824ea

more constraints for current user added

d6dfe23

disabling transfer owner button when offline

57a0005

policy ownership checks Onyx key added

76ee2fc

update workspace ownership checks method added

2fe5c59

request workspace owner change method added

af07439

start change ownership flow method implemented

d16237e

workspace owner change check page added

974ad2e

temporary solution to open owner check confiration page

7e44edb

transfer balance confirmation copy handled

2e4c65f

temporary copy added

1fb509f

showing correct owner change check page version based on error type

20973cb

Merge branch 'main' into feature/35716-changing-owner-flow

09a9b84

new owner payment card form page added

dddff34

translation key fix

992c75b

foundation of the add payment card form added (not finished yet))

de5f717

unnecessary imports removed

0cd911d

Merge branch 'main' into feature/35716-changing-owner-flow

6d78c50

add payment card in ownership change flow design adjusted

2608d6e

form validation added

74ab683

add billing card and request workspace owner change api method added

00fd922

Merge branch 'main' into feature/35716-changing-owner-flow

91f5458

luacmartins requested changes Mar 25, 2024

View reviewed changes

src/libs/WorkspacesSettingsUtils.ts Outdated Show resolved Hide resolved

src/ROUTES.ts Outdated Show resolved Hide resolved

src/pages/workspace/members/WorkspaceOwnerChangeErrorPage.tsx Outdated Show resolved Hide resolved

burczu added 5 commits March 26, 2024 09:07

unexpected errors handling fixed

d74a70e

using currency utils to format amount

a32a620

missing translations added

291fec5

refactor: payment form and check page unified

4844b40

handling transition end to prevent showing stale error on first trans…

d862bb6

…ition

burczu added 2 commits March 26, 2024 14:39

styles adjustment

0730d0f

Merge branch 'main' into feature/35716-changing-owner-flow

c809723

luacmartins approved these changes Mar 26, 2024

View reviewed changes

luacmartins merged commit 0702d16 into Expensify:main Mar 26, 2024
15 checks passed

luacmartins mentioned this pull request Mar 26, 2024

[HOLD for payment 2024-04-09] [Simplified Collect][Members] Polish items for Transfer owner flow #39005

Closed

github-actions bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

shubham1206agra reviewed Mar 27, 2024

View reviewed changes

src/pages/workspace/members/WorkspaceOwnerPaymentCardCurrencyModal.tsx Show resolved Hide resolved

ZhenjaHorbach mentioned this pull request Mar 27, 2024

[HOLD for payment 2024-04-09] [$50] [Simplified Collect][Members] Transfer owner - Typing error in "You're now the owner if this workspace" #39055

Closed

6 tasks

nkuoch mentioned this pull request Mar 27, 2024

[HOLD for payment 2024-04-15] [Simplified Collect][Members] Members list does not update to show the new admin and owner #39057

Closed

6 tasks

melvin-bot bot mentioned this pull request Mar 29, 2024

[HOLD for payment 2024-04-05] [$500] [Simplified Collect][Members] Changing owner: Full flow implementation #35716

Closed

iwiznia reviewed May 8, 2024

View reviewed changes

luacmartins mentioned this pull request May 9, 2024

Update failed to clear balance Spanish copy #41929

Merged

50 tasks

c3024 mentioned this pull request Jul 17, 2024

[HOLD for payment 2024-07-17] [$250] IOS - Transfer owner - App returns to empty screen when swiping right on success screen #44506

Closed

6 tasks

shubham1206agra reviewed Sep 25, 2024

View reviewed changes

shubham1206agra mentioned this pull request Sep 25, 2024

[HOLD for payment 2024-09-09] [$250] Subscription - Clicking Outside the Modal Doesn't Close It, Causing Inconsistency #47559

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/35716 changing owner flow #37869

Feature/35716 changing owner flow #37869

burczu commented Mar 7, 2024 •

edited

Loading

luacmartins left a comment

luacmartins commented Mar 25, 2024

burczu commented Mar 26, 2024 •

edited

Loading

burczu commented Mar 26, 2024

shawnborton commented Mar 26, 2024

burczu commented Mar 26, 2024

shawnborton commented Mar 26, 2024

luacmartins left a comment

luacmartins commented Mar 26, 2024

luacmartins commented Mar 26, 2024 •

edited

Loading

OSBotify commented Mar 26, 2024

iwiznia May 8, 2024 •

edited

Loading

luacmartins May 9, 2024

shubham1206agra Sep 25, 2024

Feature/35716 changing owner flow #37869

Feature/35716 changing owner flow #37869

Conversation

burczu commented Mar 7, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Mar 25, 2024

burczu commented Mar 26, 2024 • edited Loading

burczu commented Mar 26, 2024

shawnborton commented Mar 26, 2024

burczu commented Mar 26, 2024

shawnborton commented Mar 26, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Mar 26, 2024

luacmartins commented Mar 26, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Mar 26, 2024

iwiznia May 8, 2024 • edited Loading

Choose a reason for hiding this comment

luacmartins May 9, 2024

Choose a reason for hiding this comment

shubham1206agra Sep 25, 2024

Choose a reason for hiding this comment

burczu commented Mar 7, 2024 •

edited

Loading

burczu commented Mar 26, 2024 •

edited

Loading

luacmartins commented Mar 26, 2024 •

edited

Loading

iwiznia May 8, 2024 •

edited

Loading