[No QA][TS migration] Migrate multiple unit and Performance test to Typescript #37685

ruben-rebelo · 2024-03-04T16:19:22Z

Details

[TS migration] Migrate MiddlewareTest, markPullRequestAsDeployedTest, ReportactionsList.perf-test, ReportActionCompose-perf-test and ReportScreen-perf-test to Typescript

Fixed Issues

$ #32031
$ #32032
$ #32033
$ #32034
$ #32035
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console
Run Unit test works as before
Run Performance tests works as before

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/a

Android: mWeb Chrome

N/a

iOS: Native

N/a

iOS: mWeb Safari

N/a

MacOS: Chrome / Safari

N/a

MacOS: Desktop

N/a

… ReportactionsList.perf-test, ReportActionCompose-perf-test and ReportScreen-perf-test

fabioh8010 · 2024-03-05T11:51:36Z

tests/perf-test/ReportActionCompose.perf-test.tsx

+jest.mock('@src/components/withNavigationFocus', () => (Component: ComponentType<WithNavigationFocusProps>) => {
+    function WithNavigationFocus(props: WithNavigationFocusProps) {


Suggested change

jest.mock('@src/components/withNavigationFocus', () => (Component: ComponentType<WithNavigationFocusProps>) => {

function WithNavigationFocus(props: WithNavigationFocusProps) {

jest.mock('@src/components/withNavigationFocus', <TProps extends WithNavigationFocusProps>() => (Component: ComponentType<TProps>) => {

function WithNavigationFocus(props: Omit<TProps, keyof WithNavigationFocusProps>) {

Also, update {...props} to be {...(props as TProps)}

fabioh8010 · 2024-03-05T11:52:06Z

tests/perf-test/ReportActionCompose.perf-test.tsx

@@ -87,6 +95,8 @@ function ReportActionComposeWrapper() {
                reportID="1"
                disabled={false}
                report={LHNTestUtils.getFakeReport()}
+                isComposerFullSize
+                listHeight={200}


Just curious, why 200?

It was a random value as it is not important for the test.

fabioh8010 · 2024-03-05T11:52:23Z

tests/perf-test/ReportActionsList.perf-test.tsx

+jest.mock('@src/components/withNavigationFocus', () => (Component: ComponentType<WithNavigationFocusProps>) => {
+    function WithNavigationFocus(props: WithNavigationFocusProps) {


fabioh8010 · 2024-03-05T11:52:47Z

tests/perf-test/ReportScreen.perf-test.tsx

+jest.mock('@src/components/withNavigationFocus', () => (Component: ComponentType<WithNavigationFocusProps>) => {
+    function WithNavigationFocus(props: WithNavigationFocusProps) {


fabioh8010 · 2024-03-05T11:55:10Z

tests/perf-test/ReportScreen.perf-test.tsx

    }),
 );

 // Initialize the network key for OfflineWithFeedback
 beforeEach(() => {
-    global.fetch = TestHelper.getGlobalFetchMock();
+    global.fetch = TestHelper.getGlobalFetchMock() as typeof fetch;


Suggested change

global.fetch = TestHelper.getGlobalFetchMock() as typeof fetch;

// @ts-expect-error TODO: Remove this once TestHelper (https://github.com/Expensify/App/issues/25318) is migrated to TypeScript.

global.fetch = TestHelper.getGlobalFetchMock();

It would be better to just suppress the error and comment that we need to remove the comment once TestUtils is migrated

fabioh8010 · 2024-03-05T11:56:04Z

tests/perf-test/ReportScreen.perf-test.tsx

@@ -136,6 +149,7 @@ function ReportScreenWrapper(args) {
            <ReportScreen
                // eslint-disable-next-line react/jsx-props-no-spreading
                {...args}
+                // @ts-expect-error TODO: Remove this once ReportScreen is migrated to TypeScript.


Please link the issue

fabioh8010 · 2024-03-05T11:56:12Z

tests/perf-test/ReportScreen.perf-test.tsx

@@ -245,6 +262,7 @@ test('[ReportScreen] should press of the report item', () => {
        .then(() =>
            measurePerformance(
                <ReportScreenWrapper
+                    // @ts-expect-error TODO: Remove this once ReportScreen is migrated to TypeScript.


fabioh8010 · 2024-03-05T11:56:19Z

tests/unit/MiddlewareTest.ts

@@ -13,7 +14,7 @@ Onyx.init({
 });

 beforeAll(() => {
-    global.fetch = TestHelper.getGlobalFetchMock();
+    global.fetch = TestHelper.getGlobalFetchMock() as typeof fetch;


fabioh8010 · 2024-03-05T11:56:48Z

tests/unit/MiddlewareTest.ts

@@ -29,8 +30,6 @@ beforeEach(async () => {
 describe('Middleware', () => {
    describe('HandleUnusedOptimisticID', () => {
        test('Normal request', async () => {
-            const actual = jest.requireActual('../../src/libs/Middleware/HandleUnusedOptimisticID');


Why was this removed?

This was removed because in this specific case there is no need for a spyon, using the actual function works as expected, what is needed is using mockImplementation for global.fetch as this is the one we use for checking if the information/number of calls were correct.
Test is working as expected.

fabioh8010 · 2024-03-05T11:56:52Z

tests/unit/MiddlewareTest.ts

        });

        test('Request with preexistingReportID', async () => {
-            const actual = jest.requireActual('../../src/libs/Middleware/HandleUnusedOptimisticID');


Why was this removed?

Same as before

VickyStash · 2024-03-08T09:53:41Z

tests/perf-test/ReportScreen.perf-test.tsx

@@ -245,6 +263,7 @@ test('[ReportScreen] should press of the report item', () => {
        .then(() =>
            measurePerformance(
                <ReportScreenWrapper
+                    // @ts-expect-error TODO: Remove this once ReportScreen is migrated to TypeScript.


Let's add a link as well

Suggested change

// @ts-expect-error TODO: Remove this once ReportScreen is migrated to TypeScript.

// @ts-expect-error TODO: Remove this once ReportScreen (https://github.com/Expensify/App/issues/25216) is migrated to TypeScript.

VickyStash · 2024-03-08T10:05:35Z

tests/unit/markPullRequestsAsDeployedTest.ts

- * @returns {Promise<{data: {message: String}}>}
- */
-async function mockGetCommitDefaultImplementation({commit_sha}) {
+function mockGetCommitDefaultImplementation({commit_sha}: {commit_sha: string}): {data: {message: string}} {


Let's create types for {commit_sha: string} and {data: {message: string}} to improve readability

VickyStash · 2024-03-08T10:06:36Z

tests/unit/markPullRequestsAsDeployedTest.ts

    workflowRunURL = `${process.env.GITHUB_SERVER_URL}/${process.env.GITHUB_REPOSITORY}/actions/runs/${process.env.GITHUB_RUN_ID}`;
 });

 beforeEach(() => {
-    mockGetPullRequest.mockImplementation(async ({pull_number}) => (pull_number in PRList ? {data: PRList[pull_number]} : {}));
+    mockGetPullRequest.mockImplementation(({pull_number}: {pull_number: number}) => (pull_number in PRList ? {data: PRList[pull_number]} : {}));


Same, please put {pull_number: number} into type, and add return type as well

VickyStash · 2024-03-08T10:07:38Z

tests/unit/markPullRequestsAsDeployedTest.ts

@@ -209,7 +217,7 @@ platform | result
            }
            return mockGetInputDefaultImplementation(key);
        });
-        mockGetPullRequest.mockImplementation(async ({pull_number}) => {
+        mockGetPullRequest.mockImplementation(({pull_number}) => {


You can then reuse created type to type this function props

VickyStash · 2024-03-08T10:07:49Z

tests/unit/markPullRequestsAsDeployedTest.ts

@@ -226,7 +234,7 @@ platform | result
        mockListTags.mockResolvedValue({
            data: [{name: '42.42.42-43', commit: {sha: 'xyz'}}, ...defaultTags],
        });
-        mockGetCommit.mockImplementation(async ({commit_sha}) => {
+        mockGetCommit.mockImplementation(({commit_sha}) => {


Same, you can then reuse created type to type this function props

# Conflicts: # tests/perf-test/ReportActionsList.perf-test.tsx

blazejkustra · 2024-03-11T15:08:26Z

src/components/DragAndDrop/Provider/types.ts

@@ -8,7 +8,7 @@ type DragAndDropProviderProps = {
    isDisabled?: boolean;

    /** Indicate that users are dragging file or not */
-    setIsDraggingOver: (value: boolean) => void;
+    setIsDraggingOver?: (value: boolean) => void;


Are you sure this should be optional?

Yes, @VickyStash explained the reason here: #37820 (comment)

This reverts commit bdd24df.

melvin-bot · 2024-03-12T10:24:50Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2024-03-12T10:26:12Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #32031 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

hungvu193 · 2024-03-18T03:28:28Z

Lint is falling @ruben-rebelo.

Hey @nkuoch, this one need your approval, let me know if you need me to complete the checklist.

nkuoch · 2024-03-18T13:59:56Z

Yes please complete the checklist @hungvu193 once lint failures are fixed

hungvu193 · 2024-03-19T06:58:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

N/A

MacOS: Desktop

N/A

blazejkustra · 2024-03-19T07:18:31Z

@ruben-rebelo Typecheck is failing

fabioh8010 · 2024-03-19T12:38:40Z

@ruben-rebelo is OOO and will return on March 21.

# Conflicts: # tests/unit/MiddlewareTest.ts

fabioh8010 · 2024-03-22T06:58:41Z

@ruben-rebelo TS checks are still failing here 👀

hungvu193 · 2024-03-22T10:08:02Z

@ruben-rebelo lint is still failing, please fix it. Thank you 😃

hungvu193 · 2024-03-22T12:14:21Z

Checklist completed. Perf test is failing on main, it doesn't relate to this PR .All yours @nkuoch

roryabraham · 2024-03-23T08:30:25Z

Reassure was fixed on main but since the failing test is changed in this PR let's merge main into this branch and make sure it passes

tests/perf-test/ReportActionsList.perf-test.tsx

Co-authored-by: Fábio Henriques <[email protected]>

melvin-bot · 2024-03-25T19:38:23Z

@roryabraham looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-03-25T19:44:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

nkuoch · 2024-04-01T08:18:02Z

Removing emergency label. Tests passed

ruben-rebelo added 2 commits March 4, 2024 16:17

[TS migration] Migrate MiddlewareTest, markPullRequestAsDeployedTest,…

95ab23d

… ReportactionsList.perf-test, ReportActionCompose-perf-test and ReportScreen-perf-test

[TS migration][G11] Added missing files

387b9b2

ruben-rebelo changed the title ~~[TS migration] Migrate multiple unit and Performance test to Typescript~~ [No QA][TS migration] Migrate multiple unit and Performance test to Typescript Mar 4, 2024

fabioh8010 reviewed Mar 5, 2024

View reviewed changes

[TS migration][G11] Feedback

6244e2e

fabioh8010 approved these changes Mar 8, 2024

View reviewed changes

VickyStash reviewed Mar 8, 2024

View reviewed changes

[TS migration][G11] Feedback

ccc3f56

VickyStash approved these changes Mar 8, 2024

View reviewed changes

ruben-rebelo added 2 commits March 8, 2024 14:43

Merge branch 'main' into ts-migration/group-11

fd6a848

# Conflicts: # tests/perf-test/ReportActionsList.perf-test.tsx

[TS migration][G11] TS issue fix

453a287

blazejkustra approved these changes Mar 11, 2024

View reviewed changes

ruben-rebelo added 2 commits March 12, 2024 10:07

[TS migration][g11] Fixed type of drag and drop

bdd24df

Revert "[TS migration][g11] Fixed type of drag and drop"

4fb5eae

This reverts commit bdd24df.

ruben-rebelo marked this pull request as ready for review March 12, 2024 10:24

ruben-rebelo requested a review from a team as a code owner March 12, 2024 10:24

melvin-bot bot removed the request for review from a team March 12, 2024 10:24

melvin-bot bot requested a review from hungvu193 March 12, 2024 10:24

hungvu193 approved these changes Mar 12, 2024

View reviewed changes

melvin-bot bot requested a review from nkuoch March 12, 2024 10:26

nkuoch previously approved these changes Mar 18, 2024

View reviewed changes

Merge branch 'main' into ts-migration/group-11

d6f274e

# Conflicts: # tests/unit/MiddlewareTest.ts

ruben-rebelo dismissed nkuoch’s stale review via d6f274e March 21, 2024 12:54

[TS migration][g11] Lint fix

1914e12

ruben-rebelo added 2 commits March 22, 2024 10:11

[TS migration][G11] Lint

d5e285c

Merge branch 'main' into ts-migration/group-11

f4cb0bf

roryabraham previously approved these changes Mar 23, 2024

View reviewed changes

Merge branch 'main' into ts-migration/group-11

4302623

fabioh8010 reviewed Mar 25, 2024

View reviewed changes

tests/perf-test/ReportActionsList.perf-test.tsx Outdated Show resolved Hide resolved

ruben-rebelo dismissed roryabraham’s stale review via 95164d7 March 25, 2024 17:38

Update ReportActionsList.perf-test.tsx

95164d7

Co-authored-by: Fábio Henriques <[email protected]>

roryabraham approved these changes Mar 25, 2024

View reviewed changes

roryabraham merged commit fe0699c into Expensify:main Mar 25, 2024
16 checks passed

melvin-bot bot added the Emergency label Mar 25, 2024

github-actions bot mentioned this pull request Mar 27, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

nkuoch removed the Emergency label Apr 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA][TS migration] Migrate multiple unit and Performance test to Typescript #37685

[No QA][TS migration] Migrate multiple unit and Performance test to Typescript #37685

ruben-rebelo commented Mar 4, 2024

fabioh8010 Mar 5, 2024

fabioh8010 Mar 5, 2024

ruben-rebelo Mar 6, 2024

fabioh8010 Mar 5, 2024

fabioh8010 Mar 5, 2024

fabioh8010 Mar 5, 2024

fabioh8010 Mar 5, 2024

fabioh8010 Mar 5, 2024

fabioh8010 Mar 5, 2024

fabioh8010 Mar 5, 2024

ruben-rebelo Mar 6, 2024

fabioh8010 Mar 5, 2024

ruben-rebelo Mar 6, 2024

VickyStash Mar 8, 2024

VickyStash Mar 8, 2024

VickyStash Mar 8, 2024

VickyStash Mar 8, 2024

VickyStash Mar 8, 2024

blazejkustra Mar 11, 2024

ruben-rebelo Mar 12, 2024

melvin-bot bot commented Mar 12, 2024

melvin-bot bot commented Mar 12, 2024

hungvu193 commented Mar 18, 2024

nkuoch commented Mar 18, 2024

hungvu193 commented Mar 19, 2024 •

edited

Loading

blazejkustra commented Mar 19, 2024

fabioh8010 commented Mar 19, 2024

fabioh8010 commented Mar 22, 2024

hungvu193 commented Mar 22, 2024

hungvu193 commented Mar 22, 2024

roryabraham commented Mar 23, 2024

melvin-bot bot commented Mar 25, 2024

OSBotify commented Mar 25, 2024

nkuoch commented Apr 1, 2024

		jest.mock('@src/components/withNavigationFocus', () => (Component: ComponentType<WithNavigationFocusProps>) => {
		function WithNavigationFocus(props: WithNavigationFocusProps) {

	global.fetch = TestHelper.getGlobalFetchMock() as typeof fetch;
	// @ts-expect-error TODO: Remove this once TestHelper (https://github.com/Expensify/App/issues/25318) is migrated to TypeScript.
	global.fetch = TestHelper.getGlobalFetchMock();

[No QA][TS migration] Migrate multiple unit and Performance test to Typescript #37685

[No QA][TS migration] Migrate multiple unit and Performance test to Typescript #37685

Conversation

ruben-rebelo commented Mar 4, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 12, 2024

melvin-bot bot commented Mar 12, 2024

hungvu193 commented Mar 18, 2024

nkuoch commented Mar 18, 2024

hungvu193 commented Mar 19, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

blazejkustra commented Mar 19, 2024

fabioh8010 commented Mar 19, 2024

fabioh8010 commented Mar 22, 2024

hungvu193 commented Mar 22, 2024

hungvu193 commented Mar 22, 2024

roryabraham commented Mar 23, 2024

melvin-bot bot commented Mar 25, 2024

OSBotify commented Mar 25, 2024

nkuoch commented Apr 1, 2024

hungvu193 commented Mar 19, 2024 •

edited

Loading