Fix sharing video player from chat to attachment modal #37202

Skalakid · 2024-02-26T14:04:46Z

Details

The PR fixes video player sharing between elements and screen.

Fixed Issues

$ #36873 (comment)
PROPOSAL:

Tests

Go to prerequisite chat
Play&Pause the video
Tap on the expand button on the video preview
Verify if video player showed there have the same state as the on from chat
Play&Pause the video
Exit from the attachment view via clicking X button top right
Try to Play&Pause the video in preview mode

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/A

Android: mWeb Chrome

N/A

iOS: Native

N/A

iOS: mWeb Safari

N/A

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2024-02-26T14:04:51Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-02-26T14:11:12Z

I can take a look in 1-2 hour 👀

ishpaul777 · 2024-02-26T16:43:59Z

@Skalakid Can you please help me understand the root cause and how these code changes solve the problem, this will be really helpful while reviewing :D

ishpaul777 · 2024-02-26T17:03:21Z

src/components/VideoPlayer/BaseVideoPlayer.js

+            const currentDuration = e.durationMillis || videoDuration * 1000;
+            const currentPositon = e.positionMillis || 0;
+
+            if (shouldReplayVideo(e, isVideoPlaying, currentDuration, currentPositon)) {


Not a bug but can we consider moving shouldReplayVideo utility to libs directory?

ishpaul777 · 2024-02-26T17:25:39Z

looks like clicking on the video does not play/pause the video

Screen.Recording.2024-02-26.at.10.53.43.PM.mov

Skalakid · 2024-02-26T17:34:04Z

@ishpaul777 no problem. Here is an explanation. We wanted to optimize video player loading when switching from an in-chat player to an attachment carousel. So we implemented video element sharing, so we can use exactly the same element both in chat and in the attachment modal. This feature is only available on large-screen devices.
Unfortunately, someone, somewhere removed isUsedInCarousel probably when merging with the main, so shouldUseSharedVideoElement was always set to false and the sharing wasn't working.
Also, changes that were made inside bindFunctions function were causing infinite rerenders when we turned video sharing back on. So I fixed bindFunctions function to use video properties from event instead of the state.

Buttons don't work when exiting the attachment modal because sharing wasn't fully made and we didn't bind the functions after exiting the attachment carousel. By fixing video player sharing bot players are always synchronized and functions are properly binded

ishpaul777 · 2024-02-26T17:51:04Z

Thanks for explaination @Skalakid, changes start to make sense 👌

looks like you are looking into #37202 (comment), please feel free to ping me and share your findings i'll be around 😄

Skalakid · 2024-02-27T09:10:12Z

@ishpaul777 Good catch, I forgot that we can pause video by clicking on it 😅 I've just added the fix for it

ishpaul777 · 2024-02-27T16:06:45Z

reviewing 👀

ishpaul777 · 2024-02-27T16:25:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-02-27.at.11.42.47.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-02-27.at.11.35.05.PM.mov

iOS: Native

Screen.Recording.2024-02-28.at.12.07.20.AM.mov

iOS: mWeb Safari

Screen.Recording.2024-02-28.at.12.13.22.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-02-27.at.11.17.46.PM.mov

MacOS: Desktop

Screen.Recording.2024-02-28.at.12.22.28.AM.mov

ishpaul777 · 2024-02-27T16:46:06Z

Another bug:

The play and pause not works when the we naviagate from other carousel item.

Step to repro:

upload 2 video A and B
start playing video a and then pause in between
start playing video B and open in attachement modal, navigate to the Video A attachment modal

Expected result:
Video A can be play and pause

Actual Result:
Video A play and pause broken 😞

Screen.Recording.2024-02-27.at.10.04.28.PM.mov

ishpaul777 · 2024-02-27T19:01:59Z

Just tested again the above 👆 not able to reproduce so i wont block this for a bug i am not able to reproduce consistently but its worth a investigation if you are able to reproduce @Skalakid

Screen.Recording.2024-02-27.at.11.17.46.PM.mov

Skalakid · 2024-02-28T08:57:38Z

@ishpaul777 I can't reproduce it either, but I will look into this and if there is need I will fix it in another PR

Skalakid · 2024-02-29T13:36:51Z

@ishpaul777 Do you approve this PR, so we can merge it or should I add something to it?

ishpaul777 · 2024-02-29T13:42:31Z

I can't reproduce it either, but I will look into this

Ah i thought you were investigating for the bug above mentioned. I'll approve as soon as i am with my laptop (1-2 hours) just want to test one last time again before approving.

lakchote · 2024-03-01T15:12:33Z

I couldn't reproduce either @ishpaul777.

We should still keep this in mind if the problem arises @Skalakid

OSBotify · 2024-03-01T15:47:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-03-04T21:04:05Z

🚀 Deployed to staging by https://github.com/lakchote in version: 1.4.47-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pecanoro · 2024-03-05T18:13:05Z

src/components/Attachments/AttachmentCarousel/CarouselItem.js

@@ -108,6 +108,7 @@ function CarouselItem({item, onPress, isFocused, isModalHovered}) {
                    isHovered={isModalHovered}
                    isFocused={isFocused}
                    optionalVideoDuration={item.duration}
+                    isUsedInCarousel


This caused this a regression here: #37750

OSBotify · 2024-03-06T21:53:07Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.4.47-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mananjadhav · 2024-04-15T16:24:25Z

src/components/VideoPlayer/BaseVideoPlayer.js

+            const currentDuration = e.durationMillis || videoDuration * 1000;
+            const currentPositon = e.positionMillis || 0;
+
+            if (shouldReplayVideo(e, isVideoPlaying, currentDuration, currentPositon)) {


This change of replacing isPlaying caused a bug #37249

Fix sharing video player from chat to attachment modal

b08fbc9

Skalakid requested a review from a team as a code owner February 26, 2024 14:04

melvin-bot bot requested review from ishpaul777 and removed request for a team February 26, 2024 14:04

Remove Podfile.lock changes

344a2de

Skalakid mentioned this pull request Feb 26, 2024

[$500] Chat - The video is reloaded every time you open it #37168

Closed

6 tasks

ishpaul777 reviewed Feb 26, 2024

View reviewed changes

Fix touchable video area

81ff827

ishpaul777 approved these changes Mar 1, 2024

View reviewed changes

melvin-bot bot requested a review from lakchote March 1, 2024 12:19

lakchote approved these changes Mar 1, 2024

View reviewed changes

lakchote merged commit 5d2933d into Expensify:main Mar 1, 2024
16 checks passed

Skalakid mentioned this pull request Mar 4, 2024

[HOLD for payment 2024-04-09] [HOLD for payment 2024-03-13] [$500] Video - Play&Pause buttons don't function in preview mode if expanded the video before #36873

Closed

6 tasks

github-actions bot mentioned this pull request Mar 4, 2024

Deploy Checklist: New Expensify 2024-03-04 #37698

Closed

97 tasks

aimane-chnaif mentioned this pull request Mar 5, 2024

[HOLD for payment 2024-03-14] [$500] Video - App crashes when opening video in full screen while it is still loading #37710

Closed

6 tasks

pecanoro reviewed Mar 5, 2024

View reviewed changes

This was referenced Mar 5, 2024

[HOLD for payment 2024-03-14] Video - Unable to expand video from video preview modal #37750

Closed

Fix crash when expanding video player #37772

Merged

DylanDylann mentioned this pull request Mar 6, 2024

Fix: Attachment - Navigation arrows not disabled and PDF cannot be scrolled while zoomed in #36921

Closed

50 tasks

tienifr mentioned this pull request Mar 6, 2024

[$500] Attachment - Navigation arrows not disabled and PDF can be swiped while zoomed in #36634

Closed

6 tasks

mananjadhav reviewed Apr 15, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sharing video player from chat to attachment modal #37202

Fix sharing video player from chat to attachment modal #37202

Skalakid commented Feb 26, 2024

melvin-bot bot commented Feb 26, 2024

ishpaul777 commented Feb 26, 2024

ishpaul777 commented Feb 26, 2024 •

edited

Loading

ishpaul777 Feb 26, 2024 •

edited

Loading

ishpaul777 commented Feb 26, 2024

Skalakid commented Feb 26, 2024

ishpaul777 commented Feb 26, 2024

Skalakid commented Feb 27, 2024

ishpaul777 commented Feb 27, 2024

ishpaul777 commented Feb 27, 2024 •

edited

Loading

ishpaul777 commented Feb 27, 2024

ishpaul777 commented Feb 27, 2024 •

edited

Loading

Skalakid commented Feb 28, 2024

Skalakid commented Feb 29, 2024

ishpaul777 commented Feb 29, 2024

lakchote commented Mar 1, 2024

OSBotify commented Mar 1, 2024

OSBotify commented Mar 4, 2024

pecanoro Mar 5, 2024

OSBotify commented Mar 6, 2024

mananjadhav Apr 15, 2024

Fix sharing video player from chat to attachment modal #37202

Fix sharing video player from chat to attachment modal #37202

Conversation

Skalakid commented Feb 26, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 26, 2024

ishpaul777 commented Feb 26, 2024

ishpaul777 commented Feb 26, 2024 • edited Loading

ishpaul777 Feb 26, 2024 • edited Loading

Choose a reason for hiding this comment

ishpaul777 commented Feb 26, 2024

Skalakid commented Feb 26, 2024

ishpaul777 commented Feb 26, 2024

Skalakid commented Feb 27, 2024

ishpaul777 commented Feb 27, 2024

ishpaul777 commented Feb 27, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Feb 27, 2024

Another bug:

ishpaul777 commented Feb 27, 2024 • edited Loading

Skalakid commented Feb 28, 2024

Skalakid commented Feb 29, 2024

ishpaul777 commented Feb 29, 2024

lakchote commented Mar 1, 2024

OSBotify commented Mar 1, 2024

OSBotify commented Mar 4, 2024

pecanoro Mar 5, 2024

Choose a reason for hiding this comment

OSBotify commented Mar 6, 2024

mananjadhav Apr 15, 2024

Choose a reason for hiding this comment

ishpaul777 commented Feb 26, 2024 •

edited

Loading

ishpaul777 Feb 26, 2024 •

edited

Loading

ishpaul777 commented Feb 27, 2024 •

edited

Loading

ishpaul777 commented Feb 27, 2024 •

edited

Loading