Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Fix TS fail #37169

Closed
wants to merge 4 commits into from
Closed

[No QA] Fix TS fail #37169

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfe2cdf
fix ts fail
DylanDylann Feb 24, 2024
c4441f0
fix ts fail
DylanDylann Feb 24, 2024
b994ebb
fix ts fail
DylanDylann Feb 24, 2024
828113f
import type
DylanDylann Feb 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/e2e/utils/killApp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,11 @@
import config from '../config';
import execAsync from './execAsync';

const killApp = function (platform = 'android', packageName = config.MAIN_APP_PACKAGE): Promise<void> {
type PromiseWithAbort = Promise<string | void> & {
abort?: () => void;
};

const killApp = function (platform = 'android', packageName = config.MAIN_APP_PACKAGE): PromiseWithAbort {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this function return execAsync(adb shell am force-stop ${packageName});

App/tests/e2e/utils/execAsync.ts

Line 5 in e9fb49d

type PromiseWithAbort = Promise<string | void> & {

should use the same type

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we export PromiseWithAbort type from above file and use here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

if (platform !== 'android') {
throw new Error(`killApp() missing implementation for platform: ${platform}`);
}
Expand Down
Loading