Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Chat - Font size is smaller in single backtick code block. #36568

Merged
merged 2 commits into from
Feb 20, 2024
Merged

fix: Chat - Font size is smaller in single backtick code block. #36568

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd3b738
fix: Chat - Font size is smaller in single backtick code block.
Krishna2323 Feb 15, 2024
20bd606
Merge branch 'Expensify:main' into krishna2323/issue/35746
Krishna2323 Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/styles/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,10 +179,9 @@ const webViewStyles = (theme: ThemeColors) =>

pre: {
...baseCodeTagStyles(theme),
paddingTop: 12,
paddingBottom: 12,
paddingRight: 8,
paddingLeft: 8,
paddingVertical: 8,
paddingHorizontal: 12,
fontSize: 13,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Krishna2323 Can we define the numeral in variable and use it as fontSize. If you check other fontSize in the file, we are using variable instead of a numeral.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sobitneupane, I think 13 isn't a number that we want to add in variables , we are using it as numeral in multiple places.

App/src/styles/index.ts

Line 2621 in ead7e44

fontSize: 13,

App/src/styles/index.ts

Line 3288 in ead7e44

fontSize: 13,

App/src/styles/index.ts

Line 3523 in ead7e44

fontSize: 13,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB: But I would have preferred it as a variable.

fontFamily: FontUtils.fontFamily.platform.MONOSPACE,
marginTop: 0,
marginBottom: 0,
Expand Down
Loading