[TS migration] Migrate 'AvatarWithImagePicker.js' component to TypeSc… #35847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasyukevich
force-pushed
the
feature/ts-migrate-AvatarWithImagePicker
branch
2 times, most recently
from
685e4f7
to
059ea8b
Compare
VickyStash
reviewed
Feb 6, 2024
Comment on lines
+30
to
+33
| type ErrorData = { | ||
| validationError?: TranslationPaths | null | ''; | ||
| phraseParam: Record<string, unknown>; | ||
| }; |
There was a problem hiding this comment.
Maybe we can make ErrorData type more specific, up to you...
Suggested change
| type ErrorData = { | |
| validationError?: TranslationPaths | null | ''; | |
| phraseParam: Record<string, unknown>; | |
| }; | |
| type PhraseParam<TKey extends TranslationPaths> = PhraseParameters<Phrase<TKey>>[0]; | |
| type ErrorData<TKey extends TranslationPaths | null = null> = { | |
| validationError: TKey; | |
| phraseParam: TKey extends TranslationPaths ? PhraseParam<TKey> : EmptyObject; | |
| }; |
There was a problem hiding this comment.
I think that in this case it will be overcomplicated and better to keep simplicity here
pasyukevich
force-pushed
the
feature/ts-migrate-AvatarWithImagePicker
branch
from
059ea8b
to
80fc188
Compare
kubabutkiewicz
approved these changes
Feb 12, 2024
pasyukevich
force-pushed
the
feature/ts-migrate-AvatarWithImagePicker
branch
from
5d81b29
to
80fc188
Compare
Reviewer Checklist
Screenshots/VideosAndroid: Native35847.Android.mp4Android: mWeb Chrome35847.mWeb-Chrome.mp4iOS: Native35847.iOS.mp4iOS: mWeb Safari35847.mWeb-Safari.mp4MacOS: Chrome / Safari35847.Web.-.Profile.mp435847.Web.-.Workspace.mp4MacOS: Desktop35847.Desktop.mp4 |
mollfpr
approved these changes
Feb 23, 2024
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25122 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
roryabraham
approved these changes
Feb 25, 2024
| return _.contains(CONST.AVATAR_ALLOWED_EXTENSIONS, fileExtension.toLowerCase()); | ||
| const isValidExtension = (image: File): boolean => { | ||
| const {fileExtension} = FileUtils.splitExtensionFromFileName(image?.name ?? ''); | ||
| return CONST.AVATAR_ALLOWED_EXTENSIONS.some((extension) => extension === fileExtension.toLowerCase()); |
There was a problem hiding this comment.
NAB:
Suggested change
| return CONST.AVATAR_ALLOWED_EXTENSIONS.some((extension) => extension === fileExtension.toLowerCase()); | |
| return CONST.AVATAR_ALLOWED_EXTENSIONS.includes(fileExtension.toLowerCase()); |
| @@ -432,7 +397,8 @@ function AvatarWithImagePicker({ | |||
| {errorData.validationError && ( | |||
| <DotIndicatorMessage | |||
| style={[styles.mt6]} | |||
| messages={{0: [errorData.validationError, errorData.phraseParam]}} | |||
| // eslint-disable-next-line @typescript-eslint/naming-convention | |||
| messages={{0: translate(errorData.validationError, errorData.phraseParam as never)}} | |||
There was a problem hiding this comment.
not your fault but this code is confusing. Not sure why messages is an object instead of just being an array.
This was referenced Feb 25, 2024
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 1.4.44-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.44-13 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ript
Details
Fixed Issues
$ #25122
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native-converted.webm
Android: mWeb Chrome
android-web-converted.webm
iOS: Native
ios-native-converted.mp4
iOS: mWeb Safari
ios-web-converted.mp4
MacOS: Chrome / Safari
desktop-web-converted.mov
MacOS: Desktop
desktop-native-converted.mov