Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #35822

Krishna2323 · 2024-02-05T15:01:03Z

Details

Fixed Issues

$ #34616
PROPOSAL: #34616 (comment)

Tests

Start a money request from global FAB
In manual tab enter any amount > click next
Verify Participants Selector page appears with correct header title (Manual)
Split with member or select one > request money > verify everything works fine

Start a money request from global FAB
Select scan tab upload a receipt
Verify Participants Selector page appears with correct header title (Scan)
Split with member or select one > request money > verify everything works fine

Start a money request from global FAB
Select distance tab and select 2 different waypoints > click next
Verify Participants Selector page appears with correct header title (Distance)
Select any workspace > request money > verify everything works fine

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

… 27 into IOURequestStepParticipants.js. Signed-off-by: Krishna Gupta <[email protected]>

melvin-bot · 2024-02-05T15:01:07Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-02-05T15:25:56Z

Still working on this, will try to finish today.

Krishna2323 · 2024-02-05T19:57:10Z

Syncing commits from old component.

…a2323/remove/redundant/MoneyRequestParticipantsPage

Signed-off-by: Krishna Gupta <[email protected]>

…RequestParticipantsPage

…a2323/remove/redundant/MoneyRequestParticipantsPage

Signed-off-by: Krishna Gupta <[email protected]>

mountiny · 2024-03-29T22:51:21Z

@Krishna2323 there is more conflicts here

…a2323/remove/redundant/MoneyRequestParticipantsPage

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-04-01T03:51:47Z

conflicts resolved.

abdulrahuman5196 · 2024-04-01T11:54:19Z

@Krishna2323 We don't have any platform videos? Could you add the same and complete the author's checklist?

abdulrahuman5196 · 2024-04-01T11:55:01Z

src/libs/actions/IOU.ts

    }
-    Navigation.navigate(ROUTES.MONEY_REQUEST_PARTICIPANTS.getRoute(iouType));
+    // Navigation.navigate(ROUTES.MONEY_REQUEST_PARTICIPANTS.getRoute(iouType));


Why are we commenting out here? If not required, kindly remove the same.

For more information, navigateToNextPage is removed yesterday here. @Krishna2323 Let's merge main

abdulrahuman5196 · 2024-04-01T11:55:35Z

src/pages/iou/request/step/IOURequestStepParticipants.js

@@ -1,7 +1,7 @@
 import {useNavigation} from '@react-navigation/native';
+import _ from 'lodash';


Why are we changing from underscore to lodash here since we dont have any other code change in this file?

The old component uses lodash, underscore was removed in this commit. We can still use underscore if we want.

App/src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsPage.js

Line 1 in ae6cc49

import _ from 'lodash';

DylanDylann · 2024-04-02T03:21:34Z

I believe it's necessary to update the route MONEY_REQUEST_STEP_PARTICIPANTS to incorporate the action parameter. The action parameter serves to distinguish between creating a new action or editing an existing one. While the participant page is currently only utilized in the creation flow, but it's important to uphold consistency by applying the same structure universally.

DylanDylann · 2024-04-02T03:29:07Z

src/libs/Navigation/types.ts

-    [SCREENS.MONEY_REQUEST.PARTICIPANTS]: {
-        iouType: string;
-        reportID: string;
-    };
    [SCREENS.MONEY_REQUEST.CONFIRMATION]: {


@Krishna2323 Let's create new type SCREENS.MONEY_REQUEST.STEP_PARTICIPANTS

Thanks @DylanDylann, type created for SCREENS.MONEY_REQUEST.STEP_PARTICIPANTS.

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-04-04T07:22:26Z

Conflicts resolved again 😢, will add recordings in few moments.

Krishna2323 · 2024-04-04T10:35:07Z

@abdulrahuman5196, checklist completed and recordings added. Pls review once you have sometime :)

DylanDylann · 2024-04-04T13:27:27Z

@Krishna2323 What do you think about this comment?

Krishna2323 · 2024-04-04T15:14:47Z

@DylanDylann, we can do it, its very minor change, lets see what @abdulrahuman5196 thinks.

abdulrahuman5196 · 2024-04-07T19:43:53Z

DylanDylann, we can do it, its very minor change, lets see what @abdulrahuman5196 thinks.

I don't see the use of action parameter in MONEY_REQUEST_STEP_PARTICIPANTS currently, do let me know if wrong. While its good to have universal structure, but in this case we can avoid adding unwanted parameters which won't be used. Its a very minor change, so it fine to add it when it becomes needed.

@Krishna2323 I am assuming we already checked if any latest changes in MoneyRequestParticipantsPage is also ported to IOURequestStepParticipants. Will cross check and work on platform videos in my morning.

abdulrahuman5196 · 2024-04-09T16:19:12Z

Checking now

mountiny · 2024-04-09T18:20:13Z

@abdulrahuman5196 Let's please focus on this one so we can get it resolved, thank you

abdulrahuman5196 · 2024-04-09T19:33:56Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-04-10.at.12.45.32.AM.mp4

Android: mWeb Chrome

Screen.Recording.2024-04-10.at.12.49.59.AM.mp4

iOS: Native

Screen.Recording.2024-04-10.at.12.21.22.AM.mp4

iOS: mWeb Safari

Screen.Recording.2024-04-10.at.12.26.04.AM.mp4

MacOS: Chrome / Safari

Screen.Recording.2024-04-10.at.12.14.09.AM.mp4

MacOS: Desktop

Screen.Recording.2024-04-10.at.12.17.08.AM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @mountiny

🎀 👀 🎀
C+ Reviewed

…a2323/remove/redundant/MoneyRequestParticipantsPage

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-04-12T04:31:27Z

@mountiny, we can merge this, all conflicts has been resolved.

mountiny · 2024-04-15T18:16:18Z

@Krishna2323 Apologies, I was ooo at the end of the week, can you please merge with main again?

…a2323/remove/redundant/MoneyRequestParticipantsPage

Krishna2323 · 2024-04-16T13:30:40Z

@mountiny done!

mountiny · 2024-04-16T18:38:24Z

@Krishna2323 I have been slow again, can you ping me in slack whne you sync next time

DylanDylann · 2024-04-19T02:11:33Z

@Krishna2323 Please update this PR. This PR is blocking other issues

DylanDylann · 2024-04-19T07:03:57Z

@Krishna2323 This PR is almost about to be merged. Please keep updating it because It is blocking the main tracking issue

cc @tgolen

Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 · 2024-04-19T08:36:37Z

@mountiny, merge conflicts resolved.

mountiny

🚀

OSBotify · 2024-04-19T09:07:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-23T23:42:13Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove MoneyRequestParticipantsPage.js and copy any changes since Nov…

7565621

… 27 into IOURequestStepParticipants.js. Signed-off-by: Krishna Gupta <[email protected]>

Krishna2323 requested a review from a team as a code owner February 5, 2024 15:01

melvin-bot bot removed the request for review from a team February 5, 2024 15:01

melvin-bot bot requested a review from abdulrahuman5196 February 5, 2024 15:01

Krishna2323 added 2 commits February 6, 2024 12:07

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

26e011a

…a2323/remove/redundant/MoneyRequestParticipantsPage

remove MoneyRequestParticipantsPage.js.

db861f6

Signed-off-by: Krishna Gupta <[email protected]>

situchan mentioned this pull request Feb 6, 2024

Remove MoneyRequestParticipantsSelector.js and copy any changes since Nov 27 into MoneyTemporaryForRefactorRequestParticipantsSelector #34617

Closed

Krishna2323 added 4 commits February 18, 2024 11:19

Merge branch 'Expensify:main' into krishna2323/remove/redundant/Money…

e8c130c

…RequestParticipantsPage

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

48f5dd8

…a2323/remove/redundant/MoneyRequestParticipantsPage

remove MoneyRequestParticipantsPage.js.

c112ca3

Signed-off-by: Krishna Gupta <[email protected]>

minor import update.

33196ae

Signed-off-by: Krishna Gupta <[email protected]>

mountiny assigned Krishna2323 Mar 29, 2024

mountiny self-requested a review March 29, 2024 22:51

Krishna2323 added 4 commits April 1, 2024 08:58

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

432dadb

…a2323/remove/redundant/MoneyRequestParticipantsPage

remove ModalStackNavigators file.

da62d52

Signed-off-by: Krishna Gupta <[email protected]>

remove all instances of SCREENS.MONEY_REQUEST.PARTICIPANTS.

6d60656

Signed-off-by: Krishna Gupta <[email protected]>

remove redundant code.

ab1542f

Signed-off-by: Krishna Gupta <[email protected]>

abdulrahuman5196 suggested changes Apr 1, 2024

View reviewed changes

DylanDylann reviewed Apr 2, 2024

View reviewed changes

Krishna2323 added 2 commits April 4, 2024 11:58

fix merge conflicts.

1db1675

Signed-off-by: Krishna Gupta <[email protected]>

add type for SCREENS.MONEY_REQUEST.STEP_PARTICIPANTS.

c8ca864

Signed-off-by: Krishna Gupta <[email protected]>

abdulrahuman5196 approved these changes Apr 9, 2024

View reviewed changes

Krishna2323 added 3 commits April 11, 2024 16:54

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

16033b3

…a2323/remove/redundant/MoneyRequestParticipantsPage

fix: types for SCREENS.MONEY_REQUEST.STEP_PARTICIPANTS.

2836636

Signed-off-by: Krishna Gupta <[email protected]>

fix merge conflicts.

8df57ca

Signed-off-by: Krishna Gupta <[email protected]>

Merge branch 'main' of https://github.com/Krishna2323/App into krishn…

36f56b1

…a2323/remove/redundant/MoneyRequestParticipantsPage

bernhardoj mentioned this pull request Apr 17, 2024

Remove underscore usage #40346

Merged

50 tasks

fix: merge conflicts.

2a89693

Signed-off-by: Krishna Gupta <[email protected]>

mountiny approved these changes Apr 19, 2024

View reviewed changes

mountiny merged commit bec1c8e into Expensify:main Apr 19, 2024
15 checks passed

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

kbecciv mentioned this pull request Apr 22, 2024

Submit Expense - Header Remains as "Submit Expense" Instead of "Manual" #40717

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #35822

Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #35822

Krishna2323 commented Feb 5, 2024 •

edited

Loading

melvin-bot bot commented Feb 5, 2024

Krishna2323 commented Feb 5, 2024

Krishna2323 commented Feb 5, 2024

mountiny commented Mar 29, 2024

Krishna2323 commented Apr 1, 2024

abdulrahuman5196 commented Apr 1, 2024

abdulrahuman5196 Apr 1, 2024

DylanDylann Apr 2, 2024

abdulrahuman5196 Apr 1, 2024

Krishna2323 Apr 4, 2024 •

edited

Loading

DylanDylann commented Apr 2, 2024

DylanDylann Apr 2, 2024

Krishna2323 Apr 4, 2024

Krishna2323 commented Apr 4, 2024

Krishna2323 commented Apr 4, 2024

DylanDylann commented Apr 4, 2024

Krishna2323 commented Apr 4, 2024

abdulrahuman5196 commented Apr 7, 2024

abdulrahuman5196 commented Apr 9, 2024

mountiny commented Apr 9, 2024

abdulrahuman5196 commented Apr 9, 2024 •

edited

Loading

abdulrahuman5196 left a comment

Krishna2323 commented Apr 12, 2024

mountiny commented Apr 15, 2024

Krishna2323 commented Apr 16, 2024

mountiny commented Apr 16, 2024

DylanDylann commented Apr 19, 2024

DylanDylann commented Apr 19, 2024

Krishna2323 commented Apr 19, 2024

mountiny left a comment

OSBotify commented Apr 19, 2024

OSBotify commented Apr 23, 2024

		@@ -1,7 +1,7 @@
		import {useNavigation} from '@react-navigation/native';
		import _ from 'lodash';

Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #35822

Remove MoneyRequestParticipantsPage.js and copy any changes since Nov 27 into IOURequestStepParticipants.js #35822

Conversation

Krishna2323 commented Feb 5, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 5, 2024

Krishna2323 commented Feb 5, 2024

Krishna2323 commented Feb 5, 2024

mountiny commented Mar 29, 2024

Krishna2323 commented Apr 1, 2024

abdulrahuman5196 commented Apr 1, 2024

abdulrahuman5196 Apr 1, 2024

Choose a reason for hiding this comment

DylanDylann Apr 2, 2024

Choose a reason for hiding this comment

abdulrahuman5196 Apr 1, 2024

Choose a reason for hiding this comment

Krishna2323 Apr 4, 2024 • edited Loading

Choose a reason for hiding this comment

DylanDylann commented Apr 2, 2024

DylanDylann Apr 2, 2024

Choose a reason for hiding this comment

Krishna2323 Apr 4, 2024

Choose a reason for hiding this comment

Krishna2323 commented Apr 4, 2024

Krishna2323 commented Apr 4, 2024

DylanDylann commented Apr 4, 2024

Krishna2323 commented Apr 4, 2024

abdulrahuman5196 commented Apr 7, 2024

abdulrahuman5196 commented Apr 9, 2024

mountiny commented Apr 9, 2024

abdulrahuman5196 commented Apr 9, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

Krishna2323 commented Apr 12, 2024

mountiny commented Apr 15, 2024

Krishna2323 commented Apr 16, 2024

mountiny commented Apr 16, 2024

DylanDylann commented Apr 19, 2024

DylanDylann commented Apr 19, 2024

Krishna2323 commented Apr 19, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 19, 2024

OSBotify commented Apr 23, 2024

Krishna2323 commented Feb 5, 2024 •

edited

Loading

Krishna2323 Apr 4, 2024 •

edited

Loading

abdulrahuman5196 commented Apr 9, 2024 •

edited

Loading