fix: Inconsistency of flashlight/torch behavior in Scan tab

[tienifr]

Details

Fixed Issues

$ #34457
PROPOSAL: #34457 (comment)

Tests

1. Login to native/mweb App
2. Tap FAB button
3. Tap Request money
4. Tap on flashlight icon to enable
5. Verify that the button should turn into a pressed state (highlighted), but the flash is not turned on yet
6. Tap on green circle to take a shoot with camera
7. Verify that the flash is turned on and the photo is taken in the flashlight effect

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

1. Login to native/mweb App
2. Tap FAB button
3. Tap Request money
4. Tap on flashlight icon to enable
5. Verify that the button should turn into a pressed state (highlighted), but the flash is not turned on yet
6. Tap on green circle to take a shoot with camera
7. Verify that the flash is turned on and the photo is taken in the flashlight effect

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[tienifr]

@s77rt I have some problems when record video for android/ios web. Previously, I used ngrok to test on dev, but seem like BE prevented login though exotic domain recently. Do you have any ways to test on physical device? Thanks a lot

[s77rt]

I can't test this either. My phone does not seem to support the web camera feature neither the simulator. Will ask for someone to take over this PR review/test

[mananjadhav]

@s77rt @tienifr I tested the adhoc builds on the Android and iOS Physical devices. Attached are the videos.

The expected result works fine on native iOS and Android app. mWeb Safari no flash light icon (expected result). mWeb Chrome turning on the flashlight has not impact on the camera flash.

Video for iOS native app.

ios-flashlight_TXCG8SJ1.mp4

Video for mWeb Safari.

mweb-safari-flashlight.MP4

Video for Android native app:

android-flashlight.mp4

Video for mWeb Chrome.

mweb-chrome-flashlight.mp4

[tienifr]

@mananjadhav Thanks for your help. I think we need to delay taking a picture when users enable torch/flashlight cc @s77rt. I already posted the changes.

[s77rt]

@tienifr The use of setTimeout is discouraged. Can we instead implement a Promise for the get screenshot method?

[tienifr]

@s77rt Ok, take a photo should be called when torch is open

trackRef.current
                .applyConstraints({
                    advanced: [{torch: true}],
                })
                .then(() => {
                    getScreenshot();
                    trackRef.current.applyConstraints({
                        advanced: [{torch: false}],
                    });
                });
            return;

but I'm not sure it works, we need to test on real device

[s77rt]

@mananjadhav Can you please test again

[mananjadhav]

Sure can we trigger the adhoc build? That would be the fastest to test.

[s77rt]

@mountiny Can you please trigger adhoc build

[mountiny]

https://github.com/Expensify/App/actions/runs/7645656648

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/34782/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/34782/index.html
Desktop 💻	Web 🕸️
❌ FAILED ❌	https://34782.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

---

👀 View the workflow run that generated this build 👀

[tienifr]

@s77rt Seem like using getScreenshot in then callback doesn't work. I think we still need to use settimeout. wdyt?

[s77rt]

@tienifr Why it's not working in this case? Shouldn't the applyConstraints promise guarantee that the flash in on?

[tienifr]

@s77rt I think applyConstraints promise can't guarantee that the picture is taken with flash. I'm finding the RCA and other solution. Do you have any suggestion?

[s77rt]

The example on MDN https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack/applyConstraints#examples shows like what we are doing should be possible. Maybe there is a problem with getScreenshot. Try to log a message after the promise resolves see if it's logged while the flash is on or not

[tienifr]

checking...

[tienifr]

@s77rt After checking, torch is already on before triggering getScreenshot. But the captured image doesn't have flashlight effect.

[tienifr]

When using camera App in android, I can see it has some delay (~2s) before taking the photo (with torch is on). That's the reason we should do the same

[s77rt]

That still does not make much sense. How is it possible that the flash is on and still get a photo with no flash? We shouldn't use setTimeout unless it's necessary. At this point I think we still need to know why this is failing

[ishpaul777]

check out this one:

first capture without falsh.

second capture with flash.

RPReplay_Final1710772980.MP4

[s77rt]

@ishpaul777 Please do same test on mWeb, it should have similar feel as in native

[ishpaul777]

i dont see a flash toggle button on safari.

Screenshot

[s77rt]

@ishpaul777 What's your device?

[ishpaul777]

@ishpaul777 What's your device?

iphone 15 plus

[ishpaul777]

Works well!

trim.619ADF29-B91D-4753-8662-08555399A14F.MOV

[s77rt]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

mweb-chrome.mov

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[s77rt]

@tienifr Can you please clear up / remove duplicated testing steps and just specify that the flash should be turned on after pressing the shutter button

[s77rt]

Tap on flashlight icon to enable (verify nothing happens)

This may be confusing, the button should turn into a pressed state (highlighted). Instead specify that the flash is not turned on yet

[tienifr]

@s77rt Thanks for your suggestions. I updated

[luacmartins]

@tienifr we have conflicts

[tienifr]

@luacmartins fixed conflicts

[melvin-bot]

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

[luacmartins]

Tests were passing

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.56-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.4.56-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅