[TS migration] Migrate 'ReportActionItemMoneyRequest' component to TypeScript #34564

VickyStash · 2024-01-16T11:46:08Z

Details

[TS migration] Migrate 'ReportActionItemMoneyRequest' component to TypeScript

Fixed Issues

$ #31983
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Open app
Log in with any account that has a workspace

Requests to another User

Create several Manual and Scan money requests to another user.
Open the chat with that user and click on the grouped requests report preview.
Make sure the money requests preview looks as expected. They have the correct amount and currency. If the Scan request is still in progress, the message should say Receipt scan in progress....
Tap on Manual Money request preview to open its view. Make sure it looks as expected and has all the necessary data. You can also update Description/Date fields.
Tap on Scan Money request preview to open its view. Make sure it looks same way as before and has all the necessary data.

Requests to Workspace

Create several Manual,Scan and Distance money requests to the workspace.
Open the workspace chat and click on the grouped requests report preview.
Make sure the money requests preview looks as expected. The Distance request preview should have a map (or default image if the request is still processed) with a distance, currency and amount of money as well as the distance value.
Tap on Distance Money request preview to open its view. Make sure it looks the same way as before and has all the necessary data.

Offline tests

Open app
Log in with any account that has a workspace
Create several Manual,Scan and Distance money requests to the workspace.
Open the workspace chat and click on the grouped requests report preview.
Make sure the money requests preview looks as expected.
Go offline
Delete a money request
Make sure that the request skeleton shows the correct amount and currency.

QA Steps

Verify that no errors appear in the JS console

Same as in Tests + Offline Tests sections

PR Author Checklist

Screenshots/Videos

Android: Native

android1.mp4

Android: mWeb Chrome

android_web1.mp4

iOS: Native

ios1.mp4

iOS: mWeb Safari

ios_web1.mp4

MacOS: Chrome / Safari

web1.mp4

MacOS: Desktop

desktop1.mp4

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestView.tsx

src/components/ReportActionItem/MoneyRequestPreview.tsx

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestView.tsx

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestPreview.tsx # src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

src/components/Pressable/GenericPressable/types.ts

src/components/ReportActionItem/MoneyRequestPreview.tsx

src/components/ReportActionItem/MoneyRequestView.tsx

…mponent # Conflicts: # src/types/onyx/Policy.ts

…s back to the second hoc

…mponent # Conflicts: # src/types/onyx/TransactionViolation.ts # src/types/onyx/index.ts

VickyStash · 2024-01-19T09:59:43Z

src/components/ReportActionItem/MoneyRequestPreview.tsx

-    const getDisplayDeleteAmountText = () => {
-        const {amount, currency} = ReportUtils.getTransactionDetails(props.action.originalMessage);
-
-        if (isDistanceRequest) {
-            return CurrencyUtils.convertToDisplayString(TransactionUtils.getAmount(props.action.originalMessage), currency);
-        }
+    const getDisplayDeleteAmountText = (): string => {
+        const iouOriginalMessage: IOUMessage | EmptyObject = action?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? action.originalMessage : {};
+        const {amount = 0, currency = CONST.CURRENCY.USD} = iouOriginalMessage;

        return CurrencyUtils.convertToDisplayString(amount, currency);
    };


During this file migration, it turned out that originalMessage of action is passed to methods where transaction is expected to get the amount and currency values. Though originalMessage doesn't look like transaction at all

After some testing I've find out that the functionality of getDisplayDeleteAmountText function can be simplified.

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestPreview.tsx

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestView.tsx # src/libs/ReceiptUtils.ts

…mponent # Conflicts: # src/types/onyx/Policy.ts

…mponent # Conflicts: # src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestAction.tsx # src/components/ReportActionItem/MoneyRequestPreview.tsx

blazejkustra

Great work! LGTM

VickyStash · 2024-01-31T11:46:11Z

@rushatgabhane kind bump 🙂

VickyStash · 2024-02-02T09:20:02Z

@rushatgabhane Hey, any ETA on reviewing this one? 🙂

rushatgabhane · 2024-02-02T10:26:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

rushatgabhane

LGTM

melvin-bot · 2024-02-02T12:12:44Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #31983 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

fabioh8010 · 2024-02-02T15:49:30Z

@mountiny Could we assign a engineer here? Looks like Melvin didn't assign anyone.
@VickyStash Please fix conflicts 🙂

rushatgabhane · 2024-02-02T17:07:48Z

@aldo-expensify all yours!

aldo-expensify · 2024-02-02T18:55:40Z

@VickyStash there are conflicts now, please resolve 🙏

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestPreview.tsx # src/components/ReportActionItem/MoneyRequestView.tsx

VickyStash · 2024-02-02T20:34:58Z

@aldo-expensify Done 👌

aldo-expensify · 2024-02-02T20:36:41Z

Thank you!, this is a ~~huge~~ (maybe "huge" was too exaggerated) big PR, I skim read the changes and didn't see anything wrong, I hope everything is fine 🥲

OSBotify · 2024-02-02T20:40:57Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-02-05T23:09:04Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2024-02-05T23:30:49Z

🚀 Cherry-picked to staging by https://github.com/thienlnam in version: 1.4.36-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

situchan · 2024-02-06T15:17:39Z

src/components/ReportActionItem/MoneyRequestPreview.tsx

                                        <Text style={[styles.textLabel, styles.colorMuted]}>{translate('iou.pendingConversionMessage')}</Text>
                                    )}
                                    {shouldShowDescription && <RenderHTML html={parser.replace(merchantOrDescription)} />}
                                    {shouldShowMerchant && <Text style={[styles.textLabelSupporting, styles.textNormal]}>{merchantOrDescription}</Text>}
                                </View>
-                                {props.isBillSplit && !_.isEmpty(participantAccountIDs) && requestAmount > 0 && (
+                                {isBillSplit && participantAccountIDs.length > 0 && requestAmount && requestAmount > 0 && (


@VickyStash Native app crashes on this line. Can you please raise quick PR fixing that?

Suggested change

{isBillSplit && participantAccountIDs.length > 0 && requestAmount && requestAmount > 0 && (

{isBillSplit && participantAccountIDs.length > 0 && !!requestAmount && requestAmount > 0 && (

@situchan I'm taking a look

@situchan could you please provide me steps for reproduction so I can be sure the issue is fixed?

I tested that solution myself. Works well.
I was just testing #35876. Please try to follow QA step on that PR.

So that happens when requestAmount = 0
Try this:
A request $10 from B
B request $10 (same amount) from A

@situchan I got what you mean and it makes sense to me, but I'm still not able to trigger this case on the main, could you please provide me reproduction video 🙏

youssef-lr · 2024-02-06T18:22:08Z

src/components/ReportActionItem/MoneyRequestAction.tsx

            Navigation.navigate(ROUTES.SPLIT_BILL_DETAILS.getRoute(chatReportID, reportActionID));
            return;
        }

        // If the childReportID is not present, we need to create a new thread
-        const childReportID = lodashGet(action, 'childReportID', 0);
+        const childReportID = action?.childReportID ?? '0';


@VickyStash heads up! All IDs must be numbers, this created this bug #35904. :)

accountIDs are numbers and reportIDs are strings, right? 🤔

@youssef-lr reportIDs are expected to be string, otherwise they can overflow, right?
Unless this changed lately

Yeah sorry my bad, they are all numbers in the backend, but in JS reportIDs & reportActionIDs are strings. In this specific example it doesn't make sense to use '0', because the condition below this line evaluates to false when it should evaluate to true if (!childReportID) {

@youssef-lr you are right, my bad!

Commented in your PR @youssef-lr , I don't think we should default to 0 either

Yeah that sounds good, updated.

OSBotify · 2024-02-07T09:51:13Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

VickyStash added 5 commits January 15, 2024 12:11

Migrate MoneyRequestAction to TypeScript

a56bce1

Migrate MoneyRequestPreview to TypeScript

0f627ba

Migrate MoneyRequestView to TypeScript

02296e8

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

6b8c3a3

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestView.tsx

Fix lint errors

03a0c4c

VickyStash commented Jan 16, 2024

View reviewed changes

src/components/ReportActionItem/MoneyRequestPreview.tsx Outdated Show resolved Hide resolved

VickyStash added 3 commits January 16, 2024 18:05

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

7a64f0c

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestView.tsx

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

6c8137a

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestPreview.tsx # src/pages/home/report/ContextMenu/ReportActionContextMenu.ts

Use ContextMenuAnchor type for anchor typing

6637583

fabioh8010 reviewed Jan 17, 2024

View reviewed changes

VickyStash added 4 commits January 17, 2024 11:48

Code improvements

e1e39e1

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

ccef5e0

…mponent # Conflicts: # src/types/onyx/Policy.ts

Update getDisplayDeleteAmountText function, move transactionViolation…

fb3f8d1

…s back to the second hoc

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

60d8105

…mponent # Conflicts: # src/types/onyx/TransactionViolation.ts # src/types/onyx/index.ts

VickyStash commented Jan 19, 2024

View reviewed changes

fabioh8010 approved these changes Jan 19, 2024

View reviewed changes

VickyStash added 11 commits January 22, 2024 09:36

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

69a4df4

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestPreview.tsx

TS fixes after merging main

be37558

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

c8438bf

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestView.tsx # src/libs/ReceiptUtils.ts

Fix TS issues

01fa104

Update image typing

f65fbe0

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

73e5685

…mponent # Conflicts: # src/types/onyx/Policy.ts

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

696f337

…mponent # Conflicts: # src/types/onyx/Policy.ts

TS fixes after merging OptionsListUtils migration

c07a39e

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

a5f3dba

…mponent # Conflicts: # src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.tsx

TS fixes after merging main

eb4631e

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

8b9bac8

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestAction.tsx # src/components/ReportActionItem/MoneyRequestPreview.tsx

blazejkustra approved these changes Jan 29, 2024

View reviewed changes

VickyStash marked this pull request as ready for review January 29, 2024 12:09

VickyStash requested a review from a team as a code owner January 29, 2024 12:09

Fix TS issues after merging main

e7ff217

rushatgabhane approved these changes Feb 2, 2024

View reviewed changes

mountiny requested a review from aldo-expensify February 2, 2024 18:50

VickyStash added 2 commits February 2, 2024 20:52

Merge branch 'main' into ts-migration/reportActionItemMoneyRequest-co…

5e1e232

…mponent # Conflicts: # src/components/ReportActionItem/MoneyRequestPreview.tsx # src/components/ReportActionItem/MoneyRequestView.tsx

Retry performance test

d3f64c9

aldo-expensify approved these changes Feb 2, 2024

View reviewed changes

aldo-expensify merged commit de633ac into Expensify:main Feb 2, 2024
15 checks passed

github-actions bot mentioned this pull request Feb 5, 2024

Deploy Checklist: New Expensify 2024-02-05 #35857

Closed

66 tasks

situchan reviewed Feb 6, 2024

View reviewed changes

situchan mentioned this pull request Feb 6, 2024

Fix report preview disappears after clearing the error message #35876

Merged

50 tasks

VickyStash mentioned this pull request Feb 6, 2024

[TS Migration] Follow-up PR to fix crash on MoneyRequestPreview #35916

Merged

50 tasks

ZhenjaHorbach mentioned this pull request Feb 6, 2024

[HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [$500] 0 is showing up in black small font in split bill preview #35915

Closed

6 tasks

youssef-lr reviewed Feb 6, 2024

View reviewed changes

rlinoz mentioned this pull request Feb 6, 2024

Split scan - On creating Split scan in WS, shows 0 in preview in mweb , app crashes in android #35942

Closed

6 tasks

aimane-chnaif mentioned this pull request Feb 6, 2024

[TS migration] Migrate 'IOU.js' lib to TypeScript #34092

Merged

50 tasks

melvin-bot bot mentioned this pull request Feb 7, 2024

[HOLD for payment 2024-02-15] [HOLD for payment 2024-02-14] [TS migration] Migrate 'ReportActionItemMoneyRequest' component to TypeScript #31983

Closed

s77rt mentioned this pull request Mar 4, 2024

[$500] Tag - "Missing tag" error appears & disappears when change Category on created request #37644

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TS migration] Migrate 'ReportActionItemMoneyRequest' component to TypeScript #34564

[TS migration] Migrate 'ReportActionItemMoneyRequest' component to TypeScript #34564

VickyStash commented Jan 16, 2024 •

edited

Loading

VickyStash Jan 19, 2024

blazejkustra left a comment

VickyStash commented Jan 31, 2024

VickyStash commented Feb 2, 2024

rushatgabhane commented Feb 2, 2024 •

edited

Loading

rushatgabhane left a comment

melvin-bot bot commented Feb 2, 2024

fabioh8010 commented Feb 2, 2024

rushatgabhane commented Feb 2, 2024

aldo-expensify commented Feb 2, 2024

VickyStash commented Feb 2, 2024

aldo-expensify commented Feb 2, 2024 •

edited

Loading

OSBotify commented Feb 2, 2024

OSBotify commented Feb 5, 2024

OSBotify commented Feb 5, 2024

situchan Feb 6, 2024

VickyStash Feb 6, 2024

VickyStash Feb 6, 2024

situchan Feb 6, 2024

situchan Feb 6, 2024

VickyStash Feb 6, 2024

youssef-lr Feb 6, 2024 •

edited

Loading

blazejkustra Feb 6, 2024

aldo-expensify Feb 6, 2024 •

edited

Loading

youssef-lr Feb 6, 2024

VickyStash Feb 6, 2024

aldo-expensify Feb 6, 2024 •

edited

Loading

youssef-lr Feb 6, 2024

OSBotify commented Feb 7, 2024

	{isBillSplit && participantAccountIDs.length > 0 && requestAmount && requestAmount > 0 && (
	{isBillSplit && participantAccountIDs.length > 0 && !!requestAmount && requestAmount > 0 && (

[TS migration] Migrate 'ReportActionItemMoneyRequest' component to TypeScript #34564

[TS migration] Migrate 'ReportActionItemMoneyRequest' component to TypeScript #34564

Conversation

VickyStash commented Jan 16, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

blazejkustra left a comment

Choose a reason for hiding this comment

VickyStash commented Jan 31, 2024

VickyStash commented Feb 2, 2024

rushatgabhane commented Feb 2, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Feb 2, 2024

fabioh8010 commented Feb 2, 2024

rushatgabhane commented Feb 2, 2024

aldo-expensify commented Feb 2, 2024

VickyStash commented Feb 2, 2024

aldo-expensify commented Feb 2, 2024 • edited Loading

OSBotify commented Feb 2, 2024

OSBotify commented Feb 5, 2024

OSBotify commented Feb 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

youssef-lr Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aldo-expensify Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aldo-expensify Feb 6, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OSBotify commented Feb 7, 2024

VickyStash commented Jan 16, 2024 •

edited

Loading

rushatgabhane commented Feb 2, 2024 •

edited

Loading

aldo-expensify commented Feb 2, 2024 •

edited

Loading

youssef-lr Feb 6, 2024 •

edited

Loading

aldo-expensify Feb 6, 2024 •

edited

Loading

aldo-expensify Feb 6, 2024 •

edited

Loading