Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-01-24] Refactor and Fix Attachment Handling in File Download and Carousel #31791

Commits on Nov 23, 2023

  1. Make file.name required in attachment prop types

    Some bugs can be caught earlier if we're warned when `file` or `file.name` is missing
    kidroca committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    8c5199b View commit details
    Browse the repository at this point in the history
  2. fix(AttachmentCarousel): Use source URL for fallback file names

    Introduce getFileName in FileUtils to generate fallback names for attachments lacking original file names. This function extracts and sanitizes filenames from URLs, ensuring attachments in AttachmentCarousel have meaningful names even when original names are missing.
    
    Updated AttachmentCarousel to utilize this new utility function.
    
    At this time, the only know case is embedded attachments shared by the Concierge account via drag and drop
    kidroca committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    4823b7e View commit details
    Browse the repository at this point in the history
  3. fix(libs/fileDownload): Ensure reachable fallback for filenames

    Addressed a bug in libs/fileDownload where the intended fallback for filenames was never reached due to `FileUtils.appendTimeToFileName` always providing a return value. This fix refines the filename determination logic, ensuring effective use of fallback mechanisms across various components including AttachmentCarousel, particularly for cases like attachments shared by the Concierge account.
    kidroca committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    9991550 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1b58d05 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2023

  1. Configuration menu
    Copy the full SHA
    931b785 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Merge branch 'main' into kidroca/fix/regressions-related-to-file-down…

    …loads
    
    # Conflicts:
    #	src/components/Attachments/AttachmentCarousel/extractAttachmentsFromReport.js
    kidroca committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    cd60646 View commit details
    Browse the repository at this point in the history