[TS migration] Migrate 'Button' component to TypeScript #31102

kubabutkiewicz · 2023-11-09T09:27:07Z

Details

Fixed Issues

$ #25098

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Login into app
Click on FAB icon
Start a chat
Send a message
Add Attachment
Click on Fab icon
Request a money
Check if all flows are working, Button component is used basically everywhere

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

iOS: Native

ios.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

…s-migration/Button/component

VickyStash · 2023-11-09T11:04:59Z

src/components/Button/index.tsx


    /** Any additional styles to pass to the left icon container. */
-    // eslint-disable-next-line react/forbid-prop-types
-    iconStyles: PropTypes.arrayOf(PropTypes.object),
+    iconStyles?: Array<StyleProp<ViewStyle>>;


Just StyleProp<ViewStyle> should be enough, then in the code replace ...iconStyles with just iconStyles, it should work the same way as before

Suggested change

iconStyles?: Array<StyleProp<ViewStyle>>;

iconStyles?: StyleProp<ViewStyle>;

VickyStash · 2023-11-09T11:05:19Z

src/components/Button/index.tsx


    /** Any additional styles to pass to the right icon container. */
-    // eslint-disable-next-line react/forbid-prop-types
-    iconRightStyles: PropTypes.arrayOf(PropTypes.object),
+    iconRightStyles?: Array<StyleProp<ViewStyle>>;


Same

Suggested change

iconRightStyles?: Array<StyleProp<ViewStyle>>;

iconRightStyles?: StyleProp<ViewStyle>;

VickyStash · 2023-11-09T11:06:04Z

src/components/Button/index.tsx


    /** A function that is called when the button is clicked on */
-    onPress: PropTypes.func,
+    onPress?: (e?: GestureResponderEvent | KeyboardEvent) => void;


Suggested change

onPress?: (e?: GestureResponderEvent | KeyboardEvent) => void;

onPress?: (event?: GestureResponderEvent | KeyboardEvent) => void;

VickyStash · 2023-11-09T11:06:13Z

src/components/Button/index.tsx


    /** A function that is called when the button is long pressed */
-    onLongPress: PropTypes.func,
+    onLongPress?: (e?: GestureResponderEvent) => void;


Suggested change

onLongPress?: (e?: GestureResponderEvent) => void;

onLongPress?: (event?: GestureResponderEvent) => void;

VickyStash · 2023-11-09T11:07:42Z

src/components/Button/index.tsx


    /** Additional styles to add after local styles. Applied to Pressable portion of button */
-    style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]),
+    style?: ViewStyle | ViewStyle[];


Why not StyleProp<ViewStyle>?

when using this there is a ts error

It looks a little bit strange. How do you think can we use just use style instead of ...StyleUtils.parseStyleAsArray(style)?

I agree, let's just use style, parseStyleAsArray isn't needed

VickyStash · 2023-11-09T11:17:36Z

src/components/Button/index.tsx

@@ -318,6 +279,7 @@ function Button({
                isDisabled && !danger && !success ? styles.buttonDisabled : undefined,
                shouldRemoveRightBorderRadius ? styles.noRightBorderRadius : undefined,
                shouldRemoveLeftBorderRadius ? styles.noLeftBorderRadius : undefined,
+                // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing


Why not nullish coalescing in this place?

icon || shouldShowRightIcon ? styles.alignItemsStretch : undefined
i gues for if statments we should use normal OR operator

You can try !!icon || shouldShowRightIcon...., eslint should pass it so you can remove eslint disable

VickyStash · 2023-11-09T11:18:15Z

src/components/Button/index.tsx


 ButtonWithRef.displayName = 'ButtonWithRef';

-export default withNavigationFallback(ButtonWithRef);
+export default withNavigationFallback(React.forwardRef(ButtonWithRef));


If you add ref as a second param you can do it this way

Suggested change

export default withNavigationFallback(React.forwardRef(ButtonWithRef));

export default withNavigationFallback(React.forwardRef(Button));

VickyStash · 2023-11-09T11:18:41Z

src/components/Button/index.tsx

@@ -282,7 +242,8 @@ function Button({
            ref={forwardedRef}
            onPress={(event) => {
                if (event && event.type === 'click') {


Suggested change

if (event && event.type === 'click') {

if (event?.type === 'click') {

VickyStash · 2023-11-09T11:19:36Z

src/components/Button/index.tsx

@@ -282,7 +242,8 @@ function Button({
            ref={forwardedRef}
            onPress={(event) => {
                if (event && event.type === 'click') {
-                    event.currentTarget.blur();
+                    const currentTarget = event?.currentTarget as HTMLElement;


Why we need assertion here?

without assertion ts thinks that currentTarget is type of number | EventTarget on which blur function is not existing but we can assert that its HTMLElement because click event type is only on web or desktop

VickyStash · 2023-11-09T11:20:22Z

src/components/Button/validateSubmitShortcut/index.ts

+ */
+
+const validateSubmitShortcut: ValidateSubmitShortcut = (isFocused, isDisabled, isLoading, event) => {
+    const eventTarget = event?.target as HTMLElement;


Same question about assertion :)

similar situation as here

blazejkustra · 2023-11-09T12:12:55Z

src/components/Button/index.tsx

-ButtonWithRef.displayName = 'ButtonWithRef';
-
-export default withNavigationFallback(ButtonWithRef);
+export default withNavigationFallback(React.forwardRef(Button));


Can we remove withNavigationFallback now? And use navigation hook instead @VickyStash

@blazejkustra It looks like it should be possible, @kubabutkiewicz is going to give it a try

blazejkustra · 2023-11-09T12:23:04Z

src/components/Button/index.tsx


    /** Additional styles to add after local styles. Applied to Pressable portion of button */
-    style: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.object), PropTypes.object]),
+    style?: ViewStyle | ViewStyle[];


I agree, let's just use style, parseStyleAsArray isn't needed

blazejkustra · 2023-11-09T12:30:47Z

src/components/Button/index.tsx

@@ -16,195 +15,154 @@ import themeColors from '@styles/themes/default';
 import CONST from '@src/CONST';
 import validateSubmitShortcut from './validateSubmitShortcut';

-const propTypes = {
+type ButtonProps = {


I think there are two ways of using a Button, either with children or with text and icons:

import ChildrenProps from '@src/types/utils/ChildrenProps'; type ButtonWithText = { /** The text for the button label */ text: string; /** Boolean whether to display the right icon */ shouldShowRightIcon?: boolean; /** The icon asset to display to the left of the text */ icon?: React.FC<SvgProps> | null; }; type ButtonProps = (ButtonWithText | ChildrenProps) & { ... }

This makes destructing a little bit more tricky:

function Button( { allowBubble = false, iconRight = Expensicons.ArrowRight, iconFill = themeColors.textLight, iconStyles = [], iconRightStyles = [], small = false, large = false, medium = false, isLoading = false, isDisabled = false, onPress = () => {}, onLongPress = () => {}, onPressIn = () => {}, onPressOut = () => {}, onMouseDown = undefined, pressOnEnter = false, enterKeyEventListenerPriority = 0, style = [], innerStyles = [], textStyles = [], shouldUseDefaultHover = true, success = false, danger = false, shouldRemoveRightBorderRadius = false, shouldRemoveLeftBorderRadius = false, shouldEnableHapticFeedback = false, id = '', accessibilityLabel = '', ...rest }: ButtonProps, ref: ForwardedRef<View>, ) {

const renderContent = () => { if ('children' in rest) { return rest.children; } const {text = '', icon = null, shouldShowRightIcon = false} = rest;

melvin-bot · 2023-11-13T14:37:46Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…s-migration/Button/component

BartoszGrajdek · 2023-11-14T11:56:33Z

@allroundexperts kind bump 😄

allroundexperts · 2023-11-14T20:15:55Z

src/components/Button/index.tsx

@@ -238,20 +193,21 @@ function Button({
                    success && styles.buttonSuccessText,
                    danger && styles.buttonDangerText,
                    icon && styles.textAlignLeft,
-                    ...textStyles,
+                    textStyles,


Why did you remove the ...?

@allroundexperts
Actually spread operator is not needed here
we can pass array or object without spreading and styles will still work

allroundexperts · 2023-11-14T20:16:28Z

src/components/Button/index.tsx

        if (icon || shouldShowRightIcon) {
            return (
                <View style={[styles.justifyContentBetween, styles.flexRow]}>
                    <View style={[styles.alignItemsCenter, styles.flexRow, styles.flexShrink1]}>
                        {icon && (
-                            <View style={[styles.mr1, ...iconStyles]}>
+                            <View style={[styles.mr1, iconStyles]}>


Same. Why is ... being removed?

allroundexperts · 2023-11-14T20:16:40Z

src/components/Button/index.tsx

@@ -262,7 +218,7 @@ function Button({
                        {textComponent}
                    </View>
                    {shouldShowRightIcon && (
-                        <View style={[styles.justifyContentCenter, styles.ml1, ...iconRightStyles]}>
+                        <View style={[styles.justifyContentCenter, styles.ml1, iconRightStyles]}>


allroundexperts · 2023-11-14T20:23:15Z

src/components/Button/index.tsx

-                icon || shouldShowRightIcon ? styles.alignItemsStretch : undefined,
-                ...innerStyles,
+                // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
+                'text' in rest && (rest?.icon || rest?.shouldShowRightIcon) ? styles.alignItemsStretch : undefined,


Not sure what you're trying to do here. Why 'text' in rest is being added? Why is it not using ??

this is just for type narrowing , there are two ways of using Button component one with children like

<Button>Hello</Button

or with text props like

<Button text="Hello" />

and those two props icon and shouldShowRightIcon can be used only when Button is used with text prop. 'text' in rest will assure that Button is used with text prop

about the ? its needed only when we are using object dot notation so if rest is undefined it will be safe to use properties of the object. when using 'text' in rest and rest is undefined it will just return false

allroundexperts · 2023-11-14T20:24:41Z

src/components/Button/index.tsx

-ButtonWithRef.displayName = 'ButtonWithRef';
-
-export default withNavigationFallback(ButtonWithRef);
+export default React.forwardRef(Button);


Why is the withNavigationFallback being removed?

instead of the withNavigationFallback we can use useIsFocused which we are doing , so withNavigationFallback is not needed anymore

…s-migration/Button/component

kubabutkiewicz · 2023-11-17T11:39:52Z

@allroundexperts kind bump 😄

mountiny · 2023-11-20T13:42:06Z

I have triggered a build for this PR, @allroundexperts i know you have lots on your plate, this is one of 2 most important/ most blocking TS migration PRs now, could we reassign to someone who can take this over the finish line as soon as possible? the transition bug you are working on for instance is higher priority though

mountiny · 2023-11-20T13:43:43Z

@kubabutkiewicz can you please check the reassure performance tests failing? this should not be happening on the migration PR

OSBotify · 2023-11-20T14:03:01Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/31102/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/31102/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/31102/NewExpensify.dmg	https://31102.pr-testing.expensify.com

…s-migration/Button/component

blazejkustra · 2023-11-21T12:30:43Z

@mountiny @allroundexperts Alternatively @parasharrajat could take over as he has a lot of context

allroundexperts · 2023-11-21T12:32:26Z

Sorry, I missed the previous notifications for this. I have noted this down and will finish this today.

…s-migration/Button/component

parasharrajat · 2023-11-21T17:47:13Z

I can review this immediately, if needed.

allroundexperts · 2023-11-21T17:49:22Z

Thank you @parasharrajat. But I've started already.

allroundexperts · 2023-11-21T17:53:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2023-11-21.at.11.09.26.PM.mov

Android: mWeb Chrome

Screen.Recording.2023-11-21.at.11.08.46.PM.mov

iOS: Native

Screen.Recording.2023-11-21.at.11.15.04.PM.mov

iOS: mWeb Safari

Screen.Recording.2023-11-21.at.11.13.00.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2023-11-21.at.11.00.40.PM.mov

MacOS: Desktop

Screen.Recording.2023-11-21.at.11.04.42.PM.mov

allroundexperts

mweb screenshots are missing but since this is urgent, I'm approving this.

melvin-bot · 2023-11-21T18:26:11Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #25098 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

…s-migration/Button/component

mountiny · 2023-11-21T23:28:44Z

@srikarparsi got the review on this one

@allroundexperts thanks for the review

…s-migration/Button/component

kubabutkiewicz · 2023-11-24T10:03:57Z

@srikarparsi kindly bump 🙏

srikarparsi

lgtm

OSBotify · 2023-11-25T00:46:15Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-11-27T19:22:46Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.4-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-11-29T11:45:22Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.4-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kubabutkiewicz added 6 commits November 9, 2023 09:11

ref: adjusted types and finish ts migration

db66206

fix: lint and type issues

ec3f466

chore: rerun jobs

766c7d5

fix: removed log

4315fee

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

aa16641

…s-migration/Button/component

fix: types issues

060fc5b

VickyStash suggested changes Nov 9, 2023

View reviewed changes

kubabutkiewicz added 2 commits November 9, 2023 12:27

fix: type issue

a353175

fix: resolve comments

defdcac

blazejkustra suggested changes Nov 9, 2023

View reviewed changes

kubabutkiewicz added 2 commits November 9, 2023 16:19

fix: resolved comments

5c707c1

fix: removed unnecessary hoc

0f86446

blazejkustra approved these changes Nov 9, 2023

View reviewed changes

kubabutkiewicz marked this pull request as ready for review November 13, 2023 14:37

kubabutkiewicz requested a review from a team as a code owner November 13, 2023 14:37

melvin-bot bot requested review from allroundexperts and removed request for a team November 13, 2023 14:37

kubabutkiewicz added 2 commits November 13, 2023 15:38

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

d2f719d

…s-migration/Button/component

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

2cf21f5

…s-migration/Button/component

allroundexperts reviewed Nov 14, 2023

View reviewed changes

kubabutkiewicz added 2 commits November 15, 2023 18:17

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

f358f92

…s-migration/Button/component

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

1d9e673

…s-migration/Button/component

mountiny added the Ready To Build label Nov 20, 2023

kubabutkiewicz added 2 commits November 20, 2023 15:48

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

ae4e159

…s-migration/Button/component

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

3774805

…s-migration/Button/component

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

a388735

…s-migration/Button/component

allroundexperts approved these changes Nov 21, 2023

View reviewed changes

melvin-bot bot requested a review from srikarparsi November 21, 2023 18:26

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

9154332

…s-migration/Button/component

kubabutkiewicz added 4 commits November 22, 2023 09:51

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

ddb7674

…s-migration/Button/component

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

9e359a2

…s-migration/Button/component

Merge branch 'main' of github.com:kubabutkiewicz/expensify-app into t…

d4bf0ee

…s-migration/Button/component

fix: reassure tests

46825fd

srikarparsi approved these changes Nov 25, 2023

View reviewed changes

srikarparsi merged commit d985a0e into Expensify:main Nov 25, 2023
15 checks passed

github-actions bot mentioned this pull request Nov 27, 2023

Deploy Checklist: New Expensify 2023-11-27 #32066

Closed

53 tasks

lanitochka17 mentioned this pull request Nov 27, 2023

[LOW] [Splits] [$500] Web - IOU is greyed out, error message appears in chat and console #32076

Closed

6 tasks

melvin-bot bot mentioned this pull request Nov 29, 2023

[HOLD for payment 2023-12-06] [TS migration] Migrate 'Button' component to TypeScript #25098

Closed

	iconStyles?: Array<StyleProp<ViewStyle>>;
	iconStyles?: StyleProp<ViewStyle>;

	iconRightStyles?: Array<StyleProp<ViewStyle>>;
	iconRightStyles?: StyleProp<ViewStyle>;

	onPress?: (e?: GestureResponderEvent \| KeyboardEvent) => void;
	onPress?: (event?: GestureResponderEvent \| KeyboardEvent) => void;

	onLongPress?: (e?: GestureResponderEvent) => void;
	onLongPress?: (event?: GestureResponderEvent) => void;

	export default withNavigationFallback(React.forwardRef(ButtonWithRef));
	export default withNavigationFallback(React.forwardRef(Button));

	if (event && event.type === 'click') {
	if (event?.type === 'click') {

[TS migration] Migrate 'Button' component to TypeScript #31102

[TS migration] Migrate 'Button' component to TypeScript #31102

Conversation

kubabutkiewicz commented Nov 9, 2023 • edited by github-actions bot Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 13, 2023

BartoszGrajdek commented Nov 14, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kubabutkiewicz commented Nov 17, 2023

mountiny commented Nov 20, 2023

mountiny commented Nov 20, 2023

OSBotify commented Nov 20, 2023

blazejkustra commented Nov 21, 2023

allroundexperts commented Nov 21, 2023

parasharrajat commented Nov 21, 2023

allroundexperts commented Nov 21, 2023

allroundexperts commented Nov 21, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Nov 21, 2023

mountiny commented Nov 21, 2023

kubabutkiewicz commented Nov 24, 2023

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Nov 25, 2023

OSBotify commented Nov 27, 2023

OSBotify commented Nov 29, 2023

kubabutkiewicz commented Nov 9, 2023 •

edited by github-actions bot

Loading

allroundexperts commented Nov 21, 2023 •

edited

Loading