Fix the weird links on the Footer

[thienlnam]

Log into the app on web, make sure the links iOS and Android look similar to the Desktop and Sign out links

[shawnborton]

Did you check that this isn't going to make iOS puke?

[thienlnam]

Good point, I am testing this now

[shawnborton]

I was also looking into this and I am a bit stumped. Typically we don't include any units on things like lineHeight, but RN should spit out a px for us to give us a desired lineHeight of 20px. However, on web, it seems like it stays at line-height: 20 which makes the style look super borked:

I know we have two different files for how we display the anchor component based on web or native:

Any ideas?

[shawnborton]

It's strange that the fontSize does indeed get the px...

[tgolen]

Are you sure you're setting lineHeight: 20 and not lineHeight: '20'? (notice the quotes around 20)

[shawnborton]

Yup, I am sure I am setting it as a number and not a string.

[thienlnam]

Yeah I ran into the same issue which is why I had to specifically declare '20px' instead of 20

[tgolen]

OK, I think I know what's causing this. Since <a> (an HTML tag) is being rendered instead of a RN specific tag, that's why the lineHeight is being applied differently. I'm going to see if I can figure out some kind of better solution to this.

[shawnborton]

Did you check iOS when doing that though? This is what I see:

[tgolen]

OK, I think I know what we need to do. We can ONLY use <Anchor> for the links in comments... Everywhere else, we need to use this:

<Text style={{color: 'blue'}}
      onPress={() => Linking.openURL('http://google.com')}>
  Google
</Text>

This is kind of my bad... what I would suggest is renaming <Anchor> to be <AnchorForCommentsOnly>, then create <Anchor> and have it use the implementation above.

[thienlnam]

Okay this is updated and ready for another look!

[shawnborton]

🤦 My bad I meant to just approve these changes (I pulled and tested on both web and iOS) and not merge, I haven't had enough coffee yet. Apologies @tgolen !

[thienlnam]

I am going to add this to my I need more coffee moments https://docs.google.com/document/d/10eIm0CQy8uqs9y4CtFbBEFgOLTACTnq9qoMNlzOE8aA/edit?usp=sharing

[tgolen]

Haha, no worries, Shawn 👍 It's all good here. Thanks for the changes, Jack!