Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert: from empty string to null #29893

Merged
merged 3 commits into from
Oct 19, 2023
Merged

revert: from empty string to null #29893

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c21543a
revert: from empty string to null
5war00p Oct 18, 2023
0ee0cef
chore: added comment for null
5war00p Oct 18, 2023
d26e300
docs: update report id to be null w.r.to onyx
5war00p Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/pages/home/ReportScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ const defaultProps = {
* @returns {String}
*/
function getReportID(route) {
return String(lodashGet(route, 'params.reportID', ''));
// // The reportID is used inside a collection key and should not be empty, as an empty reportID will result in the entire collection being returned.
return String(lodashGet(route, 'params.reportID', null));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment explaining that reportID should not be empty.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, doing that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, coming from the conversation here, seems this is a system design issue because we shouldn't return a string "null" if the reportID doesn't exist. Hopefully, this will be solved (or at least tracked) when we migrate this file to TS

}

function ReportScreen({
Expand Down
Loading