Fix: navigate to enable-payment page after adding Bank account #29847

getusha · 2023-10-18T08:43:49Z

Details

Previously we were navigating to wallet page after adding PBA

App/src/pages/AddPersonalBankAccountPage.js

Lines 93 to 95 in 3b86da6

    
           } else { 
        
               Navigation.goBack(ROUTES.SETTINGS_WALLET); 
        
           }

Added setPersonalBankAccountContinueKYCOnSuccess with fallback route parameter which will be used to navigate to any route we passed after adding PBA, in this case since the expected result is to land on Additional Information page, we are setting the fallback route to ROUTES.ENABLE_PAYMENTS. we can't expect the route to be ENABLE_PAYMENTS always, there are cases where we want to navigate the user back to wallet page e.g.

Fixed Issues

$ #29726
PROPOSAL:

Tests

User A:

Select Request money
Enter User B as the person you're requesting from

User B:

Navigate to the IOU report
Select Pay with Expensify
Select Bank account
Add a personal bank account
Choose account from drop down menu and click Save & continue > Continue
Verify that Additional details page is opened.

Verify that no errors appear in the JS console

Offline tests

N/a

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2023-10-18.at.2.39.59.PM.mov

Android: mWeb Chrome

confirm-pg-mweban.mov

iOS: Native

confirm-pg-ios.mov

iOS: mWeb Safari

confirm-pg-ba-msafari.mov

MacOS: Chrome / Safari

confirm-pg-ba.mov

MacOS: Desktop

Screen.Recording.2023-10-18.at.1.35.36.PM.mov

melvin-bot · 2023-10-18T11:45:38Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/types/onyx/PersonalBankAccount.ts

getusha · 2023-10-18T15:04:25Z

@abdulrahuman5196 removed the redundant param.

abdulrahuman5196 · 2023-10-18T16:11:15Z

Thank you checking again

abdulrahuman5196 · 2023-10-18T18:05:22Z

@getusha Kindly add information in the details section of the PR.

Curious question: I was testing and the Add Additional details page was shown. But entering some data there and pressing save doesn't work and throws error. Is that expected to work in the PR scope or some limitation in test account causing the issue?

getusha · 2023-10-18T18:10:27Z

Kindly add information in the details section of the PR.

@abdulrahuman5196 could you help me understand what kind of information i should add?

abdulrahuman5196 · 2023-10-18T18:12:59Z

Kindly add information in the details section of the PR.

@abdulrahuman5196 could you help me understand what kind of information i should add?

Like What is this PR for? What are we changing here? Same as other PRs 🤔

Since we also don't have a proposal it would be hard for someone else to understand in future the change made here

@getusha

getusha · 2023-10-18T18:32:27Z

@abdulrahuman5196 added some details, tried to explain what's going on here.

abdulrahuman5196 · 2023-10-18T19:36:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-18.at.11.40.03.PM.mp4

Mobile Web - Chrome

Screen.Recording.2023-10-18.at.11.47.52.PM.mp4

Mobile Web - Safari

Screen.Recording.2023-10-18.at.11.45.53.PM.mp4

Desktop

Screen.Recording.2023-10-19.at.12.00.01.AM.mp4

iOS

Screen.Recording.2023-10-18.at.11.52.25.PM.mp4

Android

Screen.Recording.2023-10-18.at.11.53.52.PM.mp4

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @MariaHCD

🎀 👀 🎀
C+ Reviewed

melvin-bot · 2023-10-18T19:39:54Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #29726 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

abdulrahuman5196 · 2023-10-18T19:40:29Z

@MariaHCD Do check the attached videos as well on the reviewers checklist

thienlnam · 2023-10-18T22:04:02Z

src/libs/actions/BankAccounts.ts

+/**
+ * Whether after adding a bank account we should continue with the KYC flow
+ */


NAB: Stores a route that is navigated to after successfully adding a bank account

OSBotify · 2023-10-18T22:10:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-19T00:32:28Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-19T00:58:09Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.87-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-20T21:07:13Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.87-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-20T21:39:36Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-23T04:51:48Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 1.3.88-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

thienlnam · 2023-10-23T17:05:51Z

@getusha After some testing it looks like the flow still drops you back into the wallet page instead of wallet/enable-payments. Any ideas why that might be happening?

cc @kevinksullivan

abdulrahuman5196 · 2023-10-27T17:42:37Z

@getusha Sorry missed this message. Was this fixed now?

getusha · 2023-10-27T17:45:27Z

@abdulrahuman5196 I was unable to reproduce the issue following the steps described on the issue
please check this thread https://expensify.slack.com/archives/C01GTK53T8Q/p1698080894924559

abdulrahuman5196 · 2023-10-27T17:46:44Z

Thanks for the thread link @getusha. I wasn't aware of it. Seems good in the thread.

getusha added 3 commits October 18, 2023 11:41

fix navigate to enable-payment page after adding Bank account

2692910

run prettier

912aa44

run prettier

5f78a22

getusha marked this pull request as ready for review October 18, 2023 11:45

getusha requested a review from a team as a code owner October 18, 2023 11:45

melvin-bot bot removed the request for review from a team October 18, 2023 11:45

melvin-bot bot requested a review from abdulrahuman5196 October 18, 2023 11:45

abdulrahuman5196 reviewed Oct 18, 2023

View reviewed changes

src/types/onyx/PersonalBankAccount.ts Outdated Show resolved Hide resolved

abdulrahuman5196 suggested changes Oct 18, 2023

View reviewed changes

src/types/onyx/PersonalBankAccount.ts Outdated Show resolved Hide resolved

remove redundant parameter

5d73a1f

abdulrahuman5196 approved these changes Oct 18, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 October 18, 2023 19:39

thienlnam approved these changes Oct 18, 2023

View reviewed changes

thienlnam merged commit 843b955 into Expensify:main Oct 18, 2023
16 checks passed

OSBotify mentioned this pull request Oct 18, 2023

Deploy Checklist: New Expensify 2023-10-18 #29926

Closed

64 tasks

melvin-bot bot mentioned this pull request Oct 20, 2023

[HOLD for payment 2023-10-27] [P2P Activation] Adding a bank account while enabling an Expensify Wallet drops you in the Wallet page rather than continuing the enablement flow #29726

Closed

6 tasks

OSBotify mentioned this pull request Oct 20, 2023

Deploy Checklist: New Expensify 2023-10-20 #30108

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: navigate to enable-payment page after adding Bank account #29847

Fix: navigate to enable-payment page after adding Bank account #29847

getusha commented Oct 18, 2023 •

edited

Loading

melvin-bot bot commented Oct 18, 2023

getusha commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023

getusha commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023 •

edited

Loading

getusha commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023 •

edited

Loading

abdulrahuman5196 left a comment

melvin-bot bot commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023

thienlnam Oct 18, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 19, 2023

OSBotify commented Oct 19, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

thienlnam commented Oct 23, 2023

abdulrahuman5196 commented Oct 27, 2023

getusha commented Oct 27, 2023

abdulrahuman5196 commented Oct 27, 2023 •

edited

Loading

Fix: navigate to enable-payment page after adding Bank account #29847

Fix: navigate to enable-payment page after adding Bank account #29847

Conversation

getusha commented Oct 18, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 18, 2023

getusha commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023

getusha commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023 • edited Loading

getusha commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 18, 2023

abdulrahuman5196 commented Oct 18, 2023

thienlnam Oct 18, 2023

Choose a reason for hiding this comment

OSBotify commented Oct 18, 2023

OSBotify commented Oct 19, 2023

OSBotify commented Oct 19, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 20, 2023

OSBotify commented Oct 23, 2023

thienlnam commented Oct 23, 2023

abdulrahuman5196 commented Oct 27, 2023

getusha commented Oct 27, 2023

abdulrahuman5196 commented Oct 27, 2023 • edited Loading

getusha commented Oct 18, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 18, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 18, 2023 •

edited

Loading

abdulrahuman5196 commented Oct 27, 2023 •

edited

Loading