Update UI to show fraud states #29680

pasyukevich · 2023-10-16T14:31:08Z

Details

Fixed Issues

$ #22881
PROPOSAL:

Tests

1.Update the getComponent for SCREENS.SETTINGS.WALLET, in SettingsModalStackNavigator to import the component from ../../../pages/settings/Wallet/WalletPage/WalletPage
2. Initialise cardList with mock data:

useEffect(() => {
        window.Onyx.merge(`cardList`, {
          234523452345: {
            cardID: 234523452345,
            state: 3,
            bank: "Expensify Card",
            availableSpend: 10000,
            domainName: "expensify",
            lastFourPAN: "",
            isVirtual: true,
            fraud: "individual",
          },
          234523452346: {
            cardID: 234523452346,
            state: 3,
            bank: "Expensify Card",
            availableSpend: 10000,
            domainName: "expensify",
            lastFourPAN: "2345",
            isVirtual: false,
            fraud: "individual",
          },
        });
      }, [cardList]);

Navigate to the wallet
Observe that assigned cards have red dots
Press on one of them
Observe the section with the suspicious transactions and review the transaction button (by pressing it user’s old dot inbox should be opened)
Update test data with fraud: "domain" for one of the cards
Navigate to the wallet
Press on one of the assigned card
Observe that "Your card is temporarily locked while our team reviews your company's account." the message showed with a red dot and all other elements are hidden

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

native-androidp1.webm

native-androidp2.webm

Android: mWeb Chrome

web-android.mp4

iOS: Native

native-ios.mp4

iOS: mWeb Safari

web-ios.mp4

MacOS: Chrome / Safari

web-desktop.mp4

MacOS: Desktop

desktop.mp4

pac-guerreiro · 2023-10-17T16:20:53Z

src/CONST.ts

@@ -1237,7 +1237,7 @@ const CONST = {
        BANK: 'Expensify Card',
        FRAUD_TYPES: {
            DOMAIN: 'domain',
-            INDIVIDUAL: 'individal',
+            INDIVIDUAL: 'individual',


melvin-bot · 2023-10-18T13:04:54Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/languages/es.ts

src/pages/settings/Wallet/ExpensifyCardPage.js

grgia · 2023-10-19T12:18:00Z

src/components/DotIndicatorMessage.js

+
+    // Additional styles to apply to the text
+    // eslint-disable-next-line react/forbid-prop-types
+    textStyle: PropTypes.arrayOf(PropTypes.object),


could we rename this textStyles as it's an array?

grgia · 2023-10-19T12:18:56Z

src/pages/settings/Wallet/ExpensifyCardPage.js

@@ -62,6 +66,9 @@ function ExpensifyCardPage({
        setShouldShowCardDetails(true);
    };

+    const isDetectedDomainFraud = _.some(domainCards, (card) => card.fraud === CONST.EXPENSIFY_CARD.FRAUD_TYPES.DOMAIN);


I think these read better:
hasDetectedDomainFraud
hasDetectedIndividualFraud

grgia · 2023-10-19T12:28:15Z

src/pages/settings/Wallet/ExpensifyCardPage.js

-                            titleStyle={styles.newKansasLarge}
-                        />
-                        {!_.isEmpty(virtualCard) && (
+                        {isDetectedDomainFraud && (


Let's use the Boolean ? () : null pattern instead of && for these.

grgia · 2023-10-19T12:29:37Z

src/pages/settings/Wallet/ExpensifyCardPage.js

-                                titleStyle={styles.walletCardMenuItem}
-                            />
+
+                        {!isDetectedDomainFraud && (


Is there a way we could default to this without depending on the fraud variables? Since this the core of this page

Due to the requirements, we need to hide this block in case of detected domain fraud

eVoloshchak · 2023-10-19T14:35:16Z

src/components/DotIndicatorMessage.js

+
+    // Additional styles to apply to the text
+    // eslint-disable-next-line react/forbid-prop-types
+    textStyle: PropTypes.arrayOf(PropTypes.object),


We can use stylePropTypes for this

eVoloshchak · 2023-10-19T15:00:11Z

src/components/DotIndicatorMessage.js

 };

 const defaultProps = {
    messages: {},
    style: [],
+    textStyle: [],
 };

 function DotIndicatorMessage(props) {


Not directly related to this PR, but since we're adding changes to this component, let's use prop destructuring, it's documented as a best practice now

// Bad function UserInfo(props) { return ( <View> <Text>Name: {props.name}</Text> <Text>Email: {props.email}</Text> </View> } UserInfo.defaultProps = { name: 'anonymous'; } // Good function UserInfo({ name = 'anonymous', email }) { return ( <View> <Text>Name: {name}</Text> <Text>Email: {email}</Text> </View> ); }

I'm not sure that we need to update this in the scope of the current task

I believe that the best way is to apply it with typescript migration

eVoloshchak · 2023-10-19T15:10:00Z

src/pages/settings/Wallet/ExpensifyCardPage.js

                                    shouldShowRightIcon
-                                    onPress={() => Navigation.navigate(ROUTES.SETTINGS_REPORT_FRAUD.getRoute(domain))}
+                                    brickRoadIndicator="error"
+                                    onPress={() => Link.openOldDotLink('inbox')}


We should leave a note that this won't work in DEV and staging too, only in production (I wonder if buildOldDotURL is supposed to add environment to URL, since there is no dev/staging version of oldDot)

Screen.Recording.2023-10-19.at.17.06.52.mov

We should leave a note that this won't work in DEV and staging too, only in production (I wonder if buildOldDotURL is supposed to add environment to URL, since there is no dev/staging version of oldDot)

@0xmiroslav Internal employees do have a DEV/staging Old Dot

Ah you were tagging @eVoloshchak

I guess I'll have to change the profile pic, this isn't the first time this happens 😅

eVoloshchak · 2023-10-20T07:50:55Z

src/components/DotIndicatorMessage.js

@@ -25,11 +26,16 @@ const propTypes = {
    // Additional styles to apply to the container */
    // eslint-disable-next-line react/forbid-prop-types
    style: PropTypes.arrayOf(PropTypes.object),
+
+    // Additional styles to apply to the text
+    // eslint-disable-next-line react/forbid-prop-types


Suggested change

// eslint-disable-next-line react/forbid-prop-types

eVoloshchak · 2023-10-20T12:44:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-20.at.18.26.32.mov

Mobile Web - Chrome

screen-20231020-182140.mp4

Mobile Web - Safari

Screen.Recording.2023-10-20.at.18.18.15.mov

Desktop

Screen.Recording.2023-10-20.at.18.25.10.mov

iOS

Screen.Recording.2023-10-20.at.18.17.14.mov

Android

screen-20231020-182033.mp4

eVoloshchak

Looks and tests good, but there are a couple of propType warnings

Invalid prop cardList.234523452345.fraud of value individual supplied to ExpensifyCardPage, expected one of ["domain",null,"none"].

App/src/pages/settings/Wallet/assignedCardPropTypes.js

Line 13 in 69cf29e

fraud: PropTypes.oneOf([CONST.EXPENSIFY_CARD.FRAUD_TYPES.DOMAIN, CONST.EXPENSIFY_CARD.FRAUD_TYPES.USER, CONST.EXPENSIFY_CARD.FRAUD_TYPES.NONE]),

This line is at fault it seems
Update test data with fraud: "domain" for one of the cards, press on the card, observe the following propType warning: Invalid prop `messages` of type `array` supplied to `DotIndicatorMessage`, expected an object
We should replace messages={[translate('cardPage.cardLocked')]} with messages={{0: translate('cardPage.cardLocked')}}
Not sure if this one is related to the PR, but when you enter wallet page on native platforms (iOS/Android), the ‘VirtualizedLists should never be nested inside plain ScrollViews’ warning pops up

Screenshot

pasyukevich · 2023-10-20T15:40:39Z

@eVoloshchak
Updates applied for 1st and 2nd points.

The VirtualizedLists is not directly related to this PR since there are no structure changes on the wallet page, only the adding of new prop

eVoloshchak

LGTM

grgia · 2023-10-23T13:10:53Z

@eVoloshchak before I merge, can you confirm that you tested that the latest branch has no errors on all platforms

eVoloshchak · 2023-10-23T14:02:51Z

@grgia, merged the latest main and re-tested, no errors on all platforms

OSBotify · 2023-10-23T14:25:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-24T02:00:32Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.90-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-25T16:37:26Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-25T17:02:20Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.91-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-26T22:44:21Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.91-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

pasyukevich force-pushed the feature/show-fraud-states branch 3 times, most recently from 2c69338 to d13e96c Compare October 17, 2023 14:36

pac-guerreiro reviewed Oct 17, 2023

View reviewed changes

pasyukevich added 3 commits October 18, 2023 13:58

Update UI to show fraud states

156a966

fix typo for fraud types

06a9d0d

add error indicator for assigned cards

5fec082

pasyukevich force-pushed the feature/show-fraud-states branch from 8d6022c to 5fec082 Compare October 18, 2023 12:03

pasyukevich added 3 commits October 18, 2023 14:05

fix domain card navigation to the card page

ce7204a

fix detectedDomainFraud statement

6045346

apply prettier

e9c5514

pasyukevich marked this pull request as ready for review October 18, 2023 13:04

pasyukevich requested a review from a team as a code owner October 18, 2023 13:04

melvin-bot bot requested review from eVoloshchak and removed request for a team October 18, 2023 13:04

pac-guerreiro reviewed Oct 18, 2023

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

pac-guerreiro reviewed Oct 18, 2023

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage.js Outdated Show resolved Hide resolved

pac-guerreiro reviewed Oct 18, 2023

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage.js Outdated Show resolved Hide resolved

pac-guerreiro reviewed Oct 18, 2023

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage.js Outdated Show resolved Hide resolved

pasyukevich added 2 commits October 18, 2023 15:50

fix translation

77c0194

fix boolean namings

2fcb4f6

grgia reviewed Oct 19, 2023

View reviewed changes

eVoloshchak suggested changes Oct 19, 2023

View reviewed changes

pasyukevich added 2 commits October 19, 2023 18:35

Merge branch 'main' into feature/show-fraud-states

01557b8

apply comments

e3218aa

eVoloshchak suggested changes Oct 20, 2023

View reviewed changes

remove redundant eslint disable

cac1753

pasyukevich requested a review from eVoloshchak October 20, 2023 12:23

eVoloshchak suggested changes Oct 20, 2023

View reviewed changes

fix type warnings

3516f67

eVoloshchak approved these changes Oct 20, 2023

View reviewed changes

melvin-bot bot requested a review from grgia October 20, 2023 16:30

grgia approved these changes Oct 23, 2023

View reviewed changes

grgia merged commit 6ffc4e4 into Expensify:main Oct 23, 2023
14 checks passed

OSBotify mentioned this pull request Oct 24, 2023

Deploy Checklist: New Expensify 2023-10-24 #30224

Closed

43 tasks

melvin-bot bot mentioned this pull request Oct 25, 2023

[HOLD for payment 2023-11-01] [ECARD] CRITICAL: Settings - Update UI to show fraud states #22881

Closed

OSBotify mentioned this pull request Oct 25, 2023

Deploy Checklist: New Expensify 2023-10-25 #30365

Closed

99 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update UI to show fraud states #29680

Update UI to show fraud states #29680

pasyukevich commented Oct 16, 2023 •

edited

Loading

pac-guerreiro Oct 17, 2023

melvin-bot bot commented Oct 18, 2023

grgia Oct 19, 2023

pasyukevich Oct 19, 2023

grgia Oct 19, 2023

pasyukevich Oct 19, 2023

grgia Oct 19, 2023

pasyukevich Oct 19, 2023

grgia Oct 19, 2023

pasyukevich Oct 19, 2023

eVoloshchak Oct 19, 2023

pasyukevich Oct 19, 2023

eVoloshchak Oct 19, 2023

pasyukevich Oct 19, 2023

eVoloshchak Oct 19, 2023

grgia Oct 20, 2023

0xmiros Oct 20, 2023

eVoloshchak Oct 20, 2023

eVoloshchak Oct 20, 2023

pasyukevich Oct 20, 2023

eVoloshchak commented Oct 20, 2023 •

edited

Loading

eVoloshchak left a comment

pasyukevich commented Oct 20, 2023

eVoloshchak left a comment

grgia commented Oct 23, 2023

eVoloshchak commented Oct 23, 2023

OSBotify commented Oct 23, 2023

OSBotify commented Oct 24, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

Update UI to show fraud states #29680

Update UI to show fraud states #29680

Conversation

pasyukevich commented Oct 16, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

melvin-bot bot commented Oct 18, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eVoloshchak commented Oct 20, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

pasyukevich commented Oct 20, 2023

eVoloshchak left a comment

Choose a reason for hiding this comment

grgia commented Oct 23, 2023

eVoloshchak commented Oct 23, 2023

OSBotify commented Oct 23, 2023

OSBotify commented Oct 24, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 25, 2023

OSBotify commented Oct 26, 2023

pasyukevich commented Oct 16, 2023 •

edited

Loading

eVoloshchak commented Oct 20, 2023 •

edited

Loading